Add .pylintrc to globally suppress warnings we don't really care about

Also, drop the respective disable directives from existing files.

diff --git a/.pylintrc b/.pylintrc
new file mode 100644 (file)
index 0000000..afd811a
--- /dev/null
+++ b/.pylintrc
@@ -0,0 +1,23 @@
+[MAIN]
+extension-pkg-allow-list=lxml
+
+[MESSAGES CONTROL]
+disable=fixme,
+        invalid-name,
+        line-too-long,
+        missing-class-docstring,
+        missing-docstring,
+        missing-function-docstring,
+        missing-module-docstring,
+        too-few-public-methods,
+        too-many-arguments,
+        too-many-boolean-expressions,
+        too-many-branches,
+        too-many-instance-attributes,
+        too-many-instance-attributes,
+        too-many-lines,
+        too-many-locals,
+        too-many-public-methods,
+        too-many-return-statements,
+        too-many-statements,
+        unspecified-encoding,

diff --git a/src/kernel-install/60-ukify.install.in b/src/kernel-install/60-ukify.install.in
index ecef36b324918cf6cac24566c15ddb1c71f417d5..e5d68f37c0a6da00c11921b0101546f82b7c5a8b 100755 (executable)
--- a/src/kernel-install/60-ukify.install.in
+++ b/src/kernel-install/60-ukify.install.in
@@ -17,10 +17,7 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with systemd; If not, see <https://www.gnu.org/licenses/>.
 
-# pylint: disable=missing-docstring,invalid-name,import-outside-toplevel
-# pylint: disable=consider-using-with,unspecified-encoding,line-too-long
-# pylint: disable=too-many-locals,too-many-statements,too-many-return-statements
-# pylint: disable=too-many-branches,redefined-builtin,fixme
+# pylint: disable=import-outside-toplevel,consider-using-with,disable=redefined-builtin
 
 import argparse
 import os

diff --git a/src/ukify/test/test_ukify.py b/src/ukify/test/test_ukify.py
index 9a07f3397c4698a384ddf462206071b66c2b91f7..c83435ec184f745adae4c329312d733ef0a5db0b 100755 (executable)
--- a/src/ukify/test/test_ukify.py
+++ b/src/ukify/test/test_ukify.py
@@ -1,10 +1,9 @@
 #!/usr/bin/env python3
 # SPDX-License-Identifier: LGPL-2.1-or-later
 
-# pylint: disable=missing-docstring,redefined-outer-name,invalid-name
 # pylint: disable=unused-import,import-outside-toplevel,useless-else-on-loop
 # pylint: disable=consider-using-with,wrong-import-position,unspecified-encoding
-# pylint: disable=protected-access
+# pylint: disable=protected-access,redefined-outer-name
 
 import base64
 import json

diff --git a/src/ukify/ukify.py b/src/ukify/ukify.py
index cf7db49bdd18aba682b624e8d86930f2a74fc6f4..0ddf56ae5e2dabab308608ff9d8bfa7f9b70a36d 100755 (executable)
--- a/src/ukify/ukify.py
+++ b/src/ukify/ukify.py
@@ -16,12 +16,8 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with systemd; If not, see <https://www.gnu.org/licenses/>.
 
-# pylint: disable=missing-docstring,invalid-name,import-outside-toplevel
-# pylint: disable=consider-using-with,unspecified-encoding,line-too-long
-# pylint: disable=too-many-locals,too-many-statements,too-many-return-statements
-# pylint: disable=too-many-branches,too-many-lines,too-many-instance-attributes
-# pylint: disable=too-many-arguments,unnecessary-lambda-assignment,fixme
-# pylint: disable=unused-argument
+# pylint: disable=import-outside-toplevel,consider-using-with,unused-argument
+# pylint: disable=unnecessary-lambda-assignment
 
 import argparse
 import configparser

diff --git a/test/test-exec-deserialization.py b/test/test-exec-deserialization.py
index 7fbf9a4d1714c4d330368dce8f3d88ee979c126e..f8f3a6d272a635746025982ad97437f0732460c6 100755 (executable)
--- a/test/test-exec-deserialization.py
+++ b/test/test-exec-deserialization.py
@@ -1,8 +1,5 @@
 #!/usr/bin/env python3
 # SPDX-License-Identifier: LGPL-2.1-or-later
-# pylint: disable=line-too-long,too-many-lines,too-many-branches,too-many-statements,too-many-arguments
-# pylint: disable=too-many-public-methods,too-many-boolean-expressions,invalid-name,no-self-use
-# pylint: disable=missing-function-docstring,missing-class-docstring,missing-module-docstring
 #
 #  Copyright © 2017 Michal Sekletar <msekleta@redhat.com>
 

diff --git a/test/test-network/systemd-networkd-tests.py b/test/test-network/systemd-networkd-tests.py
index 7f922b46f6cebade45d5b418ed4d491bd8323a1f..07afe354f79ec636ca51eb86d2835ffd11eed91c 100755 (executable)
--- a/test/test-network/systemd-networkd-tests.py
+++ b/test/test-network/systemd-networkd-tests.py
@@ -1,8 +1,5 @@
 #!/usr/bin/env python3
 # SPDX-License-Identifier: LGPL-2.1-or-later
-# pylint: disable=line-too-long,too-many-lines,too-many-branches,too-many-statements,too-many-arguments
-# pylint: disable=too-many-public-methods,too-many-boolean-expressions,invalid-name
-# pylint: disable=missing-function-docstring,missing-class-docstring,missing-module-docstring
 # systemd-networkd tests
 
 # These tests can be executed in the systemd mkosi image when booted in QEMU. After booting the QEMU VM,

diff --git a/test/test-shutdown.py b/test/test-shutdown.py
index 700e77a15db34b8235dec2fe0832817a4c9a730d..5339afcdd09147ef5301626a6e3642d5933ff088 100755 (executable)
--- a/test/test-shutdown.py
+++ b/test/test-shutdown.py
@@ -1,6 +1,6 @@
 #!/usr/bin/python3
 # SPDX-License-Identifier: LGPL-2.1-or-later
-# pylint: disable=line-too-long,invalid-name,missing-module-docstring,missing-function-docstring,too-many-statements,broad-except
+# pylint: disable=broad-except
 
 import argparse
 import logging

diff --git a/test/test-udev.py b/test/test-udev.py
index 02383ce4e9b0d7bb28474e39a868c2b64788de2a..5a95b9c521315fd9aa05a1137cee0326d5ed659c 100755 (executable)
--- a/test/test-udev.py
+++ b/test/test-udev.py
@@ -1,10 +1,8 @@
 #!/usr/bin/env python3
 # SPDX-License-Identifier: LGPL-2.1-or-later
 
-# pylint: disable=missing-docstring,redefined-outer-name,invalid-name
-# pylint: disable=unspecified-encoding,no-else-return,line-too-long,too-many-lines
-# pylint: disable=multiple-imports,too-many-instance-attributes,consider-using-with
-# pylint: disable=global-statement
+# pylint: disable=redefined-outer-name,no-else-return,multiple-imports
+# pylint: disable=consider-using-with,global-statement
 
 # udev test
 #

diff --git a/tools/elf2efi.py b/tools/elf2efi.py
index 2e478940f5c17fff15eb0c2dea79ab243ac733cf..c683c120762fd2bc1d6fd0cdf7ef334ecdc9a74b 100755 (executable)
--- a/tools/elf2efi.py
+++ b/tools/elf2efi.py
@@ -19,7 +19,7 @@
 # the resulting binary useless. gnu-efi relies on this method and contains a stub that performs the
 # ELF dynamic relocations at runtime.
 
-# pylint: disable=missing-docstring,invalid-name,attribute-defined-outside-init
+# pylint: disable=attribute-defined-outside-init
 
 import argparse
 import hashlib