]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udev: upgrade log level about failure in updating devlinks 19791/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 2 Jun 2021 10:26:29 +0000 (19:26 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 2 Jun 2021 12:00:45 +0000 (21:00 +0900)
src/udev/udev-node.c

index 422f6028ade04f0e9af6292cef0d108a10d5741c..a6abaa1a9da22350c41ec7eb1c386410c9557f96 100644 (file)
@@ -344,7 +344,11 @@ int udev_node_update_old_links(sd_device *dev, sd_device *dev_old) {
 
                 log_device_debug(dev, "Updating old name, '%s' no longer belonging to '%s'",
                                  name, devpath);
-                link_update(dev, name, false);
+                r = link_update(dev, name, false);
+                if (r < 0)
+                        log_device_warning_errno(dev, r,
+                                                 "Failed to update device symlink '%s', ignoring: %m",
+                                                 name);
         }
 
         return 0;
@@ -535,7 +539,9 @@ int udev_node_add(sd_device *dev, bool apply,
         FOREACH_DEVICE_DEVLINK(dev, devlink) {
                 r = link_update(dev, devlink, true);
                 if (r < 0)
-                        log_device_info_errno(dev, r, "Failed to update device symlinks: %m");
+                        log_device_warning_errno(dev, r,
+                                                 "Failed to update device symlink '%s', ignoring: %m",
+                                                 devlink);
         }
 
         return 0;
@@ -552,7 +558,9 @@ int udev_node_remove(sd_device *dev) {
         FOREACH_DEVICE_DEVLINK(dev, devlink) {
                 r = link_update(dev, devlink, false);
                 if (r < 0)
-                        log_device_info_errno(dev, r, "Failed to update device symlinks: %m");
+                        log_device_warning_errno(dev, r,
+                                                 "Failed to update device symlink '%s', ignoring: %m",
+                                                 devlink);
         }
 
         r = xsprintf_dev_num_path_from_sd_device(dev, &filename);