]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Coverity 1531836: Check return value of CRYPTO_atomic_add()
authorTomas Mraz <tomas@openssl.org>
Wed, 7 Jun 2023 11:22:19 +0000 (13:22 +0200)
committerTodd Short <todd.short@me.com>
Sat, 10 Jun 2023 23:23:59 +0000 (19:23 -0400)
providers/implementations/rands/drbg.c

index 4690d73cca918c572e8984e9e1b46670e8375b2a..7a4854f0d7cc4c7f59da74b3c2de4e9bc1eb95a4 100644 (file)
@@ -335,8 +335,9 @@ static size_t prov_drbg_get_nonce(PROV_DRBG *drbg, unsigned char **pout,
     /* Use the built in nonce source plus some of our specifics */
     memset(&data, 0, sizeof(data));
     data.drbg = drbg;
-    CRYPTO_atomic_add(&dngbl->rand_nonce_count, 1, &data.count,
-                      dngbl->rand_nonce_lock);
+    if (!CRYPTO_atomic_add(&dngbl->rand_nonce_count, 1, &data.count,
+                      dngbl->rand_nonce_lock))
+        return 0;
     return ossl_prov_get_nonce(drbg->provctx, pout, min_len, max_len,
                                &data, sizeof(data));
 }