Comment on the two remaining scanbuild cases. At first sight these are both false...

diff --git a/pdns/lwres.cc b/pdns/lwres.cc
index 933b469b8762433ef2d15456a6aa3abc1125a035..c100c0503739f30959920f52d19f6cc41d6eaab4 100644 (file)
--- a/pdns/lwres.cc
+++ b/pdns/lwres.cc
@@ -441,7 +441,7 @@ static LWResult::Result asyncresolve(const ComboAddress& ip, const DNSName& doma
         // work, we give up. For reused connections, we assume the
         // peer has closed it on error, so we retry. At some point we
         // *will* get a new connection, so this loop is not endless.
-        isNew = true; // tcpconnect() might throw for new connections. In that case, we want to break the loop
+        isNew = true; // tcpconnect() might throw for new connections. In that case, we want to break the loop, scanbuild complains here, which is a false positive afaik
         std::string nsName;
         if (context && !context->d_nsName.empty()) {
           nsName = context->d_nsName.toStringNoDot();

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index cbf4c85a8a342f1044fe6aabbe56c49bce116114..dc9b1f3e85019925108955e35c9482b57155e946 100644 (file)
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -2712,6 +2712,7 @@ struct WipeCacheResult wipeCaches(const DNSName& canon, bool subtree, uint16_t q
 
   try {
     res.record_count = g_recCache->doWipeCache(canon, subtree, qtype);
+    // scanbuild complains here about an allocated function object that is being leaked. Needs investigation
     res.packet_count = broadcastAccFunction<uint64_t>([=] { return pleaseWipePacketCache(canon, subtree, qtype); });
     res.negative_record_count = g_negCache->wipe(canon, subtree);
     if (g_aggressiveNSECCache) {