Fix sparc memcpy data corruption when using niagara2 optimized routines.

	* sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S: Add missing
	membar to avoid block loads/stores to overlap previous stores.

diff --git a/ChangeLog b/ChangeLog
index 7e235ac392cb4df65a36fa87d11daa4c55354edb..ef667cc9b9a4c29c50224e69ac477e5f0aeeb413 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-05-17  Jose E. Marchesi  <jose.marchesi@oracle.com>
+
+       [BZ #16958]
+       * sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S: Add missing
+       membar to avoid block loads/stores to overlap previous stores.
+
 2014-05-16  Aurelien Jarno  <aurelien@aurel32.net>
 
        [BZ #16943]

diff --git a/NEWS b/NEWS
index 7703b6ee1c2d69a27178720148fece2de9e1717d..9ab955a3015fe2fca0b005e2b3116451284e2f73 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -8,7 +8,7 @@ using `glibc' in the "product" field.
 Version 2.17.1
 
 * The following bugs are resolved with this release:
-  15003, 15006, 15073, 15122, 15759, 16510, 16885, 16916, 16943.
+  15003, 15006, 15073, 15122, 15759, 16510, 16885, 16916, 16943, 16958.
 
 \f
 Version 2.17

diff --git a/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S b/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S
index fb815e5e57113f8f7d57974d6ea9719e4297d927..93f87f739061a99cada2130dabfd9fffc2bc3dfb 100644 (file)
--- a/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S
+++ b/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S
@@ -211,6 +211,7 @@ ENTRY(__memcpy_niagara2)
         */
        VISEntryHalf
 
+       membar          #Sync
        alignaddr       %o1, %g0, %g0
 
        add             %o1, (64 - 1), %o4