tls-crypto: Only log modified TLS versions if successfully set

If no cipher suites are available, the new versions are the previous
values but reversed (i.e. the versions were not changed but we still
ended up with a log message saying "TLS min/max TLS 1.3/TLS 1.0 ...").

Also switched to using the numeric version names to avoid the repeated
"TLS" prefix.

diff --git a/src/libtls/tls_crypto.c b/src/libtls/tls_crypto.c
index e8126c0008a8862b5a2d14c382e4f938f792b831..23c36374e6da59732ec48ea7b3eed720e80ae85f 100644 (file)
--- a/src/libtls/tls_crypto.c
+++ b/src/libtls/tls_crypto.c
@@ -1222,12 +1222,12 @@ static void build_cipher_suite_list(private_tls_crypto_t *this)
        new_max_version = min(new_max_version, max_version);
        new_min_version = max(new_min_version, min_version);
 
-       if (min_version != new_min_version || max_version != new_max_version)
+       if ((min_version != new_min_version || max_version != new_max_version) &&
+               this->tls->set_version(this->tls, new_min_version, new_max_version))
        {
-               this->tls->set_version(this->tls, new_min_version, new_max_version);
                DBG2(DBG_TLS, "TLS min/max %N/%N according to the cipher suites",
-                        tls_version_names, new_min_version,
-                        tls_version_names, new_max_version);
+                        tls_numeric_version_names, new_min_version,
+                        tls_numeric_version_names, new_max_version);
        }
 }