Author: Francesco Chemolli <kinkie@squid-cache.org>

Cleanups: Remove code handling K&R-style varargs.

It should be a safe enough bet that any C++ compiler can handle STDC-style varargs.
This patch removes all the (mostly spaghetti) code which used to handle K&R-style varargs calls.

diff --cc include/snmp_debug.h
Simple merge

diff --cc snmplib/snmplib_debug.c
index 63ca248f978084d120965eae16f7477c2e5372f6,ccf84dbc729a271e2b146fc335af6512ea8dcb60..8e398ccbdf01d1da9d5adbc270537c2a6eac5d70
--- 1/snmplib/snmplib_debug.c
--- 2/snmplib/snmplib_debug.c
+++ b/snmplib/snmplib_debug.c
@@@ -26,22 -17,11 +17,12 @@@ snmplib_debug(int lvl, const char *fmt,
      char buf[BUFSIZ];
      va_list args;
      va_start(args, fmt);
- #else
-     snmplib_debug(va_alist)
-     va_dcl {
-     va_list args;
-     int lvl;
-     char char *fmt;
-     char buf[BUFSIZ];
-     va_start(args);
-     lvl = va_arg(args, int);
-     fmt = va_arg(args, char *);
- #endif
++
      if (snmplib_debug_hook != NULL) {
 -      vsnprintf(buf, BUFSIZ, fmt, args);
 -      snmplib_debug_hook(lvl, buf);
 +        vsnprintf(buf, BUFSIZ, fmt, args);
 +        snmplib_debug_hook(lvl, buf);
      } else {
 -      vfprintf(stderr, fmt, args);
 +        vfprintf(stderr, fmt, args);
      }
      va_end(args);
  }

diff --cc src/HttpHeaderTools.cc
Simple merge

diff --cc src/MemBuf.cc
Simple merge

diff --cc src/MemBuf.h
Simple merge

diff --cc src/Packer.cc
Simple merge

diff --cc src/Packer.h
Simple merge

diff --cc src/Store.h
Simple merge

diff --cc src/debug.cc
index a37b929ca01f689f0d724e01b2f80fbafebebce9,dc294cc81e7c73e9b39516c94165f03bc64f63ad..466e4820d59cc88172a8ea4faa4dfb784dc6ec03
--- 1/src/debug.cc
--- 2/src/debug.cc
+++ b/src/debug.cc
@@@ -57,29 -57,18 +57,16 @@@ static void _db_print_file(const char *
  #ifdef _SQUID_MSWIN_
  SQUIDCEXTERN LPCRITICAL_SECTION dbg_mutex;
  typedef BOOL (WINAPI * PFInitializeCriticalSectionAndSpinCount) (LPCRITICAL_SECTION, DWORD);
--
  #endif
  
  void
- #if STDC_HEADERS
  _db_print(const char *format,...)
  {
- #else
- _db_print(va_alist)
- va_dcl {
-     const char *format = NULL;
- #endif
--
      LOCAL_ARRAY(char, f, BUFSIZ);
      va_list args1;
- #if STDC_HEADERS
--
      va_list args2;
      va_list args3;
- #else
- #define args2 args1
- #define args3 args1
- #endif
++
  #ifdef _SQUID_MSWIN_
      /* Multiple WIN32 threads may call this simultaneously */
  
@@@ -112,53 -102,45 +99,33 @@@
  
      EnterCriticalSection(dbg_mutex);
  #endif
--    /* give a chance to context-based debugging to print current context */
  
++    /* give a chance to context-based debugging to print current context */
      if (!Ctx_Lock)
          ctx_print();
  
- #if STDC_HEADERS
--
      va_start(args1, format);
--
      va_start(args2, format);
--
      va_start(args3, format);
  
- #else
- 
-     format = va_arg(args1, const char *);
- 
- #endif
--
      snprintf(f, BUFSIZ, "%s| %s",
               debugLogTime(),
               format);
  
      _db_print_file(f, args1);
--
      _db_print_stderr(f, args2);
  
  #if HAVE_SYSLOG
--
      _db_print_syslog(format, args3);
--
  #endif
--#ifdef _SQUID_MSWIN_
  
++#ifdef _SQUID_MSWIN_
      LeaveCriticalSection(dbg_mutex);
--
  #endif
  
      va_end(args1);
--
- #if STDC_HEADERS
--
      va_end(args2);
--
      va_end(args3);
--
- #endif
  }
  
  static void

diff --cc src/logfile.cc
Simple merge

diff --cc src/protos.h
Simple merge

diff --cc src/snmp_core.cc
Simple merge

diff --cc src/store.cc
Simple merge

diff --cc src/tests/stub_store.cc
Simple merge

diff --cc src/tools.cc
index 05a458de1599c847efc9c0684fa8f7d07b4c583b,39548c645ed2940e95d45797af15ac889d59f7f7..320604d18fd4d9dd7695f1d89d512aa331e88f6d
--- 1/src/tools.cc
--- 2/src/tools.cc
+++ b/src/tools.cc
@@@ -499,16 -498,7 +498,6 @@@ fatalf(const char *fmt,...
  {
      va_list args;
      va_start(args, fmt);
- #else
- void
- fatalf(va_alist)
- va_dcl {
-     va_list args;
-     const char *fmt = NULL;
-     va_start(args);
-     fmt = va_arg(args, char *);
- #endif
--
      fatalvf(fmt, args);
      va_end(args);
  }

diff --cc test-suite/test_tools.cc
index 3762038478bd62d040028d7e6ce1ea6934ee501b,37281fbfd8357c6fd388f77fab16ef2047e2eb89..02e33fb215d984aedcda70a2cb061c949f117f42
--- 1/test-suite/test_tools.cc
--- 2/test-suite/test_tools.cc
+++ b/test-suite/test_tools.cc
@@@ -31,40 -24,21 +31,17 @@@ static voi
  _db_print_stderr(const char *format, va_list args);
  
  void
- #if STDC_HEADERS
  _db_print(const char *format,...)
  {
- #else
- _db_print(va_alist)
- va_dcl {
-     const char *format = NULL;
- #endif
--
      LOCAL_ARRAY(char, f, BUFSIZ);
      va_list args1;
- #if STDC_HEADERS
--
      va_list args2;
      va_list args3;
- #else
- #define args2 args1
- #define args3 args1
- #endif
- 
- #if STDC_HEADERS
  
      va_start(args1, format);
--
      va_start(args2, format);
--
      va_start(args3, format);
  
- #else
- 
-     format = va_arg(args1, const char *);
- 
- #endif
- 
      snprintf(f, BUFSIZ, "%s| %s",
               "stub time", //debugLogTime(squid_curtime),
               format);
@@@ -72,14 -46,10 +49,8 @@@
      _db_print_stderr(f, args2);
  
      va_end(args1);
- 
- #if STDC_HEADERS
--
      va_end(args2);
--
      va_end(args3);
- 
- #endif
  }
  
  static void
@@@ -119,16 -88,7 +89,6 @@@ voi
  fatalf(const char *fmt,...) {
      va_list args;
      va_start(args, fmt);
- #else
- void
- fatalf(va_alist)
- va_dcl {
-     va_list args;
-     const char *fmt = NULL;
-     va_start(args);
-     fmt = va_arg(args, char *);
- #endif
--
      fatalvf(fmt, args);
      va_end(args);
  }