]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Error, rather than warn, if failing to start DHCP server
authorTom Fitzhenry <tom@tom-fitzhenry.me.uk>
Sat, 16 Nov 2019 15:04:18 +0000 (02:04 +1100)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Sun, 17 Nov 2019 13:31:43 +0000 (22:31 +0900)
This would have made diagnosing https://github.com/systemd/systemd/issues/14050 easier.

src/network/networkd-dhcp-server.c

index 77eb46341cc286fd1e83cd291776773a5667cf28..1ae1d17057c83f58ac30d32763f0c688566a4a53 100644 (file)
@@ -284,7 +284,7 @@ int dhcp4_server_configure(Link *link) {
 
         r = sd_dhcp_server_set_emit_router(link->dhcp_server, link->network->dhcp_server_emit_router);
         if (r < 0)
-                return log_link_warning_errno(link, r, "Failed to set router emission for DHCP server: %m");
+                return log_link_error_errno(link, r, "Failed to set router emission for DHCP server: %m");
 
         if (link->network->dhcp_server_emit_timezone) {
                 _cleanup_free_ char *buffer = NULL;
@@ -295,7 +295,7 @@ int dhcp4_server_configure(Link *link) {
                 else {
                         r = get_timezone(&buffer);
                         if (r < 0)
-                                return log_warning_errno(r, "Failed to determine timezone: %m");
+                                return log_error_errno(r, "Failed to determine timezone: %m");
 
                         tz = buffer;
                 }
@@ -316,7 +316,7 @@ int dhcp4_server_configure(Link *link) {
         if (!sd_dhcp_server_is_running(link->dhcp_server)) {
                 r = sd_dhcp_server_start(link->dhcp_server);
                 if (r < 0)
-                        return log_link_warning_errno(link, r, "Could not start DHCPv4 server instance: %m");
+                        return log_link_error_errno(link, r, "Could not start DHCPv4 server instance: %m");
         }
 
         return 0;