]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdb: remove unnecessary NULL checks for return value of value_from_register
authorSimon Marchi <simon.marchi@efficios.com>
Fri, 19 Jan 2024 15:35:37 +0000 (10:35 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Fri, 19 Jan 2024 16:29:20 +0000 (11:29 -0500)
value_from_register can't return nullptr, remove some NULL checks.

Change-Id: Ia6b32b8f86e593c535e3678a89dffe5544eb7ab0
Approved-By: Tom Tromey <tom@tromey.com>
gdb/findvar.c

index d0bb3fd320e7b51529bb944fb19d37c28e136c28..37b859c2347d5a418badaf5875ea540bb1f1ba32 100644 (file)
@@ -623,29 +623,12 @@ language_defn::read_var_value (struct symbol *var,
       {
        int regno = SYMBOL_REGISTER_OPS (var)
                      ->register_number (var, get_frame_arch (frame));
-       struct value *regval;
 
        if (var->aclass () == LOC_REGPARM_ADDR)
-         {
-           regval = value_from_register (lookup_pointer_type (type),
-                                         regno,
-                                         frame);
-
-           if (regval == NULL)
-             error (_("Value of register variable not available for `%s'."),
-                    var->print_name ());
-
-           addr = value_as_address (regval);
-         }
+         addr = value_as_address
+          (value_from_register (lookup_pointer_type (type), regno, frame));
        else
-         {
-           regval = value_from_register (type, regno, frame);
-
-           if (regval == NULL)
-             error (_("Value of register variable not available for `%s'."),
-                    var->print_name ());
-           return regval;
-         }
+         return value_from_register (type, regno, frame);
       }
       break;