]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
link-config: warn when MACAddress= is set with MACAddressPolicy=persistent or random
authorYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 20 Nov 2020 13:58:23 +0000 (22:58 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 20 Nov 2020 13:59:12 +0000 (22:59 +0900)
src/udev/net/link-config.c

index 0519635748cb77ffdeb6fc564be9d1a2c13fcd74..d12fd0e2991225b9b0fa8fd2d17e32104e43e126 100644 (file)
@@ -181,6 +181,13 @@ int link_load_one(link_config_ctx *ctx, const char *filename) {
                 return 0;
         }
 
+        if (IN_SET(link->mac_address_policy, MAC_ADDRESS_POLICY_PERSISTENT, MAC_ADDRESS_POLICY_RANDOM) && link->mac) {
+                log_warning("%s: MACAddress= in [Link] section will be ignored when MACAddressPolicy= "
+                            "is set to \"persistent\" or \"random\".",
+                            filename);
+                link->mac = mfree(link->mac);
+        }
+
         log_debug("Parsed configuration file %s", filename);
 
         LIST_PREPEND(links, ctx->links, TAKE_PTR(link));