]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Prevent alpha_vms_object_p stopping bfd_check_format_matches scan
authorAlan Modra <amodra@gmail.com>
Fri, 29 Aug 2014 01:07:52 +0000 (10:37 +0930)
committerAlan Modra <amodra@gmail.com>
Fri, 29 Aug 2014 01:07:52 +0000 (10:37 +0930)
Any error other than bfd_error_wrong_format returned from object_p()
is effectively a fatal error.

* vms-alpha.c (alpha_vma_object_p): Don't return file_truncated
error.  Remove redundant bfd_set_error.

bfd/ChangeLog
bfd/vms-alpha.c

index 3e005c9caed6b2f73b7695ff362712ff99388060..3c914be279c9ae2683b09488b9af1f182421c81d 100644 (file)
@@ -1,3 +1,8 @@
+2014-08-29  Alan Modra  <amodra@gmail.com>
+
+       * vms-alpha.c (alpha_vma_object_p): Don't return file_truncated
+       error.  Remove redundant bfd_set_error.
+
 2014-08-29  Alan Modra  <amodra@gmail.com>
 
        * srec.c (srec_scan): Revert last change.  Report an error for
index f62d324630e75c621c7a7924629d8d1cafb67aea..b7b85269c12475ddcf35fd240c33795d18769c4c 100644 (file)
@@ -2474,10 +2474,7 @@ alpha_vms_object_p (bfd *abfd)
   PRIV (recrd.rec) = buf;
 
   if (bfd_bread (buf, test_len, abfd) != test_len)
-    {
-      bfd_set_error (bfd_error_file_truncated);
-      goto error_ret;
-    }
+    goto err_wrong_format;
 
   /* Is it an image?  */
   if ((bfd_getl32 (buf) == EIHD__K_MAJORID)
@@ -2502,7 +2499,6 @@ alpha_vms_object_p (bfd *abfd)
           if (buf == NULL)
             {
               PRIV (recrd.buf) = NULL;
-              bfd_set_error (bfd_error_no_memory);
               goto error_ret;
             }
           PRIV (recrd.buf) = buf;
@@ -2517,10 +2513,7 @@ alpha_vms_object_p (bfd *abfd)
       while (remaining > 0)
         {
           if (bfd_bread (buf + read_so_far, to_read, abfd) != to_read)
-            {
-              bfd_set_error (bfd_error_file_truncated);
-              goto err_wrong_format;
-            }
+           goto err_wrong_format;
 
           read_so_far += to_read;
           remaining -= to_read;