]> git.ipfire.org Git - people/ms/linux.git/commitdiff
lib/test: introduce cpumask KUnit test suite
authorSander Vanheule <sander@svanheule.net>
Sat, 2 Jul 2022 16:08:26 +0000 (18:08 +0200)
committerakpm <akpm@linux-foundation.org>
Mon, 18 Jul 2022 00:31:41 +0000 (17:31 -0700)
Add a basic suite of tests for cpumask, providing some tests for empty and
completely filled cpumasks.

Link: https://lkml.kernel.org/r/c96980ec35c3bd23f17c3374bf42c22971545e85.1656777646.git.sander@svanheule.net
Signed-off-by: Sander Vanheule <sander@svanheule.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Suggested-by: Yury Norov <yury.norov@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Marco Elver <elver@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Valentin Schneider <vschneid@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/Kconfig.debug
lib/Makefile
lib/test_cpumask.c [new file with mode: 0644]

index 2e24db4bff1921483ad1bd1e181d242e6cd55345..04aaa20d50f9823fa9b7567b4a1f5fe12fdd33b9 100644 (file)
@@ -2021,6 +2021,15 @@ config LKDTM
        Documentation on how to use the module can be found in
        Documentation/fault-injection/provoke-crashes.rst
 
+config TEST_CPUMASK
+       tristate "cpumask tests" if !KUNIT_ALL_TESTS
+       depends on KUNIT
+       default KUNIT_ALL_TESTS
+       help
+         Enable to turn on cpumask tests, running at boot or module load time.
+
+         If unsure, say N.
+
 config TEST_LIST_SORT
        tristate "Linked list sorting test" if !KUNIT_ALL_TESTS
        depends on KUNIT
index bcc7e8ea0cde5c917aa8fbabd7f47bb01a9624b3..de3e47453fe8ebde6e96412c4537a6ce97ad0d33 100644 (file)
@@ -99,6 +99,7 @@ obj-$(CONFIG_TEST_HMM) += test_hmm.o
 obj-$(CONFIG_TEST_FREE_PAGES) += test_free_pages.o
 obj-$(CONFIG_KPROBES_SANITY_TEST) += test_kprobes.o
 obj-$(CONFIG_TEST_REF_TRACKER) += test_ref_tracker.o
+obj-$(CONFIG_TEST_CPUMASK) += test_cpumask.o
 CFLAGS_test_fprobe.o += $(CC_FLAGS_FTRACE)
 obj-$(CONFIG_FPROBE_SANITY_TEST) += test_fprobe.o
 #
diff --git a/lib/test_cpumask.c b/lib/test_cpumask.c
new file mode 100644 (file)
index 0000000..a31a162
--- /dev/null
@@ -0,0 +1,138 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * KUnit tests for cpumask.
+ *
+ * Author: Sander Vanheule <sander@svanheule.net>
+ */
+
+#include <kunit/test.h>
+#include <linux/cpu.h>
+#include <linux/cpumask.h>
+
+#define EXPECT_FOR_EACH_CPU_EQ(test, mask)                     \
+       do {                                                    \
+               const cpumask_t *m = (mask);                    \
+               int mask_weight = cpumask_weight(m);            \
+               int cpu, iter = 0;                              \
+               for_each_cpu(cpu, m)                            \
+                       iter++;                                 \
+               KUNIT_EXPECT_EQ((test), mask_weight, iter);     \
+       } while (0)
+
+#define EXPECT_FOR_EACH_CPU_NOT_EQ(test, mask)                                 \
+       do {                                                                    \
+               const cpumask_t *m = (mask);                                    \
+               int mask_weight = cpumask_weight(m);                            \
+               int cpu, iter = 0;                                              \
+               for_each_cpu_not(cpu, m)                                        \
+                       iter++;                                                 \
+               KUNIT_EXPECT_EQ((test), nr_cpu_ids - mask_weight, iter);        \
+       } while (0)
+
+#define EXPECT_FOR_EACH_CPU_WRAP_EQ(test, mask)                        \
+       do {                                                    \
+               const cpumask_t *m = (mask);                    \
+               int mask_weight = cpumask_weight(m);            \
+               int cpu, iter = 0;                              \
+               for_each_cpu_wrap(cpu, m, nr_cpu_ids / 2)       \
+                       iter++;                                 \
+               KUNIT_EXPECT_EQ((test), mask_weight, iter);     \
+       } while (0)
+
+#define EXPECT_FOR_EACH_CPU_BUILTIN_EQ(test, name)             \
+       do {                                                    \
+               int mask_weight = num_##name##_cpus();          \
+               int cpu, iter = 0;                              \
+               for_each_##name##_cpu(cpu)                      \
+                       iter++;                                 \
+               KUNIT_EXPECT_EQ((test), mask_weight, iter);     \
+       } while (0)
+
+static cpumask_t mask_empty;
+static cpumask_t mask_all;
+
+static void test_cpumask_weight(struct kunit *test)
+{
+       KUNIT_EXPECT_TRUE(test, cpumask_empty(&mask_empty));
+       KUNIT_EXPECT_TRUE(test, cpumask_full(cpu_possible_mask));
+       KUNIT_EXPECT_TRUE(test, cpumask_full(&mask_all));
+
+       KUNIT_EXPECT_EQ(test, 0, cpumask_weight(&mask_empty));
+       KUNIT_EXPECT_EQ(test, nr_cpu_ids, cpumask_weight(cpu_possible_mask));
+       KUNIT_EXPECT_EQ(test, nr_cpumask_bits, cpumask_weight(&mask_all));
+}
+
+static void test_cpumask_first(struct kunit *test)
+{
+       KUNIT_EXPECT_LE(test, nr_cpu_ids, cpumask_first(&mask_empty));
+       KUNIT_EXPECT_EQ(test, 0, cpumask_first(cpu_possible_mask));
+
+       KUNIT_EXPECT_EQ(test, 0, cpumask_first_zero(&mask_empty));
+       KUNIT_EXPECT_LE(test, nr_cpu_ids, cpumask_first_zero(cpu_possible_mask));
+}
+
+static void test_cpumask_last(struct kunit *test)
+{
+       KUNIT_EXPECT_LE(test, nr_cpumask_bits, cpumask_last(&mask_empty));
+       KUNIT_EXPECT_EQ(test, nr_cpumask_bits - 1, cpumask_last(cpu_possible_mask));
+}
+
+static void test_cpumask_next(struct kunit *test)
+{
+       KUNIT_EXPECT_EQ(test, 0, cpumask_next_zero(-1, &mask_empty));
+       KUNIT_EXPECT_LE(test, nr_cpu_ids, cpumask_next_zero(-1, cpu_possible_mask));
+
+       KUNIT_EXPECT_LE(test, nr_cpu_ids, cpumask_next(-1, &mask_empty));
+       KUNIT_EXPECT_EQ(test, 0, cpumask_next(-1, cpu_possible_mask));
+}
+
+static void test_cpumask_iterators(struct kunit *test)
+{
+       EXPECT_FOR_EACH_CPU_EQ(test, &mask_empty);
+       EXPECT_FOR_EACH_CPU_NOT_EQ(test, &mask_empty);
+       EXPECT_FOR_EACH_CPU_WRAP_EQ(test, &mask_empty);
+
+       EXPECT_FOR_EACH_CPU_EQ(test, cpu_possible_mask);
+       EXPECT_FOR_EACH_CPU_NOT_EQ(test, cpu_possible_mask);
+       EXPECT_FOR_EACH_CPU_WRAP_EQ(test, cpu_possible_mask);
+}
+
+static void test_cpumask_iterators_builtin(struct kunit *test)
+{
+       EXPECT_FOR_EACH_CPU_BUILTIN_EQ(test, possible);
+
+       /* Ensure the dynamic masks are stable while running the tests */
+       cpu_hotplug_disable();
+
+       EXPECT_FOR_EACH_CPU_BUILTIN_EQ(test, online);
+       EXPECT_FOR_EACH_CPU_BUILTIN_EQ(test, present);
+
+       cpu_hotplug_enable();
+}
+
+static int test_cpumask_init(struct kunit *test)
+{
+       cpumask_clear(&mask_empty);
+       cpumask_setall(&mask_all);
+
+       return 0;
+}
+
+static struct kunit_case test_cpumask_cases[] = {
+       KUNIT_CASE(test_cpumask_weight),
+       KUNIT_CASE(test_cpumask_first),
+       KUNIT_CASE(test_cpumask_last),
+       KUNIT_CASE(test_cpumask_next),
+       KUNIT_CASE(test_cpumask_iterators),
+       KUNIT_CASE(test_cpumask_iterators_builtin),
+       {}
+};
+
+static struct kunit_suite test_cpumask_suite = {
+       .name = "cpumask",
+       .init = test_cpumask_init,
+       .test_cases = test_cpumask_cases,
+};
+kunit_test_suite(test_cpumask_suite);
+
+MODULE_LICENSE("GPL");