Some minor sl_allocz() cleanups

diff --git a/nest/neighbor.c b/nest/neighbor.c
index d046e9814db4c65fdab466add6a61b17676e55a1..1a31fb79aae12b3d3134fa0c325594e866125609 100644 (file)
--- a/nest/neighbor.c
+++ b/nest/neighbor.c
@@ -253,9 +253,7 @@ neigh_find(struct proto *p, ip_addr a, struct iface *iface, uint flags)
   if ((scope < 0) && !(flags & NEF_STICKY))
     return NULL;
 
-  n = sl_alloc(neigh_slab);
-  memset(n, 0, sizeof(neighbor));
-
+  n = sl_allocz(neigh_slab);
   add_tail(&neigh_hash_table[h], &n->n);
   add_tail((scope >= 0) ? &iface->neighbors : &sticky_neigh_list, &n->if_n);
   n->addr = a;

diff --git a/nest/rt-attr.c b/nest/rt-attr.c
index 28d956bc6d8c62c689d8b39f644f02328a25c3b6..25e39488164bf8837f360ece267ad4490213200f 100644 (file)
--- a/nest/rt-attr.c
+++ b/nest/rt-attr.c
@@ -135,7 +135,7 @@ rt_get_source(struct proto *p, u32 id)
   if (src)
     return src;
 
-  src = sl_alloc(rte_src_slab);
+  src = sl_allocz(rte_src_slab);
   src->proto = p;
   src->private_id = id;
   src->global_id = idm_alloc(&src_ids);
@@ -366,7 +366,7 @@ nexthop_copy(struct nexthop *o)
 
   for (; o; o = o->next)
     {
-      struct nexthop *n = sl_alloc(nexthop_slab(o));
+      struct nexthop *n = sl_allocz(nexthop_slab(o));
       n->gw = o->gw;
       n->iface = o->iface;
       n->next = NULL;

diff --git a/proto/bfd/bfd.c b/proto/bfd/bfd.c
index a8814382cd55528a28e4aa190415caf6e095714a..8dfca7903af9a4f1ca4773f9349745a50d29f4b1 100644 (file)
--- a/proto/bfd/bfd.c
+++ b/proto/bfd/bfd.c
@@ -423,9 +423,7 @@ bfd_add_session(struct bfd_proto *p, ip_addr addr, ip_addr local, struct iface *
 
   struct bfd_iface *ifa = bfd_get_iface(p, local, iface);
 
-  struct bfd_session *s = sl_alloc(p->session_slab);
-  bzero(s, sizeof(struct bfd_session));
-
+  struct bfd_session *s = sl_allocz(p->session_slab);
   s->addr = addr;
   s->ifa = ifa;
   s->loc_id = bfd_get_free_id(p);

diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c
index 4710bfbad19e491e10e1e362fb606e3136bbbe0c..828bc118701fd36b759f9f2d03b1db928e3d9bd3 100644 (file)
--- a/proto/bgp/attrs.c
+++ b/proto/bgp/attrs.c
@@ -1603,6 +1603,7 @@ bgp_get_prefix(struct bgp_channel *c, net_addr *net, u32 path_id)
 
   px->buck_node.next = NULL;
   px->buck_node.prev = NULL;
+  px->next = NULL;
   px->hash = hash;
   px->path_id = path_id;
   net_copy(px->net, net);

diff --git a/proto/ospf/topology.c b/proto/ospf/topology.c
index ea7176fd21df33aa81425285f6011779b6267f0d..52c2a0cecaa2f817cdb33c838a22416e6c6839a6 100644 (file)
--- a/proto/ospf/topology.c
+++ b/proto/ospf/topology.c
@@ -2108,9 +2108,7 @@ ospf_hash_get(struct top_graph *f, u32 domain, u32 lsa, u32 rtr, u32 type)
   if (e)
     return e;
 
-  e = sl_alloc(f->hash_slab);
-  bzero(e, sizeof(struct top_hash_entry));
-
+  e = sl_allocz(f->hash_slab);
   e->color = OUTSPF;
   e->dist = LSINFINITY;
   e->lsa.type_raw = type;