Revert "Never expand $ORIGIN in privileged programs"

This reverts commit 2232b90f0bd3a41b4d63cac98a5b60abbfaccd46.

diff --git a/ChangeLog b/ChangeLog
index 514254a1b21e4b8dc8e49509808780199b9d2d03..24ef9e1a95c0f271c0c060bf625c9621d3a3cdb5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -13,12 +13,6 @@
        (do_preload): Use __RTLD_SECURE instead of is_preloaded.
        (dlmopen_doit): Add __RTLD_SECURE to mode bits.
 
-2010-10-18  Andreas Schwab  <schwab@redhat.com>
-
-       * elf/dl-load.c (is_dst): Remove last parameter.
-       (_dl_dst_count): Ignore $ORIGIN in privileged programs.
-       (_dl_dst_substitute): Likewise.
-
 2010-10-06  Ulrich Drepper  <drepper@gmail.com>
 
        * string/bug-strstr1.c: New file.

diff --git a/elf/dl-load.c b/elf/dl-load.c
index efdf59bb565352f5b283a77638b3830472afd3c8..a92816a296c1627d1651fc6536d63fd9d8ecd660 100644 (file)
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -169,7 +169,8 @@ local_strdup (const char *s)
 
 
 static size_t
-is_dst (const char *start, const char *name, const char *str, int is_path)
+is_dst (const char *start, const char *name, const char *str,
+       int is_path, int secure)
 {
   size_t len;
   bool is_curly = false;
@@ -198,6 +199,11 @@ is_dst (const char *start, const char *name, const char *str, int is_path)
           && (!is_path || name[len] != ':'))
     return 0;
 
+  if (__builtin_expect (secure, 0)
+      && ((name[len] != '\0' && (!is_path || name[len] != ':'))
+         || (name != start + 1 && (!is_path || name[-2] != ':'))))
+    return 0;
+
   return len;
 }
 
@@ -212,12 +218,13 @@ _dl_dst_count (const char *name, int is_path)
     {
       size_t len;
 
-      /* $ORIGIN is not expanded for SUID/GUID programs.  */
+      /* $ORIGIN is not expanded for SUID/GUID programs (except if it
+        is $ORIGIN alone) and it must always appear first in path.  */
       ++name;
-      if (((len = is_dst (start, name, "ORIGIN", is_path)) != 0
-          && !INTUSE(__libc_enable_secure))
-         || (len = is_dst (start, name, "PLATFORM", is_path)) != 0
-         || (len = is_dst (start, name, "LIB", is_path)) != 0)
+      if ((len = is_dst (start, name, "ORIGIN", is_path,
+                        INTUSE(__libc_enable_secure))) != 0
+         || (len = is_dst (start, name, "PLATFORM", is_path, 0)) != 0
+         || (len = is_dst (start, name, "LIB", is_path, 0)) != 0)
        ++cnt;
 
       name = strchr (name + len, '$');
@@ -249,12 +256,9 @@ _dl_dst_substitute (struct link_map *l, const char *name, char *result,
          size_t len;
 
          ++name;
-         if ((len = is_dst (start, name, "ORIGIN", is_path)) != 0)
+         if ((len = is_dst (start, name, "ORIGIN", is_path,
+                            INTUSE(__libc_enable_secure))) != 0)
            {
-             /* Ignore this path element in SUID/SGID programs.  */
-             if (INTUSE(__libc_enable_secure))
-               repl = (const char *) -1;
-             else
 #ifndef SHARED
              if (l == NULL)
                repl = _dl_get_origin ();
@@ -262,9 +266,9 @@ _dl_dst_substitute (struct link_map *l, const char *name, char *result,
 #endif
                repl = l->l_origin;
            }
-         else if ((len = is_dst (start, name, "PLATFORM", is_path)) != 0)
+         else if ((len = is_dst (start, name, "PLATFORM", is_path, 0)) != 0)
            repl = GLRO(dl_platform);
-         else if ((len = is_dst (start, name, "LIB", is_path)) != 0)
+         else if ((len = is_dst (start, name, "LIB", is_path, 0)) != 0)
            repl = DL_DST_LIB;
 
          if (repl != NULL && repl != (const char *) -1)