]> git.ipfire.org Git - people/ms/linux.git/commitdiff
selftests: KVM: Add exponent check for boolean stats
authorOliver Upton <oupton@google.com>
Tue, 19 Jul 2022 14:31:34 +0000 (14:31 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 1 Aug 2022 12:01:23 +0000 (08:01 -0400)
The only sensible exponent for a boolean stat is 0. Add a test assertion
requiring all boolean statistics to have an exponent of 0.

Signed-off-by: Oliver Upton <oupton@google.com>
Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
Message-Id: <20220719143134.3246798-4-oliver.upton@linux.dev>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tools/testing/selftests/kvm/kvm_binary_stats_test.c

index 3237c7c94bf014fef472887981ef2a7efdc0c2e3..0b45ac59338789d928ac38138d30e470466878a7 100644 (file)
@@ -96,6 +96,7 @@ static void stats_test(int stats_fd)
                 * Exponent for unit seconds should be less than or equal to 0
                 * Exponent for unit clock cycles should be greater than or
                 * equal to 0
+                * Exponent for unit boolean should be 0
                 */
                switch (pdesc->flags & KVM_STATS_UNIT_MASK) {
                case KVM_STATS_UNIT_NONE:
@@ -110,6 +111,11 @@ static void stats_test(int stats_fd)
                                    "Unsupported KVM stats (%s) exponent: %i",
                                    pdesc->name, pdesc->exponent);
                        break;
+               case KVM_STATS_UNIT_BOOLEAN:
+                       TEST_ASSERT(pdesc->exponent == 0,
+                                   "Unsupported KVM stats (%s) exponent: %d",
+                                   pdesc->name, pdesc->exponent);
+                       break;
                }
 
                /* Check size field, which should not be zero */