nologin: don't call fstat() after failed open() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/login-utils/nologin.c b/login-utils/nologin.c
index 2e897cc722764f52447db4500bd31ab9d3d8e5b4..e950d2a3f296f312529023efc4dc9d620231fbe2 100644 (file)
--- a/login-utils/nologin.c
+++ b/login-utils/nologin.c
@@ -38,7 +38,7 @@ static void __attribute__((__noreturn__)) usage(FILE *out)
 
 int main(int argc, char *argv[])
 {
-       int c, fd;
+       int c, fd = -1;
        struct stat st;
        static const struct option longopts[] = {
                { "help",    0, NULL, 'h' },
@@ -64,16 +64,26 @@ int main(int argc, char *argv[])
        }
 
        fd = open(_PATH_NOLOGIN_TXT, O_RDONLY);
+       if (fd < 0)
+               goto dflt;
+
        c = fstat(fd, &st);
-       if (fd >= 0 && !c && S_ISREG(st.st_mode)) {
+       if (c < 0 || !S_ISREG(st.st_mode))
+               goto dflt;
+       else {
                char buf[BUFSIZ];
                ssize_t rd;
 
                while ((rd = read(fd, buf, sizeof(buf))) > 0)
                        ignore_result( write(STDOUT_FILENO, buf, rd) );
+
                close(fd);
-       } else
-               fprintf(stdout, _("This account is currently not available.\n"));
+               return EXIT_FAILURE;
+       }
 
+dflt:
+       if (fd >= 0)
+               close(fd);
+       fprintf(stdout, _("This account is currently not available.\n"));
        return EXIT_FAILURE;
 }