]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
tree-wide: add missing '=' in short comments for function argument 38263/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Sat, 19 Jul 2025 00:47:33 +0000 (09:47 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 21 Jul 2025 18:05:54 +0000 (03:05 +0900)
16 files changed:
src/analyze/analyze-unit-shell.c
src/boot/pe.c
src/boot/secure-boot.c
src/core/main.c
src/cryptenroll/cryptenroll-password.c
src/firstboot/firstboot.c
src/home/user-record-password-quality.c
src/journal-remote/journal-upload.c
src/journal/journald-config.c
src/journal/journald-manager.c
src/libsystemd/sd-event/sd-event.c
src/login/logind-session.c
src/login/pam_systemd.c
src/shared/password-quality-util-passwdqc.c
src/sysext/sysext.c
src/udev/udev-rules.c

index 43eb65932eecd8daff88443082fed087575e4f36..607c6af6763381e925a34fc33d303660ff799726 100644 (file)
@@ -82,7 +82,7 @@ int verb_unit_shell(int argc, char *argv[], void *userdata) {
                         "(unit-shell-ns)",
                         "(unit-shell)",
                         /* except_fds= */ NULL,
-                        /* n_except_fds */ 0,
+                        /* n_except_fds= */ 0,
                         FORK_RESET_SIGNALS|FORK_DEATHSIG_SIGKILL,
                         pidns_fd,
                         mntns_fd,
index beab0eb670a0180932cbddd562af888ba7bc347c..8f3846304177726f95f578426622032e334b06a7 100644 (file)
@@ -366,8 +366,8 @@ static void pe_locate_sections(
                                   n_section_table,
                                   section_names,
                                   validate_base,
-                                  /* device_base */ NULL,
-                                  /* device */ NULL,
+                                  /* device_table = */ NULL,
+                                  /* device */ NULL,
                                   sections);
 
         /* It doesn't make sense not to provide validate_base here */
@@ -386,8 +386,8 @@ static void pe_locate_sections(
                                 n_section_table,
                                 hwid_section_names,
                                 validate_base,
-                                /* device_table */ NULL,
-                                /* device */ NULL,
+                                /* device_table */ NULL,
+                                /* device */ NULL,
                                 hwids_section);
 
                 if (PE_SECTION_VECTOR_IS_SET(hwids_section)) {
index 3a3a7540091089bb0dff98ce2ca500e1bbcebba7..883e8487e479d77b64dee8c3187f6317b4a5b7e0 100644 (file)
@@ -161,7 +161,7 @@ EFI_STATUS secure_boot_enroll_at(EFI_FILE *root_dir, const char16_t *path, bool
         }
 
         if (need_custom_mode && !custom_mode_enabled()) {
-                err = set_custom_mode(/* enable */ true);
+                err = set_custom_mode(/* enable */ true);
                 if (err != EFI_SUCCESS) {
                         log_error_status(err, "Failed to enable custom mode: %m");
                         goto out_deallocate;
index 6c44b4e00fd771ca90409a7b2e0601690a2fc5ac..4fc870d6c0eefb5282c2754b4ef48b8651b14e39 100644 (file)
@@ -1421,7 +1421,7 @@ static int os_release_status(void) {
                 }
         }
 
-        if (support_end && os_release_support_ended(support_end, /* quiet */ false, NULL) > 0)
+        if (support_end && os_release_support_ended(support_end, /* quiet = */ false, /* ret_eol = */ NULL) > 0)
                 /* pretty_name may include the version already, so we'll print the version only if we
                  * have it and we're not using pretty_name. */
                 status_printf(ANSI_HIGHLIGHT_RED "  !!  " ANSI_NORMAL, 0,
index 8c7e38b82cc0bbb933860b1ebb86b881555a39e8..7761aba21f8d0741b8aab880a596b95cf10bfcda 100644 (file)
@@ -188,7 +188,7 @@ int enroll_password(
                 }
         }
 
-        r = check_password_quality(new_password, /* old */ NULL, /* user */ NULL, &error);
+        r = check_password_quality(new_password, /* old = */ NULL, /* user = */ NULL, &error);
         if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
                 log_warning("Password quality check is not supported, proceeding anyway.");
         else if (r < 0)
index 4462086e782036d536d6fadf6858e76e0e0900ce..5ed6d3a9d2d64ac9fa04c3095a8926f2504d5e84 100644 (file)
@@ -824,7 +824,7 @@ static int prompt_root_password(int rfd) {
                         break;
                 }
 
-                r = check_password_quality(*a, /* old */ NULL, "root", &error);
+                r = check_password_quality(*a, /* old */ NULL, "root", &error);
                 if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
                         log_warning("Password quality check is not supported, proceeding anyway.");
                 else if (r < 0)
index 844c42c52b2492460f5b625d6c44bdbd9fc3884c..b23f717c0e1053e5b2a3b7ad24b2ee93a928b48e 100644 (file)
@@ -63,7 +63,7 @@ int user_record_check_password_quality(
                         continue;
 
                 /* If there are no old passwords, let's call check_password_quality() without any. */
-                r = check_password_quality(*pp, /* old */ NULL, hr->user_name, &auxerror);
+                r = check_password_quality(*pp, /* old */ NULL, hr->user_name, &auxerror);
                 if (r <= 0)
                         goto error;
         }
index 46a58e228b43f7ce975238dd27990890a746b689..d669d27274f6abe52b03f5960a6d7097f5de572c 100644 (file)
@@ -682,7 +682,7 @@ static int parse_config(void) {
                 { "Upload",  "TrustedCertificateFile", config_parse_path_or_ignore, 0,                        &arg_trust                },
                 { "Upload",  "NetworkTimeoutSec",      config_parse_sec,            0,                        &arg_network_timeout_usec },
                 { "Upload",  "Header",                 config_parse_header,         0,                        &arg_headers              },
-                { "Upload",  "Compression",            config_parse_compression,    /* with_level */ true,    &arg_compression          },
+                { "Upload",  "Compression",            config_parse_compression,    /* with_level = */ true,  &arg_compression          },
                 { "Upload",  "ForceCompression",       config_parse_bool,           0,                        &arg_force_compression    },
                 {}
         };
index 4a514cd573f68aec8f832d6146df885fa03871bc..dd2e29e2962cb66d76a9837f8fffa40e25be858b 100644 (file)
@@ -377,7 +377,7 @@ int manager_dispatch_reload_signal(sd_event_source *s, const struct signalfd_sig
         manager_reopen_journals(m, &old);
 
         log_info("Config file reloaded.");
-        (void) sd_notify(/* unset_environment */ false, NOTIFY_READY_MESSAGE);
+        (void) sd_notify(/* unset_environment */ false, NOTIFY_READY_MESSAGE);
 
         return 0;
 }
index bd2a05489df399163206566b533dde83818b3177..743aea3868a39f201b7b6dbe9189ad0ad3351701 100644 (file)
@@ -1467,7 +1467,7 @@ int manager_relinquish_var(Manager *m) {
 
         log_debug("Relinquishing %s...", m->system_storage.path);
 
-        (void) manager_system_journal_open(m, /* flush_requested */ false, /* relinquish_requested=*/ true);
+        (void) manager_system_journal_open(m, /* flush_requested = */ false, /* relinquish_requested = */ true);
 
         m->system_journal = journal_file_offline_close(m->system_journal);
         ordered_hashmap_clear(m->user_journals);
@@ -2290,7 +2290,7 @@ void manager_reopen_journals(Manager *m, const JournalConfig *old) {
         (void) manager_system_journal_open(m, /* flush_requested = */ false, /* relinquish_requested = */ false);
 
         /* To make the storage related settings applied, vacuum the storage. */
-        manager_vacuum(m, /* verbose */ false);
+        manager_vacuum(m, /* verbose */ false);
 }
 
 int manager_new(Manager **ret) {
index 869747e929d6641ad33e66fbd034b24c31f5ded7..6cb496c5418c81d0516d40edf1215a6f6c9f9423 100644 (file)
@@ -3631,7 +3631,7 @@ static int process_timer(
                          * again. */
                         assert(s->ratelimited);
 
-                        r = event_source_leave_ratelimit(s, /* run_callback */ true);
+                        r = event_source_leave_ratelimit(s, /* run_callback */ true);
                         if (r < 0)
                                 return r;
                         else if (r == 1)
@@ -5116,7 +5116,7 @@ _public_ int sd_event_source_set_ratelimit(sd_event_source *s, uint64_t interval
 
         /* When ratelimiting is configured we'll always reset the rate limit state first and start fresh,
          * non-ratelimited. */
-        r = event_source_leave_ratelimit(s, /* run_callback */ false);
+        r = event_source_leave_ratelimit(s, /* run_callback */ false);
         if (r < 0)
                 return r;
 
@@ -5179,7 +5179,7 @@ _public_ int sd_event_source_leave_ratelimit(sd_event_source *s) {
         if (!s->ratelimited)
                 return 0;
 
-        r = event_source_leave_ratelimit(s, /* run_callback */ false);
+        r = event_source_leave_ratelimit(s, /* run_callback */ false);
         if (r < 0)
                 return r;
 
index db835d56d7dd72c2dffa27fd63223c97d4c90715..071bdb544172f6f35df5bfe264182a3de2a37455 100644 (file)
@@ -734,7 +734,7 @@ static int session_dispatch_stop_on_idle(sd_event_source *source, uint64_t t, vo
         if (idle) {
                 log_info("Session \"%s\" of user \"%s\" is idle, stopping.", s->id, s->user->user_record->user_name);
 
-                return session_stop(s, /* force */ true);
+                return session_stop(s, /* force */ true);
         }
 
         r = sd_event_source_set_time(
index a2f0a7373a813df8197ae5cfe82f38ba19d29649..1318211105b1715a9bf2b2615f0b51f3478e508e 100644 (file)
@@ -1812,7 +1812,7 @@ _public_ PAM_EXTERN int pam_sm_close_session(
                        /* desktop= */ NULL,
                        /* area= */ NULL,
                        &debug,
-                       /* default_capability_bounding_set */ NULL,
+                       /* default_capability_bounding_set= */ NULL,
                        /* default_capability_ambient_set= */ NULL) < 0)
                 return PAM_SESSION_ERR;
 
index 004203d17e345f3df40ef0bc83c223c2d8530284..f4ecc6ce66d7ab612b803bf4ec13814b3e01d32b 100644 (file)
@@ -127,7 +127,7 @@ int check_password_quality(
 
                 check_reason = sym_passwdqc_check(&params->qc, password, old, &pw);
         } else
-                check_reason = sym_passwdqc_check(&params->qc, password, old, /* pw */ NULL);
+                check_reason = sym_passwdqc_check(&params->qc, password, old, /* pw */ NULL);
 
         if (check_reason) {
                 if (ret_error) {
index 0d17459d6ff31d1ec54d65e19a1c370b861fbe99..005ea6d977dac5fc56739505d74b22ec9a2f8c33 100644 (file)
@@ -254,7 +254,7 @@ static int need_reload(
                         const char *extension_reload_manager = NULL;
                         int b;
 
-                        r = load_extension_release_pairs(arg_root, image_class, *extension, /* relax_extension_release_check */ true, &extension_release);
+                        r = load_extension_release_pairs(arg_root, image_class, *extension, /* relax_extension_release_check */ true, &extension_release);
                         if (r < 0) {
                                 log_debug_errno(r, "Failed to parse extension-release metadata of %s, ignoring: %m", *extension);
                                 continue;
index b7fc0a675c57404a98c9fd635e86c7cb4c689810..1f99b54a0d74fe6cc1f584c5c1988a6598371ee5 100644 (file)
@@ -954,7 +954,7 @@ static int parse_token(
                 if (is_case_insensitive)
                         return log_line_invalid_prefix(rule_line, key);
 
-                r = rule_line_add_token(rule_line, TK_M_PROGRAM, op, value, NULL, /* is_case_insensitive */ false, token_str);
+                r = rule_line_add_token(rule_line, TK_M_PROGRAM, op, value, NULL, /* is_case_insensitive */ false, token_str);
         } else if (streq(key, "IMPORT")) {
                 if (isempty(attr))
                         return log_line_invalid_attr(rule_line, key);