]> git.ipfire.org Git - people/ms/linux.git/commitdiff
scsi: mpt3sas: Fix return value check of dma_get_required_mask()
authorSreekanth Reddy <sreekanth.reddy@broadcom.com>
Tue, 13 Sep 2022 12:05:38 +0000 (17:35 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 16 Sep 2022 02:24:28 +0000 (22:24 -0400)
Fix the incorrect return value check of dma_get_required_mask().  Due to
this incorrect check, the driver was always setting the DMA mask to 63 bit.

Link: https://lore.kernel.org/r/20220913120538.18759-2-sreekanth.reddy@broadcom.com
Fixes: ba27c5cf286d ("scsi: mpt3sas: Don't change the DMA coherent mask after allocations")
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c

index 565339a0811dbe92b3f341f0f05379d0e6187d67..331e896d8225df01040460c377876bf583894356 100644 (file)
@@ -2993,7 +2993,7 @@ _base_config_dma_addressing(struct MPT3SAS_ADAPTER *ioc, struct pci_dev *pdev)
 
        if (ioc->is_mcpu_endpoint ||
            sizeof(dma_addr_t) == 4 || ioc->use_32bit_dma ||
-           dma_get_required_mask(&pdev->dev) <= 32)
+           dma_get_required_mask(&pdev->dev) <= DMA_BIT_MASK(32))
                ioc->dma_mask = 32;
        /* Set 63 bit DMA mask for all SAS3 and SAS35 controllers */
        else if (ioc->hba_mpi_version_belonged > MPI2_VERSION)