]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-event: don't mistake USEC_INFINITY passed in for overflow
authorLennart Poettering <lennart@poettering.net>
Fri, 6 Jan 2023 10:27:17 +0000 (11:27 +0100)
committerLennart Poettering <lennart@poettering.net>
Fri, 6 Jan 2023 10:29:09 +0000 (11:29 +0100)
Let's pass USEC_INFINITY from sd_event_source_set_time_relative() to
sd_event_source_set_time() instead of raising EOVERFLOW.

We should raise EOVERFLOW only if your addition fails, but not if the
input already is USEC_INFINITY, since it's an entirely valid operation
to have an infinite time-out, and we should support that.

src/libsystemd/sd-event/sd-event.c

index 6c15bc3ba7ded91bd9021807ddbfa741ab930c52..cefe2a36b4fa673ea1bb16088f1d650d33bca114 100644 (file)
@@ -2726,6 +2726,9 @@ _public_ int sd_event_source_set_time_relative(sd_event_source *s, uint64_t usec
         assert_return(s, -EINVAL);
         assert_return(EVENT_SOURCE_IS_TIME(s->type), -EDOM);
 
+        if (usec == USEC_INFINITY)
+                return sd_event_source_set_time(s, USEC_INFINITY);
+
         r = sd_event_now(s->event, event_source_type_to_clock(s->type), &t);
         if (r < 0)
                 return r;