]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
coverity 1414446 out-of-bounds access: allocate \0 terminator byte to be safe
authorPauli <paul.dale@oracle.com>
Thu, 8 Oct 2020 23:32:04 +0000 (09:32 +1000)
committerPauli <paul.dale@oracle.com>
Mon, 12 Oct 2020 00:27:16 +0000 (10:27 +1000)
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/13091)

test/v3nametest.c

index 9b81988ddd4441b79a874b7dca5f8e2781db9abf..df12c15f09574aaa48843b2373267c0e395a58db 100644 (file)
@@ -289,10 +289,10 @@ static int run_cert(X509 *crt, const char *nameincert,
     for (; *pname != NULL; ++pname) {
         int samename = strcasecmp(nameincert, *pname) == 0;
         size_t namelen = strlen(*pname);
-        char *name = OPENSSL_malloc(namelen);
+        char *name = OPENSSL_malloc(namelen + 1);
         int match, ret;
 
-        memcpy(name, *pname, namelen);
+        memcpy(name, *pname, namelen + 1);
 
         match = -1;
         if (!TEST_int_ge(ret = X509_check_host(crt, name, namelen, 0, NULL),