From: Nils Larsch <nils@openssl.org>
Date: Wed, 4 Apr 2007 19:41:20 +0000 (+0000)
Subject: check return value of ASN1_item_i2d(), Coverity ID 55
X-Git-Tag: OpenSSL_0_9_8k^2~910
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=907e99623c7f9aefa7c89a33fd7187f182adc09a;p=thirdparty%2Fopenssl.git

check return value of ASN1_item_i2d(), Coverity ID 55
---

diff --git a/crypto/pkcs7/pk7_doit.c b/crypto/pkcs7/pk7_doit.c
index 37e35e1677..7eb053a656 100644
--- a/crypto/pkcs7/pk7_doit.c
+++ b/crypto/pkcs7/pk7_doit.c
@@ -1056,6 +1056,12 @@ for (ii=0; ii<md_len; ii++) printf("%02X",md_dat[ii]); printf(" calc\n");
 
 		alen = ASN1_item_i2d((ASN1_VALUE *)sk, &abuf,
 						ASN1_ITEM_rptr(PKCS7_ATTR_VERIFY));
+		if (alen <= 0) 
+			{
+			PKCS7err(PKCS7_F_PKCS7_SIGNATUREVERIFY,ERR_R_ASN1_LIB);
+			ret = -1;
+			goto err;
+			}
 		EVP_VerifyUpdate(&mdc_tmp, abuf, alen);
 
 		OPENSSL_free(abuf);