]>
git.ipfire.org Git - thirdparty/systemd.git/log
Yu Watanabe [Wed, 12 Apr 2023 07:43:39 +0000 (16:43 +0900)]
Merge pull request #27033 from dtardon/array-cleanup
Use CLEANUP_ARRAY more
Frantisek Sumsal [Tue, 11 Apr 2023 15:23:23 +0000 (17:23 +0200)]
test: drop binary stripping stuff
Stripping the binaries in the test images makes potential stack straces
quite useless, so let's drop the stripping stuff to make test fails a bit
more developer friendly.
Related: https://github.com/systemd/systemd-centos-ci/pull/616
Daan De Meyer [Tue, 11 Apr 2023 20:30:09 +0000 (22:30 +0200)]
Merge pull request #27214 from DaanDeMeyer/firstboot
firstboot: Use root directory file descriptor for everything
Tanishka [Tue, 4 Apr 2023 13:00:31 +0000 (18:30 +0530)]
Modified to use STRV_MAKE() in strv_env_name_is_valid() function listed in env-util.c
Zbigniew Jędrzejewski-Szmek [Tue, 11 Apr 2023 18:44:48 +0000 (20:44 +0200)]
Merge pull request #27209 from jamacku/patch-1
Don't run release workflow on `systemd-security` & drop checkout action
Mike Yuan [Tue, 4 Apr 2023 14:12:32 +0000 (22:12 +0800)]
systemctl: suppress error for try-* if unit is masked
Closes #16521
Jan Janssen [Mon, 10 Apr 2023 09:43:56 +0000 (11:43 +0200)]
boot: Fix alignment of long long inside structs on x86
On x86 EFI follows the windows ABI, which expects 8-byte aligned long
long. The x86 sysv ELF ABI expects them to be 8-byte aligned when used
alone, but 4-byte aligned when they appear inside of structs:
struct S {
int i;
long long ll;
};
// _Static_assert(sizeof(struct S) == 12, "x86 sysv ABI");
_Static_assert(sizeof(struct S) == 16, "EFI/MS ABI");
To get the behavior we need when building with sysv ELF ABI we need to
pass '-malign-double' to the compiler as done by EDK2.
This in turn will make ubsan unhappy as the stack may not be properly
aligned on entry, so we have to tell the compiler explicitly to re-align
the stack on entry to efi_main.
This fixes loading EFI drivers on x86 that were previously always
rejected as the EFI_LOADED_IMAGE_PROTOCOL had a wrong memory layout.
See also: https://github.com/rhboot/shim/pull/516
Jan Macku [Tue, 11 Apr 2023 07:33:46 +0000 (09:33 +0200)]
ci: drop checkout from release workflow
It's not required as per comment - https://github.com/systemd/systemd/pull/27110#issuecomment-
1499653913
Jan Macku [Tue, 11 Apr 2023 07:30:15 +0000 (09:30 +0200)]
ci: don't run release wf on `systemd-security`
David Tardon [Tue, 28 Mar 2023 11:44:16 +0000 (13:44 +0200)]
portabled-image-bus: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 11:39:04 +0000 (13:39 +0200)]
portabled-image-bus: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 11:38:18 +0000 (13:38 +0200)]
portabled-image-bus: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 11:33:48 +0000 (13:33 +0200)]
portabled-bus: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 11:30:26 +0000 (13:30 +0200)]
sd-bus: use _cleanup_
David Tardon [Tue, 28 Mar 2023 11:27:02 +0000 (13:27 +0200)]
sd-bus: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 09:28:13 +0000 (11:28 +0200)]
execute: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 09:22:35 +0000 (11:22 +0200)]
execute: use more automatic cleanup
Bill Peterson [Tue, 11 Apr 2023 14:11:16 +0000 (09:11 -0500)]
hwdb: add matrix for Asus BR1100F (#27197)
David Tardon [Tue, 28 Mar 2023 09:17:09 +0000 (11:17 +0200)]
execute: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 09:05:06 +0000 (11:05 +0200)]
systemctl-set-default: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 09:03:13 +0000 (11:03 +0200)]
systemctl-preset-all: shorten code a tiny bit
David Tardon [Tue, 28 Mar 2023 09:02:38 +0000 (11:02 +0200)]
systemctl-preset-all: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 09:00:23 +0000 (11:00 +0200)]
systemctl-enable: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 08:57:02 +0000 (10:57 +0200)]
systemctl-add-dependency: shorten code a tiny bit
David Tardon [Tue, 28 Mar 2023 08:51:29 +0000 (10:51 +0200)]
systemctl-add-dependency: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 08:46:20 +0000 (10:46 +0200)]
portablectl: use CLEANUP_ARRAY
David Tardon [Thu, 30 Mar 2023 10:49:15 +0000 (12:49 +0200)]
machinectl: do not repeat the same comparison
David Tardon [Thu, 30 Mar 2023 10:38:24 +0000 (12:38 +0200)]
machinectl: drop unneeded else
David Tardon [Tue, 28 Mar 2023 08:44:46 +0000 (10:44 +0200)]
machinectl: use CLEANUP_ARRAY
David Tardon [Tue, 28 Mar 2023 08:39:33 +0000 (10:39 +0200)]
dbus-manager: use CLEANUP_ARRAY
Daan De Meyer [Tue, 11 Apr 2023 13:22:08 +0000 (15:22 +0200)]
firstboot: Use root directory file descriptor for everything
There were a few remaining cases where we used arg_root instead of
the root directory file descriptor. Let's port those over to use the
root directory file descriptor as well.
Daan De Meyer [Tue, 11 Apr 2023 13:21:51 +0000 (15:21 +0200)]
user-util: Add default_root_shell_at()
David Tardon [Tue, 28 Mar 2023 08:37:33 +0000 (10:37 +0200)]
dbus-manager: use CLEANUP_ARRAY
Daan De Meyer [Tue, 11 Apr 2023 12:54:56 +0000 (14:54 +0200)]
Merge pull request #27186 from yuwata/os-release
os-util: several cleanups and introduce _at() variants of os-release parsers
Zbigniew Jędrzejewski-Szmek [Tue, 11 Apr 2023 12:43:50 +0000 (14:43 +0200)]
Merge pull request #27169 from yuwata/udev-rule-refuse-unsafe-path
sd-device,udev: refuse unsafe path in SYMLINK= and TAG=
Yu Watanabe [Tue, 11 Apr 2023 10:20:49 +0000 (19:20 +0900)]
hwdb: fix ambiguous glob pattern for Lenovo machines
Fixes #27195.
Follow-up for
a5c0ad9a9a2964079a19a1db42f79570a3582bee .
Yu Watanabe [Sat, 8 Apr 2023 09:48:57 +0000 (18:48 +0900)]
os-util: introduce several _at() variants of os-release parsers
Yu Watanabe [Sat, 8 Apr 2023 13:33:40 +0000 (22:33 +0900)]
os-util: make $SYSTEMD_OS_RELEASE prefixed with the root directory
To make it consistent with other env vars, e.g. $SYSTEMD_ESP_PATH or
$SYSTEMD_XBOOTLDR_PATH.
This is useful when the root is specified by a file descriptor, instead
of a path.
Yu Watanabe [Sat, 8 Apr 2023 09:16:04 +0000 (18:16 +0900)]
os-util: merge parse_{extension,os}_release()
Yu Watanabe [Sat, 8 Apr 2023 13:10:25 +0000 (22:10 +0900)]
os-util: invert order of arguments in extension release parser
For consistency with other functions.
Unfortunately, va_start() requires that the previous argument is a
pointer, hence the order of the arguments in the internal function
cannot be changed.
Yu Watanabe [Sat, 8 Apr 2023 16:38:34 +0000 (01:38 +0900)]
os-util: shorten temporal variable names
No functional change, just refactoring.
Yu Watanabe [Sat, 8 Apr 2023 16:37:16 +0000 (01:37 +0900)]
os-util: log one more error cause
Yu Watanabe [Sat, 8 Apr 2023 16:31:29 +0000 (01:31 +0900)]
os-util: do not use 'r' for storing loop status
The variable 'r' is usually used for storing return value of functional
call. Let's introduce another boolean to store the current loop status.
No functional change, just refactoring.
Yu Watanabe [Sat, 8 Apr 2023 16:16:26 +0000 (01:16 +0900)]
os-util: return earlier when unsupported image class is specified
Yu Watanabe [Sat, 8 Apr 2023 16:09:09 +0000 (01:09 +0900)]
os-util: return earlier when extension release file is found
No functional change, just refactoring.
Yu Watanabe [Sat, 8 Apr 2023 16:02:13 +0000 (01:02 +0900)]
os-util: split-out open_os_release() from open_extension_release()
The logics of opening os-release and extension-release are completely
different.
No functional change, just refactoring.
Yu Watanabe [Sat, 8 Apr 2023 16:11:52 +0000 (01:11 +0900)]
os-util: fix fd leak on failure
Yu Watanabe [Sat, 8 Apr 2023 09:00:31 +0000 (18:00 +0900)]
os-util: make open_extension_release() return O_PATH fd
Yu Watanabe [Sat, 8 Apr 2023 08:15:09 +0000 (17:15 +0900)]
os-util: drop fopen_extension_release()
Yu Watanabe [Sat, 8 Apr 2023 06:15:25 +0000 (15:15 +0900)]
compress: replace compress_blob() with compress_blob_explicit()
And make compress_xyz() return 0 on success, as we know which compression
algorithm is used when calling compress_blob().
Follow-up for
2360352ef02548723ac0c8eaf5ff6905eb9eeca5 .
Daan De Meyer [Tue, 11 Apr 2023 07:12:21 +0000 (09:12 +0200)]
Merge pull request #27206 from yuwata/udev-rename
udev: rename arguments and options, update comments
Yu Watanabe [Mon, 10 Apr 2023 19:50:32 +0000 (04:50 +0900)]
chase: drop redundant call of delete_trailing_chars()
In that branch, 'root' is a non-root and absolute path.
Hence, delete_trailing_chars() does not make the path empty.
And, if the path contains redundant slashes at the end, that will be
dropped by path_simplify().
Yu Watanabe [Tue, 11 Apr 2023 05:42:27 +0000 (14:42 +0900)]
Merge pull request #27207 from masatake/busctl--help-msg
busctl: add --xml-interface to the help message
Yu Watanabe [Tue, 11 Apr 2023 03:37:37 +0000 (12:37 +0900)]
Merge pull request #27201 from yuwata/o-path-support
Support O_PATH more
Colin Walters [Mon, 10 Apr 2023 20:22:25 +0000 (16:22 -0400)]
tree-wide: A few more uses of "unmet" for conditions
This is a followup to
413e8650b71d4404a7453403797f93d73d88c466
> tree-wide: Use "unmet" for condition checks, not "failed"
Since I noticed when running `systemctl status` on a recent
systemd still seeing
`Condition: start condition failed`
To recap the original rationale here for "unmet" is that it's
normal for some units to be conditional, so the term "failure"
here is too strong.
Yu Watanabe [Tue, 11 Apr 2023 03:36:13 +0000 (12:36 +0900)]
Merge pull request #27199 from yuwata/find-esp
path-util: introduce path_prefix_root_cwd(), and use it in find_esp() and friends
Yu Watanabe [Tue, 11 Apr 2023 03:35:34 +0000 (12:35 +0900)]
Merge pull request #27202 from yuwata/os-release-tiny-cleanups
os-util: tiny cleanups
Yu Watanabe [Sat, 8 Apr 2023 08:48:04 +0000 (17:48 +0900)]
env-file: introduce parse_env_file_fdv()
Masatake YAMATO [Tue, 11 Apr 2023 02:45:44 +0000 (11:45 +0900)]
shell-completion: add --xml-interface option of busctl to the rules
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Masatake YAMATO [Tue, 11 Apr 2023 02:29:30 +0000 (11:29 +0900)]
busctl: add --xml-interface to the help message
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Yu Watanabe [Mon, 10 Apr 2023 19:57:34 +0000 (04:57 +0900)]
find-esp: use path_prefix_root_cwd()
Unlikely, but even if find_esp() or friends called with unnormalized or
relative 'root', let's make the result path normalized and absolute.
Note, before
63105f33edad423691e2d53bf7071f99c83799ba , these functions
returned an absolute and normalized path. But the commit made the result
path simply concatenated with root.
Follow-up for
63105f33edad423691e2d53bf7071f99c83799ba .
Yu Watanabe [Mon, 10 Apr 2023 19:09:55 +0000 (04:09 +0900)]
path-util: introduce path_prefix_root_cwd()
Yu Watanabe [Mon, 10 Apr 2023 21:05:35 +0000 (06:05 +0900)]
test: update description
Yu Watanabe [Mon, 10 Apr 2023 21:01:13 +0000 (06:01 +0900)]
udev/scsi_id: rename positional arguments
Yu Watanabe [Mon, 10 Apr 2023 20:53:58 +0000 (05:53 +0900)]
device-nodes: rename argument
Yu Watanabe [Sat, 8 Apr 2023 08:56:38 +0000 (17:56 +0900)]
os-util: drop redundant declaration of load_os_release_pairs()
Yu Watanabe [Sat, 8 Apr 2023 07:15:03 +0000 (16:15 +0900)]
os-util: use _IMAGE_CLASS_INVALID
When extension is not specified, image class is not necessary to be
specified. Let's use _IMAGE_CLASS_INVALID as an indicator that no
extension is specified.
Yu Watanabe [Sat, 8 Apr 2023 12:27:48 +0000 (21:27 +0900)]
os-util: move declaration of string table lookup for image class
Yu Watanabe [Sat, 8 Apr 2023 20:55:17 +0000 (05:55 +0900)]
portable: always reopen fd of release file
To make it support the case that the fd is O_PATH.
Yu Watanabe [Sat, 8 Apr 2023 08:33:25 +0000 (17:33 +0900)]
copy: make copy_bytes() support O_PATH fds
Luca Boccassi [Mon, 10 Apr 2023 17:42:34 +0000 (18:42 +0100)]
Merge pull request #27182 from mrc0mmand/test-tweaks
test: a couple of stability tweaks
Daan De Meyer [Mon, 10 Apr 2023 09:50:34 +0000 (11:50 +0200)]
Merge pull request #27184 from yuwata/xfopenat-full
fileio: introduce xfopenat_full()
Дамјан Георгиевски [Mon, 3 Apr 2023 09:10:41 +0000 (11:10 +0200)]
ci: add permissions to make a release
follow-up to https://github.com/systemd/systemd/pull/27071
in order to create Github Releases, the job needs permissions to write
contents
also:
- pinned the `softprops/action-gh-release` action to a specific commit
- made it only active on the `systemd` organization repos (so not on
forks)
Mike Yuan [Mon, 10 Apr 2023 09:19:11 +0000 (17:19 +0800)]
Merge pull request #27193 from yuwata/analyze-blame
analyze: make 'blame' work even the default target not reached
Daan De Meyer [Mon, 10 Apr 2023 05:52:04 +0000 (07:52 +0200)]
Merge pull request #27194 from yuwata/chase-cleanups
chase: several cleanups
Yu Watanabe [Mon, 10 Apr 2023 01:04:25 +0000 (10:04 +0900)]
fd-util: slightly optimize dir_fd_is_root()
When STATX_MNT_ID is not supported, we need to manually obtain mount id.
Let's compare inodes earlier.
Yu Watanabe [Mon, 10 Apr 2023 00:55:22 +0000 (09:55 +0900)]
chase: use dir_fd_is_root() to check if fd points to the root directory
As commented in dir_fd_is_root(), comparing inode is not enough to
determine if we are at the root directory.
Yu Watanabe [Mon, 10 Apr 2023 00:45:21 +0000 (09:45 +0900)]
chase: use stat_inode_same() at one more place
Yu Watanabe [Mon, 10 Apr 2023 00:31:28 +0000 (09:31 +0900)]
test: add tests about iterator position for path_find_{first,last}_component()
When path_find_first_component() returns the last component, the iterator
must be an empty string. The fact is heavily used in chaseat(). Let's
explicitly test it.
Yu Watanabe [Mon, 10 Apr 2023 00:30:14 +0000 (09:30 +0900)]
path-util: make iterator for path_find_last_component() always finish with the beginning of the buffer
Yu Watanabe [Sun, 9 Apr 2023 23:57:01 +0000 (08:57 +0900)]
chase: extend comment about CHASE_PARENT
Yu Watanabe [Sun, 9 Apr 2023 23:43:28 +0000 (08:43 +0900)]
chase: drop one redundant call of fstat()
Now, 'st' is always synced with 'fd'. Hence, we can use
stat_verify_directory().
Yu Watanabe [Sun, 9 Apr 2023 23:40:08 +0000 (08:40 +0900)]
chase: make struct stat always sync with the opened fd
Previously, struct stat may not be correctly synced with the currently
opened fd, e.g. when a path contains symlink which points to an absolute
path.
This also rename variables for struct stat, to make them consistent with
the corresponding fd.
Yu Watanabe [Sun, 9 Apr 2023 23:17:07 +0000 (08:17 +0900)]
chase: drop unnecessary conditions for buffer
Yu Watanabe [Sun, 9 Apr 2023 18:07:22 +0000 (03:07 +0900)]
test: add another regression test
For #27187, which should be also caused by #26956.
Yu Watanabe [Sun, 9 Apr 2023 18:40:49 +0000 (03:40 +0900)]
test: systemd-analyze blame should succeed now
Yu Watanabe [Sun, 9 Apr 2023 18:37:51 +0000 (03:37 +0900)]
analyze: make blame command work even the default target not reached
Yu Watanabe [Sat, 8 Apr 2023 19:12:53 +0000 (04:12 +0900)]
kernel-image: make inspect_kernel() optionally take directory fd
Yu Watanabe [Sat, 8 Apr 2023 17:41:26 +0000 (02:41 +0900)]
fileio: introduce read_one_line_file_at()
Yu Watanabe [Fri, 7 Apr 2023 03:24:01 +0000 (12:24 +0900)]
fileio: introduce xfopenat_full()
This unifies call of various xfopenat() variants.
No functional change, just refactoring.
Yu Watanabe [Fri, 7 Apr 2023 02:39:20 +0000 (11:39 +0900)]
fileio: use take_fdopen() and friends
Yu Watanabe [Sat, 8 Apr 2023 05:25:20 +0000 (14:25 +0900)]
Merge pull request #27160 from yuwata/conf_files_list_at
conf-files: introduce _at() variants of conf file enumerator
Yu Watanabe [Sat, 8 Apr 2023 04:56:06 +0000 (13:56 +0900)]
Merge pull request #27174 from YHNdnzj/edit-util-fixlets
edit-util: several improvements
Frantisek Sumsal [Fri, 7 Apr 2023 11:58:49 +0000 (13:58 +0200)]
test: check if we skip the full setup on daemon-reexec (again)
My original assumption in
61961e693d was wrong, since we do reset
/dev/console during reexec (see make_console_stdio()), so the test was
quite racy. Let's replace it with something, hopefully, more reliable.
Follow-up to
61961e693d .
Yu Watanabe [Fri, 7 Apr 2023 18:33:32 +0000 (03:33 +0900)]
test-64: add tests for compat devlinks for NVMe drive
Yu Watanabe [Fri, 7 Apr 2023 21:01:10 +0000 (06:01 +0900)]
test: add tests for conf_files_list_at() and friends
Yu Watanabe [Thu, 6 Apr 2023 21:09:15 +0000 (06:09 +0900)]
conf-files: introduce _at() variants of conf_files_list() or friends
Yu Watanabe [Fri, 7 Apr 2023 20:02:56 +0000 (05:02 +0900)]
conf-files: split out logic of copy and sort filenames from hashmap
No functional change, preparation for the next commit.
Yu Watanabe [Thu, 6 Apr 2023 20:42:18 +0000 (05:42 +0900)]
conf-files: use path_compare_filename()
Yu Watanabe [Thu, 6 Apr 2023 20:39:44 +0000 (05:39 +0900)]
path-util: introduce path_compare_filename()