]> git.ipfire.org Git - thirdparty/squid.git/log
thirdparty/squid.git
10 years agourl_rewrite_extras and store_id_extras patch fixes
Christos Tsantilas [Thu, 13 Mar 2014 10:56:38 +0000 (12:56 +0200)] 
url_rewrite_extras and store_id_extras patch fixes

Fixes to patch "Add url_rewrite_extras and store_id_extras for redirector and store_id helpers",r13308:
  - Fix cf_gen.cc:gen_conf(..) function to not escape quotes before write to
    conf file
  - The Format::Format name is used to inform the user about parsing problems.
    Fix the names of related objects for the new redirecor_extras and
    store_id_extras directives.
  - cf.data.pre: The NAME tag take as argument only the name of directive. Fix
    the new redirecor_extras and store_id_extras related tags.

10 years agoAdd url_rewrite_extras and store_id_extras for redirector and store_id helpers
Christos Tsantilas [Wed, 12 Mar 2014 16:46:27 +0000 (18:46 +0200)] 
Add url_rewrite_extras and store_id_extras for redirector and store_id helpers

The url_rewrite_extras/store_id_extras is a "quoted string" with logformat
%macro support. It is used to modify the request line for redirector and
storeId helpers.

The url rewrite and store_id helpers request format now is:
       url [<SP> extras]
and the default value for extras is:
  "%>a/%>A %un %>rm myip=%la myport=%lp"

Example usage:
   url_rewrite_extras "Note1=%{Note1}note Note2=%{Note2}note"

This is a Measurement Factory project.

10 years agoPrep for 3.3.12 and 3.4.4
Amos Jeffries [Sun, 9 Mar 2014 03:06:51 +0000 (20:06 -0700)] 
Prep for 3.3.12 and 3.4.4

10 years agoAvoid assertions on Range requests that trigger Squid-generated errors.
Alex Rousskov [Sat, 8 Mar 2014 17:28:23 +0000 (10:28 -0700)] 
Avoid assertions on Range requests that trigger Squid-generated errors.

Added HttpRequest::ignoreRange() to encapsulate range ignoring logic.
Currently the new method only contains the code common among all callers. More
work is needed to check whether further caller homogenization is possible.

Documented that ClientSocketContext::getNextRangeOffset() may sometimes be
called before it is ready to do its job.

10 years agoProtect MemBlob::append() against raw-space writes
Amos Jeffries [Fri, 7 Mar 2014 11:18:03 +0000 (04:18 -0700)] 
Protect MemBlob::append() against raw-space writes

There is no guarantee that the 'unused' area of MemBlob is actually
unused. For example if a read buffer was being filled into the
rawSpace() of a SBuf or MemBlob it will overlap with this empty area
until a read call updates the related size state in MemBlob/SBuf.

For these cases we must use memmove() which guarantees no buffer
corruption will take place on memory overlaps.

10 years agoCopyright: Remove explicit claims on src/ by Treehouse Networks Ltd.
Amos Jeffries [Thu, 6 Mar 2014 05:41:17 +0000 (18:41 +1300)] 
Copyright: Remove explicit claims on src/ by Treehouse Networks Ltd.

Amos Jeffries is listed as author in CONTRIBUTORS and Treehouse Networks
Ltd. listed in SPONSORS and commit messages.

10 years agoCopyright: Relicense helpers by Treehouse Networks Ltd.
Amos Jeffries [Thu, 6 Mar 2014 03:55:41 +0000 (20:55 -0700)] 
Copyright: Relicense helpers by Treehouse Networks Ltd.

Update the license on helper code designed and authored by myself using
the BSD 2-clause license. This makes the example helper code and license
more legally acceptible for use as a basis of proprietary helpers while
remaining compatible with GPL for distribution with Squid.

10 years agoLanguages: Georgian dialect
Amos Jeffries [Wed, 5 Mar 2014 22:34:18 +0000 (11:34 +1300)] 
Languages: Georgian dialect

10 years agoLanguages: Georgian
Amos Jeffries [Wed, 5 Mar 2014 22:30:03 +0000 (11:30 +1300)] 
Languages: Georgian

10 years agoTranslation: update POT content
Amos Jeffries [Wed, 5 Mar 2014 22:25:04 +0000 (11:25 +1300)] 
Translation: update POT content

10 years agoBetter fix for CMSG definitions
Amos Jeffries [Wed, 5 Mar 2014 12:08:54 +0000 (01:08 +1300)] 
Better fix for CMSG definitions

It turns out autoconf versions are not consistent with $ symbol escaping
which can cause incorrect definitions. Revert to AC_CHECK_TYPE instead.
Its a bit more verbose in configure.ac but works more often than not.

10 years agoPortability: define CMSG related structures individually
Amos Jeffries [Wed, 5 Mar 2014 06:32:34 +0000 (19:32 +1300)] 
Portability: define CMSG related structures individually

Some OS provide the CMSG related definitions and others only partially
define them. Sometimes (Windows particularly) this varies between build
environments.

Checking for each symbol separately and providing only those needed
avoids problems we have been having with missing or redefined symbols
on Windows and elsewhere.

10 years agoAdd debug messages indicating type/reason for HITs
Amos Jeffries [Tue, 4 Mar 2014 10:40:36 +0000 (23:40 +1300)] 
Add debug messages indicating type/reason for HITs

10 years agoFix helper ID number assignment
Amos Jeffries [Tue, 4 Mar 2014 10:33:08 +0000 (23:33 +1300)] 
Fix helper ID number assignment

Since helpers are now dynamically started the old method of allocating
an ID number based on the current start sequence can result in many
helpers being assigned overlapping ID numbers.

Use InstanceID template instead to assure a unique incremental ID is
assigned to each helper no matter when it is started.

10 years agoFix syntax error in pinger
Francesco Chemolli [Mon, 24 Feb 2014 12:20:29 +0000 (13:20 +0100)] 
Fix syntax error in pinger

10 years agoMigrated RegisteredRunners to a multi-action interface.
Alex Rousskov [Fri, 21 Feb 2014 16:14:05 +0000 (09:14 -0700)] 
Migrated RegisteredRunners to a multi-action interface.

Old generic two-action RegisteredRunners were good for handling paired
create/destroy events, but not all main.cc events fit that model well. In
fact, even the old runners implemented the destruction action for one event
only (rrAfterConfig); all other runners implemented a single action.

The adjusted API better supports runners that are interested in any number
of the supported events. It also allows a single runner object to handle
multiple events, which simplifies current code and may help with better
[re]configuration handling in the future.

Added startShutdown() and finishShutdown() events. The former will be needed
for authentication module shutdown and more polished shutdown initiation code
in general (patch pending). The latter is needed for final cleanup code that
previously ran as the destruction action for rrAfterConfig. finishShutdown()
also destroys all runners.

Note that the master process in SMP mode does not run startShutdown because
that process lacks the main loop and startShutdown() promises at least one
main loop iteration (to help with clean connections closures, for example).

Added syncConfig() event that will be needed for the standby pool
implementation (patch pending) and future code that reacts to Squid
configuration changes caused by reconfiguration.

"after config" event is now called "use config" to better match verb+noun or
action+object naming scheme.

10 years agoFixed stalled concurrent rock store reads by insuring their ID uniqueness.
Alex Rousskov [Fri, 21 Feb 2014 15:45:01 +0000 (08:45 -0700)] 
Fixed stalled concurrent rock store reads by insuring their ID uniqueness.

Added a check to prevent similar bugs from occurring in the future.

10 years agoCleanup: un-wrap C++ header includes
Amos Jeffries [Fri, 21 Feb 2014 10:46:19 +0000 (03:46 -0700)] 
Cleanup: un-wrap C++ header includes

Coding guideline is now that standard C++ headers are not to be
wrapped in HAVE_ macros.

* Remove HAVE_ macros for currently wrapped C++ headers.
  Includes removing autoconf checks.

* Replace C includes with C++ includes where possible

Also, <cstdio> / <stdio.h> has issues on 64-bit systems and a
portable fixed version is provided by libcompat via squid.h
It should not be included anywhere in the Squid sources.

10 years agoLanguages: updated Serbian aliases
Marko Cupac [Fri, 21 Feb 2014 10:10:21 +0000 (03:10 -0700)] 
Languages: updated Serbian aliases

10 years agoBug 3186, Bug 3628: Digest authentication always sending stale=false for nonce
Henrik Nordstrom [Fri, 21 Feb 2014 02:19:52 +0000 (19:19 -0700)] 
Bug 3186, Bug 3628: Digest authentication always sending stale=false for nonce

10 years agoFix compile issues in rev.13288
Amos Jeffries [Thu, 20 Feb 2014 23:33:29 +0000 (12:33 +1300)] 
Fix compile issues in rev.13288

10 years agosquidclient: --ping mode module support
Amos Jeffries [Thu, 20 Feb 2014 13:03:07 +0000 (06:03 -0700)] 
squidclient: --ping mode module support

  Module support:

Update squidclient support modules with different logics
and configuration option sets as a basis for multiple
protocol support.

A mechanism is added to allow each module to have its own
command line option set. Any option unknown to the current
module handler drops back to the main loop for processing.

  --ping mode module:

Break the existing code "ping mode" operations and command
line processing out from the main squidclient.cc into Ping.*

Ping-specific short command line options are now only parsed
after a mode flag (--ping) is presented. This frees up the
-g and -I options for use by other non-ping modules in future.

Also, shuffle squidclient code into its own directory
tools/squidclient/ to keep the tool code files clearly
identifiable now that they are multiplying.

10 years agoBug 3628: Digest auth sending stale=false on nonce mismatch
Henrik Nordstrom [Thu, 20 Feb 2014 01:50:39 +0000 (18:50 -0700)] 
Bug 3628: Digest auth sending stale=false on nonce mismatch

10 years agodynamic_cert_mem_cache_size option related fixes part2: "make check" fails
Christos Tsantilas [Wed, 19 Feb 2014 18:48:16 +0000 (20:48 +0200)] 
dynamic_cert_mem_cache_size option related fixes part2: "make check" fails

10 years agodynamic_cert_mem_cache_size option related fixes
Christos Tsantilas [Wed, 19 Feb 2014 17:53:27 +0000 (19:53 +0200)] 
dynamic_cert_mem_cache_size option related fixes

This patch fixes the following problems:

1) The dynamic_cert_mem_cache_size does not change on reconfigure

2) When dynamic_cert_mem_cache_size of http_port set to 0 then:

   a) The dynamic certs cache is grow unlimited.
      This patch just disables certificates caching when this option set to 0.

   b) Huge amount of memory appeared as free cache memory in  "Cached ssl
      certificates statistic" page of cache manager.
      This problem caused because of a signed to unsigned int conversion.

This is a Measurement Factory project

10 years agoFix uses of std::remove to actually resize the data structures which were cleaned-up.
Francesco Chemolli [Wed, 19 Feb 2014 17:01:30 +0000 (18:01 +0100)] 
Fix uses of std::remove to actually resize the data structures which were cleaned-up.

10 years agoFix pthread library detection on FreeBSD 10
Amos Jeffries [Tue, 18 Feb 2014 13:57:16 +0000 (06:57 -0700)] 
Fix pthread library detection on FreeBSD 10

We should not be using "cut -b1" anywhere to determine OS version
number. It drops digits out of the major version number.

10 years agoFix umask default on crash report generated email
Amos Jeffries [Tue, 18 Feb 2014 11:39:58 +0000 (04:39 -0700)] 
Fix umask default on crash report generated email

10 years agoBug 4029: intercepted HTTPS requests bypass caching checks
Rajiv Desai [Mon, 17 Feb 2014 14:05:24 +0000 (06:05 -0800)] 
Bug 4029: intercepted HTTPS requests bypass caching checks

10 years agoFix shadowed variable in rev.13279
Amos Jeffries [Sun, 16 Feb 2014 09:50:29 +0000 (22:50 +1300)] 
Fix shadowed variable in rev.13279

10 years agosquidclient: support long options on command line
Amos Jeffries [Sun, 16 Feb 2014 06:14:16 +0000 (23:14 -0700)] 
squidclient: support long options on command line

10 years agosquidclient: polish and documentation
Amos Jeffries [Sun, 16 Feb 2014 05:55:24 +0000 (22:55 -0700)] 
squidclient: polish and documentation

10 years agosquidclient: support verbosity levels
Amos Jeffries [Sun, 16 Feb 2014 05:15:45 +0000 (22:15 -0700)] 
squidclient: support verbosity levels

This makes the -v option repeatable. By default no debug is displayed.
Each time -v is repeated the level of debug message verbosity is raised.

Three levels of verbosity are currently defined:
 0 - no output except ERROR messages.
 1 - display HTTP request sent
 2 - display actions taken connecting to server

10 years agosquidclient: polish and update help display
Amos Jeffries [Sun, 16 Feb 2014 03:22:24 +0000 (20:22 -0700)] 
squidclient: polish and update help display

10 years agoFix memory leak regression in SNMP from rev.13274
Amos Jeffries [Thu, 13 Feb 2014 22:22:35 +0000 (11:22 +1300)] 
Fix memory leak regression in SNMP from rev.13274

Variable "name" going out of scope leaks the storage it points to if any
of the parse was done by incomplete.

 Detected by Coverity Scan. Issue 1174204.

10 years agoBug 4001: remove use of strsep()
Amos Jeffries [Thu, 13 Feb 2014 07:02:35 +0000 (20:02 +1300)] 
Bug 4001: remove use of strsep()

The strsep() function is not defined by POSIX. Additionally
auto-tools has been having some obscure issues detecting
or linking the provided implementation into libcompat on
Windows and Solaris respectively. Which are the two known
OS requiring it.

Investigation of its use in Squid revealed that it can be
replaced with strcspan() which is both portable and more
efficient since it also removes the need for several
strdup()/free() operations used to protect Squid from
strsep() memory fiddling.

10 years agoBug 4026: SSL and adaptation_access does not handle aborted connections
Nathan Hoad [Thu, 13 Feb 2014 06:09:26 +0000 (19:09 +1300)] 
Bug 4026: SSL and adaptation_access does not handle aborted connections

10 years agoRevert rev.13271
Amos Jeffries [Thu, 13 Feb 2014 05:41:14 +0000 (18:41 +1300)] 
Revert rev.13271

10 years agoBug 4026: SSL and adaptation_access does not handle aborted connections
Nathan Hoad [Thu, 13 Feb 2014 05:29:15 +0000 (18:29 +1300)] 
Bug 4026: SSL and adaptation_access does not handle aborted connections

10 years agoRefactor Vector and Stack to STL counterparts
Francesco Chemolli [Wed, 12 Feb 2014 10:43:26 +0000 (11:43 +0100)] 
Refactor Vector and Stack to STL counterparts

10 years agoStreamline storeLateRelease
Francesco Chemolli [Wed, 12 Feb 2014 09:19:06 +0000 (10:19 +0100)] 
Streamline storeLateRelease

10 years agoFix crash bug in HttpHeader::clean()
Francesco Chemolli [Wed, 12 Feb 2014 08:51:26 +0000 (09:51 +0100)] 
Fix crash bug in HttpHeader::clean()

10 years agoRemove Vector, Stack and related unit tests
Francesco Chemolli [Tue, 11 Feb 2014 13:14:09 +0000 (14:14 +0100)] 
Remove Vector, Stack and related unit tests

10 years agoReworked all clients of Stack to std::stack
Francesco Chemolli [Tue, 11 Feb 2014 12:05:47 +0000 (13:05 +0100)] 
Reworked all clients of Stack to std::stack

10 years agoReworked cbdata to use std::vector to be able to have a random access iterator
Francesco Chemolli [Tue, 11 Feb 2014 12:02:07 +0000 (13:02 +0100)] 
Reworked cbdata to use std::vector to be able to have a random access iterator

10 years agoMerged from trunk
Francesco Chemolli [Tue, 11 Feb 2014 11:45:10 +0000 (12:45 +0100)] 
Merged from trunk

10 years agoVector refactor: move almost all clients to std::vector from Vector
Francesco Chemolli [Tue, 11 Feb 2014 11:35:20 +0000 (12:35 +0100)] 
Vector refactor: move almost all clients to std::vector from Vector

10 years agoMerged from trunk
Francesco Chemolli [Tue, 11 Feb 2014 11:32:45 +0000 (12:32 +0100)] 
Merged from trunk

10 years agoFixed some formatting
Francesco Chemolli [Tue, 11 Feb 2014 11:30:51 +0000 (12:30 +0100)] 
Fixed some formatting

10 years agoRefactor Splay and MemPoolMalloc to use std::stack
Francesco Chemolli [Tue, 11 Feb 2014 11:22:39 +0000 (12:22 +0100)] 
Refactor Splay and MemPoolMalloc to use std::stack

10 years agoAdapt some callers to std:: API
Francesco Chemolli [Tue, 11 Feb 2014 09:57:24 +0000 (10:57 +0100)] 
Adapt some callers to std:: API

10 years agoCleanup: remove garbage prefixes from Digest auth debugs
Amos Jeffries [Tue, 11 Feb 2014 09:12:28 +0000 (02:12 -0700)] 
Cleanup: remove garbage prefixes from Digest auth debugs

10 years agoAdded missing includes
Francesco Chemolli [Mon, 10 Feb 2014 22:39:56 +0000 (23:39 +0100)] 
Added missing includes

10 years agoCleanup
Francesco Chemolli [Mon, 10 Feb 2014 17:52:49 +0000 (18:52 +0100)] 
Cleanup

10 years agoRefactor all users of Vector to std::vector except for Stack
Francesco Chemolli [Mon, 10 Feb 2014 17:18:48 +0000 (18:18 +0100)] 
Refactor all users of Vector to std::vector except for Stack

10 years agoMore Vector to std::vector refactoring
Francesco Chemolli [Mon, 10 Feb 2014 16:39:10 +0000 (17:39 +0100)] 
More Vector to std::vector refactoring

10 years agoRefactor HttpHeader::entries
Francesco Chemolli [Mon, 10 Feb 2014 15:07:49 +0000 (16:07 +0100)] 
Refactor HttpHeader::entries

10 years agoGet rid of all users of Vector::iterator::incrementable
Francesco Chemolli [Mon, 10 Feb 2014 13:55:54 +0000 (14:55 +0100)] 
Get rid of all users of Vector::iterator::incrementable

10 years agoMigrate some users of Vector to std::vector
Francesco Chemolli [Mon, 10 Feb 2014 12:58:49 +0000 (13:58 +0100)] 
Migrate some users of Vector to std::vector

10 years agoMerged from trunk
Francesco Chemolli [Mon, 10 Feb 2014 12:38:41 +0000 (13:38 +0100)] 
Merged from trunk

10 years agoFix argument name conflict in Auth::Config::findUserInCache
Francesco Chemolli [Mon, 10 Feb 2014 12:37:47 +0000 (13:37 +0100)] 
Fix argument name conflict in Auth::Config::findUserInCache

10 years agoMerge vector-refactor branch: align Vector API with std::vector
Francesco Chemolli [Mon, 10 Feb 2014 12:15:40 +0000 (13:15 +0100)] 
Merge vector-refactor branch: align Vector API with std::vector

10 years agoMerged from trunk
Francesco Chemolli [Mon, 10 Feb 2014 12:14:44 +0000 (13:14 +0100)] 
Merged from trunk

10 years agoBug 3969: user credentials cache lookup for Digest authentication broken
Frederic Bourgeois [Mon, 10 Feb 2014 11:08:58 +0000 (04:08 -0700)] 
Bug 3969: user credentials cache lookup for Digest authentication broken

Changes to the username credentials cache were made in Basic auth but
the matching changes were not duplicated to Digest auth. Since the
lookup is identical move it to generic Auth::Config.

Also fixes assertion auth_digest.cc:759:
    "(nonce->user == NULL) || (nonce->user == user)"

10 years agoMerged from trunk
Francesco Chemolli [Mon, 10 Feb 2014 09:59:19 +0000 (10:59 +0100)] 
Merged from trunk

10 years agoMake ESICustomParser::parse c++98-compatible
Francesco Chemolli [Mon, 10 Feb 2014 09:19:56 +0000 (10:19 +0100)] 
Make ESICustomParser::parse c++98-compatible

10 years agoFix cstdio compile errors
Amos Jeffries [Sun, 9 Feb 2014 08:55:01 +0000 (01:55 -0700)] 
Fix cstdio compile errors

10 years agoSource Maintenance - manual run
Amos Jeffries [Sat, 8 Feb 2014 13:36:42 +0000 (06:36 -0700)] 
Source Maintenance - manual run

10 years agoMove compat/unsafe.h protections from libcompat to source maintenance
Amos Jeffries [Sat, 8 Feb 2014 12:33:31 +0000 (05:33 -0700)] 
Move compat/unsafe.h protections from libcompat to source maintenance

It is sufficient to run a code scan from source-maintenance.sh for the
unsafe functions being used in Squid-specific code instead of
hard-coding compiler breakage on users.
This also "fixes" reporting of errors when cstdio pulls in use of the
unsafe functions by stdlib.

10 years agoVarious fixes to configure for FreeBSD 10
Dennis Glatting [Sat, 8 Feb 2014 08:53:47 +0000 (01:53 -0700)] 
Various fixes to configure for FreeBSD 10

* Detect cstdio file presence for libcompat

* Fix shell syntax in Heimdal Kerberos library detection

10 years agoUse Vector::at() instead of [] errorInitialize()
Francesco Chemolli [Fri, 7 Feb 2014 16:14:42 +0000 (17:14 +0100)] 
Use Vector::at() instead of [] errorInitialize()

10 years agoMerged from trunk
Francesco Chemolli [Fri, 7 Feb 2014 15:38:35 +0000 (16:38 +0100)] 
Merged from trunk

10 years agoHave Vector::at rely on operator[] to do the low-level access
Francesco Chemolli [Fri, 7 Feb 2014 15:37:11 +0000 (16:37 +0100)] 
Have Vector::at rely on operator[] to do the low-level access

10 years agoSourceLayout: shuffle URLScheme to AnyP::UriScheme
Amos Jeffries [Fri, 7 Feb 2014 13:45:20 +0000 (06:45 -0700)] 
SourceLayout: shuffle URLScheme to AnyP::UriScheme

This class holds a generic protocol agnostic Scheme representation.

* rename const_str() member to c_str() since it produces a const C-string
 (char*) representation.

* Remove some unecessary dependencies.

* Cleanup the coding style to match guidelines.

10 years agoVector::pop_back returns void now; don't save the old value
Francesco Chemolli [Thu, 6 Feb 2014 14:14:36 +0000 (15:14 +0100)] 
Vector::pop_back returns void now; don't save the old value

10 years agoMerged from trunk
Francesco Chemolli [Thu, 6 Feb 2014 13:05:41 +0000 (14:05 +0100)] 
Merged from trunk

10 years agoRegression Bug 3769: client_netmask not evaluated since Comm redesign
Amos Jeffries [Thu, 6 Feb 2014 12:16:08 +0000 (05:16 -0700)] 
Regression Bug 3769: client_netmask not evaluated since Comm redesign

10 years agoFix r13257 commit
Francesco Chemolli [Thu, 6 Feb 2014 09:30:48 +0000 (10:30 +0100)] 
Fix r13257 commit

10 years agoFix keepalive handling for non-ranged requests.
Alex Rousskov [Wed, 5 Feb 2014 18:04:47 +0000 (19:04 +0100)] 
Fix keepalive handling for non-ranged requests.

Internal keepalive flag was ignored by a mismatched interface between ClientSocketContext::socketState
and writeComplete in the case of non-ranged requests.

10 years agoChanged c-style cast to const_cast in esi/CustomParser.cc
Francesco Chemolli [Tue, 4 Feb 2014 19:55:16 +0000 (20:55 +0100)] 
Changed c-style cast to const_cast in esi/CustomParser.cc

10 years agoRemoved useless include in errorpage.cc
Francesco Chemolli [Tue, 4 Feb 2014 19:51:44 +0000 (20:51 +0100)] 
Removed useless include in errorpage.cc

10 years agoReverted broken change in HttpRequest::multipartRangeRequest
Francesco Chemolli [Tue, 4 Feb 2014 19:50:02 +0000 (20:50 +0100)] 
Reverted broken change in HttpRequest::multipartRangeRequest

10 years agoRemove Vector::operator +=. Removed some useless comments
Francesco Chemolli [Tue, 4 Feb 2014 19:47:14 +0000 (20:47 +0100)] 
Remove Vector::operator +=. Removed some useless comments

10 years agoMove some looping checks from size() to !empty()
Francesco Chemolli [Tue, 4 Feb 2014 16:54:49 +0000 (17:54 +0100)] 
Move some looping checks from size() to !empty()

10 years agoChanged pop_back() signature to match std::vector. Marked hot methods inline
Francesco Chemolli [Sun, 2 Feb 2014 18:19:59 +0000 (19:19 +0100)] 
Changed pop_back() signature to match std::vector. Marked hot methods inline

10 years agoTurned Vector::count and capacity protected
Francesco Chemolli [Sun, 2 Feb 2014 17:10:57 +0000 (18:10 +0100)] 
Turned Vector::count and capacity protected

10 years agoMade Vector::items private
Francesco Chemolli [Sun, 2 Feb 2014 14:36:26 +0000 (15:36 +0100)] 
Made Vector::items private

10 years agoRenamed Vector::clean to clear
Francesco Chemolli [Sun, 2 Feb 2014 09:42:23 +0000 (10:42 +0100)] 
Renamed Vector::clean to clear

10 years agoRemove layering violations in Vector users
Francesco Chemolli [Sun, 2 Feb 2014 08:57:20 +0000 (09:57 +0100)] 
Remove layering violations in Vector users

10 years agoPrep for 3.4.3
Amos Jeffries [Sun, 2 Feb 2014 03:09:44 +0000 (20:09 -0700)] 
Prep for 3.4.3

10 years agoFix peerSelectDnsResults() IP address cycling
Amos Jeffries [Sun, 2 Feb 2014 01:24:53 +0000 (18:24 -0700)] 
Fix peerSelectDnsResults() IP address cycling

The local ip variable is the index of the IP address to be used.
Loop counter n is only used to prevent cycling indefinitely and should
not be used to access the array indexes.

10 years agoComm job callbacks need job's cbdata pointer, not a job pointer.
Alex Rousskov [Tue, 28 Jan 2014 19:28:23 +0000 (12:28 -0700)] 
Comm job callbacks need job's cbdata pointer, not a job pointer.

Otherwise, in complex inheritance hierarchies, some [inner] classes will
hit cbdata cookie assertions when scheduling Comm calls with callbacks.

10 years agoBug 3975: atomic detection cross-compilation failure
Stefano Cordibella [Mon, 27 Jan 2014 13:37:38 +0000 (06:37 -0700)] 
Bug 3975: atomic detection cross-compilation failure

10 years agoBug 3608: part 1 - per-service name for workers UDS sockets
Amos Jeffries [Mon, 27 Jan 2014 05:27:41 +0000 (22:27 -0700)] 
Bug 3608: part 1 - per-service name for workers UDS sockets

Separate the UDS socket names used by SMP workers by the -n service_name
label assigned to the Squid instance being run.

TODO: separate shared memory blocks per-service.

10 years agoAdd ${service_name} macro to squid.conf processing
Amos Jeffries [Mon, 27 Jan 2014 03:06:15 +0000 (20:06 -0700)] 
Add ${service_name} macro to squid.conf processing

This allows squid.conf directives to be configured per-service by
expanding into the -n service_name parameter. The default is "squid".

10 years agoBug 3954: compile failure in CpuAffinity.cc
Unknown FreeBSD Contributor [Mon, 27 Jan 2014 02:11:08 +0000 (19:11 -0700)] 
Bug 3954: compile failure in CpuAffinity.cc

Patch written by 'dim [1]' contributor to FreeBSD and imported to Squid
under FreeBSD license. see
http://svnweb.freebsd.org/ports/head/www/squid33/files/patch-include__Array.h

10 years agoEnable -n command line option for non-Windows Squid builds
Amos Jeffries [Fri, 24 Jan 2014 01:57:15 +0000 (18:57 -0700)] 
Enable -n command line option for non-Windows Squid builds

This command line option is used on Windows to name the service instance
of Squid being run and/or managed. At this point it still only has
useful effect on Windows, but can now be used by components on other
systems as well.

Show the running instance service name in cacehmgr and -v output.

Also remove _WIN_SQUID_DEFAULT_SERVICE_NAME macro which duplicated the
APP_SHORTNAME macro. This changes the Windows service name from Squid to
squid (lower case) on future Squid-3 for Windows.

10 years agoInitialize asyncLoopDepth_ in constructor
Amos Jeffries [Thu, 23 Jan 2014 22:47:39 +0000 (15:47 -0700)] 
Initialize asyncLoopDepth_ in constructor

  Detected by Coverity Scan. Issue 740529.

10 years agoBug 3971: "BUG: cannot aggregate mgr:client_list: cmd->profile != NULL" in SMP mode
Nathan Hoad [Thu, 23 Jan 2014 07:59:26 +0000 (09:59 +0200)] 
Bug 3971: "BUG: cannot aggregate mgr:client_list: cmd->profile != NULL" in SMP mode

When running Squid in SMP mode, the 'client_list' command cannot be used as the
coordinator doesn't call clientdbInit(), and thus doesn't have the client_list
action registered.

This patch uses RegisteredRunner to initialize clientdb and register the
'client_list' command

10 years agoBug 1202 part 1: documentation and debugs for refresh_pattern algorithms
Doug Dixon [Mon, 20 Jan 2014 10:43:03 +0000 (23:43 +1300)] 
Bug 1202 part 1: documentation and debugs for refresh_pattern algorithms

This contains only the code documentation and debugs changes as relevant
to the current code. Some which are only relevant to the new code from
that bug patch have been omitted.

It omits all logic changes and function renaming changes.