]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
4 years agonetwork: accept NUL character in SendOption= 14675/head
Yu Watanabe [Mon, 27 Jan 2020 09:11:08 +0000 (18:11 +0900)] 
network: accept NUL character in SendOption=

Closes #14609.

4 years agotest: add tests for UNESCAPE_ACCEPT_NUL
Yu Watanabe [Mon, 27 Jan 2020 09:09:25 +0000 (18:09 +0900)] 
test: add tests for UNESCAPE_ACCEPT_NUL

4 years agoescape: introduce UNESCAPE_ACCEPT_NUL flag
Yu Watanabe [Mon, 27 Jan 2020 08:46:22 +0000 (17:46 +0900)] 
escape: introduce UNESCAPE_ACCEPT_NUL flag

4 years agoescape: make cunescape() and cunescape_length() inline
Yu Watanabe [Mon, 27 Jan 2020 08:38:41 +0000 (17:38 +0900)] 
escape: make cunescape() and cunescape_length() inline

4 years agoefi: fix build.
Susant Sahani [Sat, 25 Jan 2020 10:30:08 +0000 (11:30 +0100)] 
efi: fix build.

```
ninja -C build
ninja: Entering directory `build'
[29/101] Generating systemd_boot.so with a custom command.
FAILED: src/boot/efi/systemd_boot.so
/usr/bin/ld -o src/boot/efi/systemd_boot.so -T /usr/lib64/gnuefi/elf_x64_efi.lds -shared -Bsymbolic -nostdlib -znocombreloc -L /usr/lib64 /usr/lib64/gnuefi/crt0-efi-x64.o src/boot/efi/disk.c.o src/boot/efi/graphics.c.o src/boot/efi/measure.c.o src/boot/efi/pe.c.o src/boot/efi/util.c.o src/boot/efi/boot.c.o src/boot/efi/console.c.o src/boot/efi/crc32.c.o src/boot/efi/random-seed.c.o src/boot/efi/sha256.c.o src/boot/efi/shim.c.o -lefi -lgnuefi /usr/lib/gcc/x86_64-redhat-linux/10/libgcc.a
/usr/bin/ld: src/boot/efi/graphics.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/pe.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/util.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/boot.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/console.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/random-seed.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/shim.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
[31/101] Generating stub.c.o with a custom command.
ninja: build stopped: subcommand failed.
make: *** [Makefile:2: all] Error 1

```

4 years agoman: tmpfiles.d: list missing q
Florian Klink [Fri, 24 Jan 2020 18:01:29 +0000 (19:01 +0100)] 
man: tmpfiles.d: list missing q

Also, Q creates directories (same as v), so update the example
accordingly.

4 years agoUpdate copyright notice
WataruMatsuoka [Sat, 25 Jan 2020 21:35:02 +0000 (06:35 +0900)] 
Update copyright notice

4 years agotest: unpin meson from v0.52.1
Frantisek Sumsal [Sat, 25 Jan 2020 16:48:23 +0000 (17:48 +0100)] 
test: unpin meson from v0.52.1

The compatibility issue in meson v0.53 has been fixed in v0.53.1, which
is already available through pip, so let's remove the pin for meson
introduced before.

Reverts: 514793658c499821383bdc8bbf1d33048c18dd40

4 years agoman: remove duplicate in list of variables ignored by Anonymize
Tobias Klauser [Fri, 24 Jan 2020 15:07:48 +0000 (16:07 +0100)] 
man: remove duplicate in list of variables ignored by Anonymize

SendHostname= appears twice in the list of variables ignored by
Anonymize=.

4 years agoupdate TODO
Lennart Poettering [Thu, 23 Jan 2020 21:59:47 +0000 (22:59 +0100)] 
update TODO

4 years agoMerge pull request #14368 from poettering/repart
Zbigniew Jędrzejewski-Szmek [Thu, 23 Jan 2020 18:07:02 +0000 (19:07 +0100)] 
Merge pull request #14368 from poettering/repart

4 years agoupdate TODO
Lennart Poettering [Wed, 22 Jan 2020 21:59:30 +0000 (22:59 +0100)] 
update TODO

4 years agoMerge pull request #14618 from poettering/growfs-rootfs
Anita Zhang [Wed, 22 Jan 2020 13:32:18 +0000 (05:32 -0800)] 
Merge pull request #14618 from poettering/growfs-rootfs

generator: order growfs for the root fs after systemd-remount-fs

4 years agoMerge pull request #14614 from poettering/import-fixlets
Anita Zhang [Wed, 22 Jan 2020 11:48:31 +0000 (03:48 -0800)] 
Merge pull request #14614 from poettering/import-fixlets

three small importd fixes

4 years agoMerge pull request #14628 from poettering/hwdb-asus-tp500la
hadess [Wed, 22 Jan 2020 10:47:06 +0000 (11:47 +0100)] 
Merge pull request #14628 from poettering/hwdb-asus-tp500la

hwdb: add asus tp500la

4 years agologinctl: use /org/freedesktop/login1/session/auto when "lock-session" is called...
Lennart Poettering [Tue, 21 Jan 2020 12:43:04 +0000 (13:43 +0100)] 
loginctl: use /org/freedesktop/login1/session/auto when "lock-session" is called without argument

This way we'll use the "display" session automatically, and that makes
the call work when invoked from user@.service.

Fixes: #13614
4 years agoMerge pull request #14605 from aerusso/pulls/x-systemd-wantedby-requiredby
Lennart Poettering [Tue, 21 Jan 2020 18:21:49 +0000 (19:21 +0100)] 
Merge pull request #14605 from aerusso/pulls/x-systemd-wantedby-requiredby

Implemented x-systemd.{required,wanted}-by= options

4 years agoman: fix typo in systemd.netdev Xfrm example
Andreas Rammhold [Tue, 21 Jan 2020 17:22:22 +0000 (18:22 +0100)] 
man: fix typo in systemd.netdev Xfrm example

The first section header in that example should probably be `[NetDev]` and not `[Xfrm]`.

4 years agonetwork,udev: use uint64_t for bit rate
Yu Watanabe [Tue, 21 Jan 2020 11:06:40 +0000 (20:06 +0900)] 
network,udev: use uint64_t for bit rate

Fixes #14620.

4 years agotimesyncd: log louder when we refuse a server due to root distance
Lennart Poettering [Tue, 21 Jan 2020 11:03:02 +0000 (12:03 +0100)] 
timesyncd: log louder when we refuse a server due to root distance

This is something people should know about, since it's caused by
misconfiguration.

Fixes: #13912
4 years agoMerge pull request #14617 from poettering/no-strv-clear
Lennart Poettering [Tue, 21 Jan 2020 14:08:38 +0000 (15:08 +0100)] 
Merge pull request #14617 from poettering/no-strv-clear

strv: remove strv_clear() and some other minor fixes

4 years agoMerge pull request #14622 from poettering/uid-ref-fixlets
Lennart Poettering [Tue, 21 Jan 2020 14:08:02 +0000 (15:08 +0100)] 
Merge pull request #14622 from poettering/uid-ref-fixlets

trivial uid ref counting clean-ups

4 years agoFixed some typos in the documentation
Emmanuel Bourg [Tue, 21 Jan 2020 13:07:02 +0000 (14:07 +0100)] 
Fixed some typos in the documentation

4 years agoresolved: drop DNSSEC root key that is not valid anymore
Lennart Poettering [Mon, 20 Jan 2020 16:11:31 +0000 (17:11 +0100)] 
resolved: drop DNSSEC root key that is not valid anymore

I guess we can drop this now, the key is no longer valid until
2019-01-11, hence there's no point in still including it in our trust
anchor.

4 years agoImplemented x-systemd.{required,wanted}-by= options 14605/head
Antonio Russo [Sat, 18 Jan 2020 21:14:58 +0000 (14:14 -0700)] 
Implemented x-systemd.{required,wanted}-by= options

Teaches systemd-fstab-generator these two unit options,
creating appropriate dependencies on the generated .mount
units.  When used, they override any other automatically
generated dependencies, such as local-fs.target, and are
NOT suppressed by noauto.  The new options are ignored for
/, in the same way that noauto is ignored.

Fixes: #14380
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
4 years agojournal: don't use startswith() on something that is not a NUL-terminated string
Lennart Poettering [Tue, 21 Jan 2020 09:49:58 +0000 (10:49 +0100)] 
journal: don't use startswith() on something that is not a NUL-terminated string

Otherwise we might access memory coming after it that is not valid or
allocated.

Fixes: #14114
4 years agohwbd: add Asus TP500LA 14628/head
Lennart Poettering [Tue, 21 Jan 2020 13:23:39 +0000 (14:23 +0100)] 
hwbd: add Asus TP500LA

Extracted from #12654

Fixes: #12654
4 years agohwdb: merge identical entries
Lennart Poettering [Tue, 21 Jan 2020 13:23:33 +0000 (14:23 +0100)] 
hwdb: merge identical entries

4 years agohwdb: fix whitespace issue
Lennart Poettering [Tue, 21 Jan 2020 13:23:14 +0000 (14:23 +0100)] 
hwdb: fix whitespace issue

4 years agovirt: do not define vm_from_string() for non-x86 architecture
Yu Watanabe [Tue, 21 Jan 2020 09:10:46 +0000 (18:10 +0900)] 
virt: do not define vm_from_string() for non-x86 architecture

Fixes #14615.

4 years agocore: make a number of functions not used externally static 14622/head
Lennart Poettering [Tue, 21 Jan 2020 10:51:45 +0000 (11:51 +0100)] 
core: make a number of functions not used externally static

4 years agocore: show the UID we cannot parse
Lennart Poettering [Tue, 21 Jan 2020 10:51:26 +0000 (11:51 +0100)] 
core: show the UID we cannot parse

4 years agojson: lower maximum allowed recursion to 2K
Lennart Poettering [Mon, 20 Jan 2020 19:13:46 +0000 (20:13 +0100)] 
json: lower maximum allowed recursion to 2K

Apparently 4K is too high still, let's halve it.

Fixes: #14396
4 years agogenerator: order growfs for the root fs after systemd-remount-fs 14618/head
Lennart Poettering [Tue, 21 Jan 2020 09:40:18 +0000 (10:40 +0100)] 
generator: order growfs for the root fs after systemd-remount-fs

Fixes: #14603
4 years agoMerge pull request #14595 from poettering/stdin-file-fix
Lennart Poettering [Tue, 21 Jan 2020 09:22:31 +0000 (10:22 +0100)] 
Merge pull request #14595 from poettering/stdin-file-fix

core: make sure StandardInput=file: doesn't get dup'ed to stdout/stde…

4 years agohwdb: fix error numbers passed to log_syntax() 14617/head
Lennart Poettering [Tue, 21 Jan 2020 09:15:26 +0000 (10:15 +0100)] 
hwdb: fix error numbers passed to log_syntax()

4 years agohwdb: use strv_extend() where we can
Lennart Poettering [Tue, 21 Jan 2020 09:13:07 +0000 (10:13 +0100)] 
hwdb: use strv_extend() where we can

4 years agostrv: get rid of strv_clear()
Lennart Poettering [Tue, 21 Jan 2020 09:07:34 +0000 (10:07 +0100)] 
strv: get rid of strv_clear()

Let's remove a function of questionnable utility.

strv_clear() frees the items of a string array, but not the array
itself. i.e. it half-drestructs a string array and makes it empty. This
is not too useful an operation since we almost never need to just do
that, we also want to free the whole thing. In fact, strv_clear() is
only used in one of our .c file, and there it appears like unnecessary
optimization, given that for each array with n elements it leaves the
number of free()s we need to at O(n) which is not really an optimization
at all (it goes from n+1 to n, that's all).

Prompted by the discussions on #14605

4 years agoDocumentation update for x-systemd.{before,after}
Antonio Russo [Tue, 21 Jan 2020 02:35:13 +0000 (19:35 -0700)] 
Documentation update for x-systemd.{before,after}

A minor clarification in the manual page is made.

Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
4 years agoimport: let's disable UNIX signal generation from curl 14614/head
Lennart Poettering [Mon, 20 Jan 2020 21:05:53 +0000 (22:05 +0100)] 
import: let's disable UNIX signal generation from curl

4 years agoimport: put a time-out on downloads
Lennart Poettering [Mon, 20 Jan 2020 21:02:14 +0000 (22:02 +0100)] 
import: put a time-out on downloads

Let's abort downloads when they are stuck by setting a download speed
threshold (as suggested in the CURL docs)

Fixes: #14215
4 years agoimport: don't complain if FS_NOCOW_FL is not available
Lennart Poettering [Mon, 20 Jan 2020 20:10:31 +0000 (21:10 +0100)] 
import: don't complain if FS_NOCOW_FL is not available

Let's downgrade the log message to LOG_DEBUG if triggered by an fs that
doesn't support the flag.

4 years agoupdate TODO 14368/head
Lennart Poettering [Tue, 10 Dec 2019 22:47:06 +0000 (23:47 +0100)] 
update TODO

4 years agoci: add dependencies for repart + cryptsetup's pkcs#11 support
Lennart Poettering [Tue, 17 Dec 2019 18:19:02 +0000 (19:19 +0100)] 
ci: add dependencies for repart + cryptsetup's pkcs#11 support

Let's make sure we can test systemd-repart properly

(And while we are at it, also test cryptsetup-pkcs#11)

4 years agoman: document systemd-repart
Lennart Poettering [Tue, 17 Dec 2019 12:47:21 +0000 (13:47 +0100)] 
man: document systemd-repart

4 years agotest: add repart test
Lennart Poettering [Mon, 16 Dec 2019 16:32:44 +0000 (17:32 +0100)] 
test: add repart test

4 years agounits: add unit file for systemd-repart to automatically run at boot
Lennart Poettering [Thu, 12 Dec 2019 16:06:06 +0000 (17:06 +0100)] 
units: add unit file for systemd-repart to automatically run at boot

4 years agomkosi: modernize
Lennart Poettering [Thu, 12 Dec 2019 16:05:56 +0000 (17:05 +0100)] 
mkosi: modernize

Fedora minimization had some effect, hence add some required
dependencies explicitly so that we work anyway.

Also, the libtool is not used anymore, drop it.

Finally, the mkosi output format is called gpt_ext4 now, not raw_ext4
anymore.

4 years agorepart: add new systemd-repart tool
Lennart Poettering [Tue, 10 Dec 2019 20:31:41 +0000 (21:31 +0100)] 
repart: add new systemd-repart tool

Fixes: #14052
4 years agoconf-parser: add parser for 32bit signed integers
Lennart Poettering [Tue, 10 Dec 2019 20:32:10 +0000 (21:32 +0100)] 
conf-parser: add parser for 32bit signed integers

4 years agolocale-util: add special glyph Σ
Lennart Poettering [Tue, 10 Dec 2019 20:26:47 +0000 (21:26 +0100)] 
locale-util: add special glyph Σ

4 years agolocale-util: add block drawing special glyphs
Lennart Poettering [Tue, 10 Dec 2019 20:30:09 +0000 (21:30 +0100)] 
locale-util: add block drawing special glyphs

4 years agoformat-table: add support for formatting uuids/id128 values
Lennart Poettering [Tue, 10 Dec 2019 20:28:16 +0000 (21:28 +0100)] 
format-table: add support for formatting uuids/id128 values

4 years agoid128: move make_v4_uuid into id128-util.h to make it generally useful
Lennart Poettering [Tue, 10 Dec 2019 10:32:59 +0000 (11:32 +0100)] 
id128: move make_v4_uuid into id128-util.h to make it generally useful

4 years agomakefs: simplify SPDX header
Lennart Poettering [Tue, 10 Dec 2019 20:31:54 +0000 (21:31 +0100)] 
makefs: simplify SPDX header

4 years agotest: add test for https://github.com/systemd/systemd/issues/14560 14595/head
Lennart Poettering [Mon, 20 Jan 2020 13:40:44 +0000 (14:40 +0100)] 
test: add test for https://github.com/systemd/systemd/issues/14560

4 years agocore: make sure StandardInput=file: doesn't get dup'ed to stdout/stderr by default
Lennart Poettering [Fri, 17 Jan 2020 11:41:53 +0000 (12:41 +0100)] 
core: make sure StandardInput=file: doesn't get dup'ed to stdout/stderr by default

Fixes: #14560
4 years agounits: drop full paths for utilities in $PATH
Zbigniew Jędrzejewski-Szmek [Wed, 18 Dec 2019 08:14:57 +0000 (09:14 +0100)] 
units: drop full paths for utilities in $PATH

This makes things a bit simpler and the build a bit faster, because we don't
have to rewrite files to do the trivial substitution. @rootbindir@ is always in
our internal $PATH that we use for non-absolute paths, so there should be no
functional change.

4 years agoItalian: language update
Daniele Medri [Sun, 19 Jan 2020 10:58:21 +0000 (11:58 +0100)] 
Italian: language update

4 years agopkgconf: add full generator paths
Sascha Dewald [Sat, 18 Jan 2020 08:17:57 +0000 (08:17 +0000)] 
pkgconf: add full generator paths

4 years agotree-wide: we forgot to destroy some bus errors
Lennart Poettering [Fri, 17 Jan 2020 14:37:56 +0000 (15:37 +0100)] 
tree-wide: we forgot to destroy some bus errors

4 years agoMerge pull request #14596 from poettering/no-mask-perpetual
Zbigniew Jędrzejewski-Szmek [Sat, 18 Jan 2020 09:17:10 +0000 (10:17 +0100)] 
Merge pull request #14596 from poettering/no-mask-perpetual

core: don't allow perpetual units to be masked

4 years agotypo: "May modify to" -> "May modify"
Wieland Hoffmann [Sat, 18 Jan 2020 07:38:29 +0000 (08:38 +0100)] 
typo: "May modify to" -> "May modify"

4 years agoMerge pull request #14590 from poettering/doc-fixlets
Zbigniew Jędrzejewski-Szmek [Fri, 17 Jan 2020 14:23:02 +0000 (15:23 +0100)] 
Merge pull request #14590 from poettering/doc-fixlets

A bunch of documentation fixes

4 years agomount: make checks on perpetual mount units more lax 14596/head
Lennart Poettering [Fri, 17 Jan 2020 14:09:01 +0000 (15:09 +0100)] 
mount: make checks on perpetual mount units more lax

We don#t really care where perpetual mounts are mounted from, since they
have to exist since before we run anyway.

4 years agocore: never allow perpetual units to be masked
Lennart Poettering [Fri, 17 Jan 2020 14:02:13 +0000 (15:02 +0100)] 
core: never allow perpetual units to be masked

Fixes: #14550
4 years agoMerge pull request #14592 from keszybz/simplifications
Lennart Poettering [Fri, 17 Jan 2020 11:27:48 +0000 (12:27 +0100)] 
Merge pull request #14592 from keszybz/simplifications

Simplifications

4 years agoman: document that WakeSystem= affects clock choice 14590/head
Lennart Poettering [Thu, 16 Jan 2020 18:40:51 +0000 (19:40 +0100)] 
man: document that WakeSystem= affects clock choice

Fixes: #8308
4 years agodocs: uppercase are headers
Lennart Poettering [Thu, 16 Jan 2020 18:30:01 +0000 (19:30 +0100)] 
docs: uppercase are headers

We do this in most cases, do so here too.

4 years agodocs: let's reduce our spurious whitespace a bit
Lennart Poettering [Thu, 16 Jan 2020 18:29:49 +0000 (19:29 +0100)] 
docs: let's reduce our spurious whitespace a bit

4 years agodocs: in PORTABILITY_AND_STABILITY only use one h1
Lennart Poettering [Thu, 16 Jan 2020 18:27:19 +0000 (19:27 +0100)] 
docs: in PORTABILITY_AND_STABILITY only use one h1

According to the designer of the page layout a page only should have one
h1 header, and everything else should be h2, h3, … I think that makes a
ton of sense, hence let's downgrade some headers here.

4 years agoman: clarify that user rlimits cannot go beyond limits set for service mgr
Lennart Poettering [Thu, 16 Jan 2020 18:22:30 +0000 (19:22 +0100)] 
man: clarify that user rlimits cannot go beyond limits set for service mgr

Fixes: #10758
4 years agoman: extend on halt documentation
Lennart Poettering [Thu, 16 Jan 2020 18:01:05 +0000 (19:01 +0100)] 
man: extend on halt documentation

Based on the suggestions on #13254 and #13264

Fixes: #13254
4 years agoman: document that rootflags= does not override /etc/fstab
Lennart Poettering [Thu, 16 Jan 2020 17:51:19 +0000 (18:51 +0100)] 
man: document that rootflags= does not override /etc/fstab

Fixes: #13324
4 years agoman: underline that AccuracySec= is about coalescing timer events, nothing else
Lennart Poettering [Thu, 16 Jan 2020 15:47:56 +0000 (16:47 +0100)] 
man: underline that AccuracySec= is about coalescing timer events, nothing else

Fixes: #13328
4 years agoman: mention that Before= doesn't work for device units
Lennart Poettering [Thu, 16 Jan 2020 15:41:29 +0000 (16:41 +0100)] 
man: mention that Before= doesn't work for device units

Fixes: #13362
4 years agoman: suggest SYSTEMD_WANTS usage instead of RUN for long running processes
Lennart Poettering [Thu, 16 Jan 2020 15:36:33 +0000 (16:36 +0100)] 
man: suggest SYSTEMD_WANTS usage instead of RUN for long running processes

Fixes: #14259
4 years agoman: document the limits of the block device discovery for IO cgroup options
Lennart Poettering [Thu, 16 Jan 2020 15:29:01 +0000 (16:29 +0100)] 
man: document the limits of the block device discovery for IO cgroup options

Fixes: #14271
4 years agoman: document how error propagation to path units works
Lennart Poettering [Thu, 16 Jan 2020 15:13:50 +0000 (16:13 +0100)] 
man: document how error propagation to path units works

Fixes: #14331
4 years agoman: document that program invocation will fail if the User= does not exist
Lennart Poettering [Thu, 16 Jan 2020 11:14:03 +0000 (12:14 +0100)] 
man: document that program invocation will fail if the User= does not exist

Fixes: #14565
4 years agodocs: clarify that we don't want to own $BOOT exclusively
Lennart Poettering [Thu, 16 Jan 2020 11:09:29 +0000 (12:09 +0100)] 
docs: clarify that we don't want to own $BOOT exclusively

Let's be clearer here.

Prompted by a quick discussion I had with @gicmo.

4 years agocore: reduce indentation a bit 14592/head
Zbigniew Jędrzejewski-Szmek [Wed, 15 Jan 2020 10:42:40 +0000 (11:42 +0100)] 
core: reduce indentation a bit

4 years agologind: use loop instead of repeated code
Zbigniew Jędrzejewski-Szmek [Wed, 15 Jan 2020 10:37:49 +0000 (11:37 +0100)] 
logind: use loop instead of repeated code

https://github.com/systemd/systemd/pull/14096#discussion_r350953689

4 years agoshared/user-record-nss: use macro to avoid repeats
Zbigniew Jędrzejewski-Szmek [Wed, 15 Jan 2020 09:37:18 +0000 (10:37 +0100)] 
shared/user-record-nss: use macro to avoid repeats

It's easier to read when each field is intialized in exactly one place.

4 years agoshared/user-record-nss: shorten code a bit
Zbigniew Jędrzejewski-Szmek [Wed, 15 Jan 2020 09:04:30 +0000 (10:04 +0100)] 
shared/user-record-nss: shorten code a bit

free_and_strdup() already does comparison internally.

4 years agoDisable reading SystemdOptions EFI Var when in SecureBoot mode
Arian van Putten [Wed, 15 Jan 2020 16:10:11 +0000 (17:10 +0100)] 
Disable reading SystemdOptions EFI Var when in SecureBoot mode

In SecureBoot mode this is probably not what you want. As your cmdline
is cryptographically signed like when using Type #2 EFI Unified Kernel
Images (https://systemd.io/BOOT_LOADER_SPECIFICATION/) The user's
intention is then that the cmdline should not be modified.  You want to
make sure that the system starts up as exactly specified in the signed
artifact.

4 years agoMerge pull request #14585 from keszybz/sysctl-downgrade-messages
Lennart Poettering [Thu, 16 Jan 2020 17:45:29 +0000 (18:45 +0100)] 
Merge pull request #14585 from keszybz/sysctl-downgrade-messages

Downgrade sysctl message to log_debug in containers

4 years agoClarify journald.conf MaxLevelStore documentation
Luca Boccassi [Thu, 16 Jan 2020 16:24:07 +0000 (16:24 +0000)] 
Clarify journald.conf MaxLevelStore documentation

'stored on disk' gives the impression that this option affects only
permanent storage, even though it affects everything the journal
records, regardless of the storage type.
Use 'stored in the journal' to avoid confusion.

4 years agosysctl: downgrade message when we have no permission 14585/head
Zbigniew Jędrzejewski-Szmek [Thu, 16 Jan 2020 13:45:28 +0000 (14:45 +0100)] 
sysctl: downgrade message when we have no permission

We need to run sysctl also in containers, because the network
subtree is namespaces and may legitimately be writable. But logging
all "errors" at notice level creates unwanted noise.

Also downgrade message about missing sysctls to log_info. This might also be
relatively common when configuration is targeted at different kernel
versions. With log_debug it'll still end up in the logs, but isn't really worth
of "notice" most of the time.

https://bugzilla.redhat.com/show_bug.cgi?id=1609806

4 years agosysctl: move hashmap allocation out of main function
Zbigniew Jędrzejewski-Szmek [Thu, 16 Jan 2020 12:05:32 +0000 (13:05 +0100)] 
sysctl: move hashmap allocation out of main function

This allocation is a low level detail, and it seems nicer to keep it
out of run().

4 years agoman: rework section about configuration file precedence
Zbigniew Jędrzejewski-Szmek [Thu, 16 Jan 2020 13:10:18 +0000 (14:10 +0100)] 
man: rework section about configuration file precedence

This section is loaded in a bunch of places, so this affects many
man pages.

1. point the reader to the synopsis section, which has the exact paths
that are used to load files.
2. put the "reference" part first, and recommendations later, in separate
paragraphs.
3. describe how individual settings and whole files are replaces.

Closes #12791.

4 years agoMerge pull request #14581 from poettering/setcred-alternative-fix
Zbigniew Jędrzejewski-Szmek [Thu, 16 Jan 2020 08:53:26 +0000 (09:53 +0100)] 
Merge pull request #14581 from poettering/setcred-alternative-fix

alternative pam_setcred() fix

4 years agocore: on each iteration processing /proc/self/mountinfo merge all discovery flags...
Lennart Poettering [Tue, 14 Jan 2020 15:25:45 +0000 (16:25 +0100)] 
core: on each iteration processing /proc/self/mountinfo merge all discovery flags for each path

This extends on d253a45e1c147f5174265d71d7419da7bd52a88b, and instead of
merging just a single flag from previous mount entries of
/proc/self/mountinfo for the same path we merge all three.

This shouldn't change behaviour, but I think make things more readable.

Previously we'd set MOUNT_PROC_IS_MOUNTED unconditionally, we still do.

Previously we'd inherit MOUNT_PROC_JUST_MOUNTED from a previous entry on
the same line, we still do.

MOUNT_PROC_JUST_CHANGED should generally stay set too. Why that? If we
have two mount entries on the same mount point we'd first process one
and then the other, and the almost certainly different mount parameters
of the two would mean we'd set MOUNT_PROC_JUST_CHANGED for the second.
And with this we'll definitely do that still.

This also adds a comment explaining the situation a bit, and why we get
into this situation.

4 years agoMerge pull request #14375 from poettering/userdb
Lennart Poettering [Wed, 15 Jan 2020 16:41:29 +0000 (17:41 +0100)] 
Merge pull request #14375 from poettering/userdb

New varlink API for user and group management

4 years agoexecute: allow pam_setcred() to fail, ignore errors 14581/head
Lennart Poettering [Wed, 15 Jan 2020 16:09:36 +0000 (17:09 +0100)] 
execute: allow pam_setcred() to fail, ignore errors

Fixes: #14567
Alternative-To: #14569
4 years agoexecute: add const to array parameters, where possible
Lennart Poettering [Wed, 15 Jan 2020 16:08:25 +0000 (17:08 +0100)] 
execute: add const to array parameters, where possible

4 years agodocs: add documentation for the varlink user/group APIs 14375/head
Lennart Poettering [Wed, 28 Aug 2019 17:36:01 +0000 (19:36 +0200)] 
docs: add documentation for the varlink user/group APIs

4 years agodocs: add documentation for JSON group records, too
Lennart Poettering [Fri, 29 Nov 2019 20:51:55 +0000 (21:51 +0100)] 
docs: add documentation for JSON group records, too

4 years agodocs: add documentation for JSON user records
Lennart Poettering [Tue, 27 Aug 2019 13:57:33 +0000 (15:57 +0200)] 
docs: add documentation for JSON user records

4 years agoman: document the new nss-systemd behaviour
Lennart Poettering [Tue, 19 Nov 2019 15:51:27 +0000 (16:51 +0100)] 
man: document the new nss-systemd behaviour

(This also changes the suggested /etc/nsswitch.conf line to use for
hooking up nss-system to use glibc's [SUCCESS=merge] feature so that we
can properly merge group membership lists).