]> git.ipfire.org Git - thirdparty/git.git/commit
completion: bash: add correct suffix in variables
authorFelipe Contreras <felipe.contreras@gmail.com>
Mon, 16 Aug 2021 09:10:25 +0000 (04:10 -0500)
committerJunio C Hamano <gitster@pobox.com>
Wed, 18 Aug 2021 18:17:26 +0000 (11:17 -0700)
commitbe6444d1ca96fdd702b383de860e243aa7e65619
tree50f85c6cce178db17842658bfd00ced1f84eafe7
parentf3cc916acc2e0f92c05e07c82c83b370e7d31247
completion: bash: add correct suffix in variables

__gitcomp automatically adds a suffix, but __gitcomp_nl and others
don't, we need to specify a space by default.

Can be tested with:

  git config branch.autoSetupMe<tab>

This fix only works for versions of bash greater than 4.0, before that
"local sfx" creates an empty string, therefore the unset expansion
doesn't work. The same happens in zsh.

Therefore we don't add the test for that for now.

The correct fix for all shells requires semantic changes in __gitcomp,
but that can be done later.

Cc: SZEDER Gábor <szeder.dev@gmail.com>
Tested-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/completion/git-completion.bash