From f46e8298ad63e3fa559dd9d9d7981e224cc5a64b Mon Sep 17 00:00:00 2001 From: Adolf Belka Date: Thu, 27 Jul 2023 15:57:25 +0200 Subject: [PATCH] ovpnmain.cgi: Fixes bug#13190 - connection status shows disconnected for connected client - If the certificate name has underscores in it then the status always shows as DISCONNECTED alothough the actual connection is working and can be used. - The certificate with underscores works fine. RFC5280 accepts underscores in the name. - The code for checking the status splits up the status message and takes the first part as the common name for the connection. Then there is a regex command which rerplaces any underscores in the status common name with spaces. This results in the connection with underscores in the certificate name never matching any status feedback common name as the underscores have been replaced by spaces. - This has been tested to work with my vm test bed. With existing code the connection with underscores in the certificate name permanently showed DISCONNECTED. With the code change the connection shows as CONNECTED very quickly. Fixes: Bug#13190 Tested-by: Adolf Belka Signed-off-by: Adolf Belka Signed-off-by: Michael Tremer --- html/cgi-bin/ovpnmain.cgi | 1 - 1 file changed, 1 deletion(-) diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi index f734331faa..5afe54f558 100755 --- a/html/cgi-bin/ovpnmain.cgi +++ b/html/cgi-bin/ovpnmain.cgi @@ -5502,7 +5502,6 @@ END if ($match[1] ne "Common Name") { $cn = $match[1]; } - $cn =~ s/[_]/ /g; if ($cn eq "$confighash{$key}[2]") { $col1="bgcolor='${Header::colourgreen}'"; $active = "$Lang::tr{'capsopen'}"; -- 2.39.2