]> git.ipfire.org Git - ipfire-2.x.git/commit - src/initscripts/networking/any
Deleted 'vnstat' calls in initscripts - those options were removed and we're using...
authorMatthias Fischer <matthias.fischer@ipfire.org>
Thu, 7 Apr 2022 16:46:54 +0000 (18:46 +0200)
committerPeter Müller <peter.mueller@ipfire.org>
Sun, 10 Apr 2022 09:53:49 +0000 (09:53 +0000)
commit5806ff0cc5af4b361b3e32cb9e32d97d1f07d400
treeae28ae367a41fd8037d4ed0b059838f54924f822
parent18ed846002a02d51a9122133dc2314cbb6d5b04e
Deleted 'vnstat' calls in initscripts - those options were removed and we're using 'vnstatd', not 'vnstat'.

Fixes: 12831
Jonatan Schlag reported that the command line options of 'vnstat' had changed
"...and seemed to be broken a long time".
=> https://bugzilla.ipfire.org/show_bug.cgi?id=12831#c0

Several command line switches used in networking initscripts were obviously removed.

Affected commands in '.../networking/any' and '.../networking/red'):

...
/usr/bin/vnstat -u -i ${DEVICE} -r --enable --force > /dev/null 2>&1
...
/usr/bin/vnstat -u -i ${DEVICE} -r --disable > /dev/null 2>&1
...

and
...
/usr/bin/vnstat -u -i ppp0 -r --disable > /dev/null 2>&1
...

Adolf Belka tested this, "looked through the changelogs" and found - besides that
the switch '--enable' had been removed "in version 2.0 in 2018" - that '--enable', '--update'
and '--reset' switches are either not needed or not supported anymore.
"The old man page indicates that none of those options are used when the vnstat daemon
is running."

Since we only start and run 'vnstatd' in IPFire it was decided to remove these commands.

Reported-by: jonatan.schlag <jonatan.schlag@ipfire.org>
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
src/initscripts/networking/any
src/initscripts/networking/red