From 9dd2a4635fbc9d3da96c7916cd0bf2d5cd24d145 Mon Sep 17 00:00:00 2001
From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 26 Mar 2024 15:08:01 +0000
Subject: [PATCH] IPS: Fix how we show EOL providers

There is no need to add a legend as I find it confusing. The change that
people are using an EOL is rather slim and so I don't to waste space.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 doc/language_issues.de |  2 ++
 doc/language_issues.en |  1 +
 doc/language_issues.es |  1 +
 doc/language_issues.fr |  1 +
 doc/language_issues.it |  1 +
 doc/language_issues.nl |  1 +
 doc/language_issues.pl |  1 +
 doc/language_issues.ru |  1 +
 doc/language_issues.tr |  1 +
 doc/language_missings  | 15 +++++++++++++++
 html/cgi-bin/ids.cgi   | 36 ++++++++++++++----------------------
 langs/en/cgi-bin/en.pl |  1 +
 12 files changed, 40 insertions(+), 22 deletions(-)

diff --git a/doc/language_issues.de b/doc/language_issues.de
index 46fb9ee5a0..1ba77c94d2 100644
--- a/doc/language_issues.de
+++ b/doc/language_issues.de
@@ -384,6 +384,7 @@ WARNING: translation string unused: icmp type
 WARNING: translation string unused: id
 WARNING: translation string unused: ids oinkcode required
 WARNING: translation string unused: ids rules update
+WARNING: translation string unused: ids unsupported provider
 WARNING: translation string unused: ike encryption
 WARNING: translation string unused: ike grouptype
 WARNING: translation string unused: ike integrity
@@ -927,6 +928,7 @@ WARNING: untranslated string: guardian service = unknown string
 WARNING: untranslated string: hostile networks in = From Hostile Networks
 WARNING: untranslated string: hostile networks out = To Hostile Networks
 WARNING: untranslated string: hostile networks total = Total Hostile Networks
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: ids subscription code required = The selected ruleset requires a subscription code
 WARNING: untranslated string: invalid input for subscription code = Invalid input for subscription code
 WARNING: untranslated string: ipsec dns server address is invalid = Invalid DNS server IP address(es)
diff --git a/doc/language_issues.en b/doc/language_issues.en
index 2eca62e606..84bc8cdb08 100644
--- a/doc/language_issues.en
+++ b/doc/language_issues.en
@@ -1079,6 +1079,7 @@ WARNING: untranslated string: ids monitored interfaces = Monitored Interfaces
 WARNING: untranslated string: ids no enabled ruleset provider = No enabled ruleset is available. Please activate or add one first.
 WARNING: untranslated string: ids no network zone = Please select at least one network zone to be monitored
 WARNING: untranslated string: ids provider = Provider
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: ids provider settings = Provider settings
 WARNING: untranslated string: ids remove rule structures = Remove old rule structures...
 WARNING: untranslated string: ids reset provider = Reset provider
diff --git a/doc/language_issues.es b/doc/language_issues.es
index ff5434e05d..25ef7f9c57 100644
--- a/doc/language_issues.es
+++ b/doc/language_issues.es
@@ -993,6 +993,7 @@ WARNING: untranslated string: hardware vulnerabilities = Hardware Vulnerabilitie
 WARNING: untranslated string: hostile networks in = From Hostile Networks
 WARNING: untranslated string: hostile networks out = To Hostile Networks
 WARNING: untranslated string: hostile networks total = Total Hostile Networks
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: info messages = unknown string
 WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: log drop hostile in = Log dropped packets FROM hostile networks
diff --git a/doc/language_issues.fr b/doc/language_issues.fr
index 395afd9982..7aafc3053e 100644
--- a/doc/language_issues.fr
+++ b/doc/language_issues.fr
@@ -944,6 +944,7 @@ WARNING: untranslated string: guardian logtarget_syslog = unknown string
 WARNING: untranslated string: guardian no entries = unknown string
 WARNING: untranslated string: guardian service = unknown string
 WARNING: untranslated string: hostile networks total = Total Hostile Networks
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: pakfire ago = ago.
 WARNING: untranslated string: routing config added = unknown string
 WARNING: untranslated string: routing config changed = unknown string
diff --git a/doc/language_issues.it b/doc/language_issues.it
index d9bad7f14c..7498e2af18 100644
--- a/doc/language_issues.it
+++ b/doc/language_issues.it
@@ -1095,6 +1095,7 @@ WARNING: untranslated string: ids monitored interfaces = Monitored Interfaces
 WARNING: untranslated string: ids no enabled ruleset provider = No enabled ruleset is available. Please activate or add one first.
 WARNING: untranslated string: ids no network zone = Please select at least one network zone to be monitored
 WARNING: untranslated string: ids provider = Provider
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: ids provider settings = Provider settings
 WARNING: untranslated string: ids remove rule structures = Remove old rule structures...
 WARNING: untranslated string: ids reset provider = Reset provider
diff --git a/doc/language_issues.nl b/doc/language_issues.nl
index b93cc1cd19..16e69bf270 100644
--- a/doc/language_issues.nl
+++ b/doc/language_issues.nl
@@ -1100,6 +1100,7 @@ WARNING: untranslated string: ids monitored interfaces = Monitored Interfaces
 WARNING: untranslated string: ids no enabled ruleset provider = No enabled ruleset is available. Please activate or add one first.
 WARNING: untranslated string: ids no network zone = Please select at least one network zone to be monitored
 WARNING: untranslated string: ids provider = Provider
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: ids provider settings = Provider settings
 WARNING: untranslated string: ids remove rule structures = Remove old rule structures...
 WARNING: untranslated string: ids reset provider = Reset provider
diff --git a/doc/language_issues.pl b/doc/language_issues.pl
index ab220103f5..31c64c1645 100644
--- a/doc/language_issues.pl
+++ b/doc/language_issues.pl
@@ -1240,6 +1240,7 @@ WARNING: untranslated string: ids monitored interfaces = Monitored Interfaces
 WARNING: untranslated string: ids no enabled ruleset provider = No enabled ruleset is available. Please activate or add one first.
 WARNING: untranslated string: ids no network zone = Please select at least one network zone to be monitored
 WARNING: untranslated string: ids provider = Provider
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: ids provider settings = Provider settings
 WARNING: untranslated string: ids remove rule structures = Remove old rule structures...
 WARNING: untranslated string: ids reset provider = Reset provider
diff --git a/doc/language_issues.ru b/doc/language_issues.ru
index 533b21a0dc..9495d951eb 100644
--- a/doc/language_issues.ru
+++ b/doc/language_issues.ru
@@ -1237,6 +1237,7 @@ WARNING: untranslated string: ids monitored interfaces = Monitored Interfaces
 WARNING: untranslated string: ids no enabled ruleset provider = No enabled ruleset is available. Please activate or add one first.
 WARNING: untranslated string: ids no network zone = Please select at least one network zone to be monitored
 WARNING: untranslated string: ids provider = Provider
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: ids provider settings = Provider settings
 WARNING: untranslated string: ids remove rule structures = Remove old rule structures...
 WARNING: untranslated string: ids reset provider = Reset provider
diff --git a/doc/language_issues.tr b/doc/language_issues.tr
index d9caa290e4..a2c134a2ac 100644
--- a/doc/language_issues.tr
+++ b/doc/language_issues.tr
@@ -1037,6 +1037,7 @@ WARNING: untranslated string: ids monitored interfaces = Monitored Interfaces
 WARNING: untranslated string: ids no enabled ruleset provider = No enabled ruleset is available. Please activate or add one first.
 WARNING: untranslated string: ids no network zone = Please select at least one network zone to be monitored
 WARNING: untranslated string: ids provider = Provider
+WARNING: untranslated string: ids provider eol = (EOL)
 WARNING: untranslated string: ids provider settings = Provider settings
 WARNING: untranslated string: ids remove rule structures = Remove old rule structures...
 WARNING: untranslated string: ids reset provider = Reset provider
diff --git a/doc/language_missings b/doc/language_missings
index 65d69daee3..44d79f352a 100644
--- a/doc/language_missings
+++ b/doc/language_missings
@@ -62,6 +62,7 @@
 < hostile networks out
 < hostile networks total
 < ids automatic rules update
+< ids provider eol
 < ids subscription code required
 < insert removable device
 < invalid input for subscription code
@@ -123,6 +124,8 @@
 < hostile networks in
 < hostile networks out
 < hostile networks total
+< ids provider eol
+< ids unsupported provider
 < invalid ip or hostname
 < log drop hostile in
 < log drop hostile out
@@ -148,6 +151,8 @@
 < g.dtm
 < g.lite
 < hostile networks total
+< ids provider eol
+< ids unsupported provider
 < system time
 < timeformat
 < upload fcdsl.o
@@ -398,6 +403,7 @@
 < ids no enabled ruleset provider
 < ids no network zone
 < ids provider
+< ids provider eol
 < ids provider settings
 < ids remove rule structures
 < ids reset provider
@@ -408,6 +414,7 @@
 < ids subscription code required
 < ids the choosen provider is already in use
 < ids unable to download the ruleset
+< ids unsupported provider
 < ids visit provider website
 < ids working
 < incoming compression in bytes per second
@@ -924,6 +931,7 @@
 < ids no enabled ruleset provider
 < ids no network zone
 < ids provider
+< ids provider eol
 < ids provider settings
 < ids remove rule structures
 < ids reset provider
@@ -934,6 +942,7 @@
 < ids subscription code required
 < ids the choosen provider is already in use
 < ids unable to download the ruleset
+< ids unsupported provider
 < ids visit provider website
 < ids working
 < imei
@@ -1755,6 +1764,7 @@
 < ids no enabled ruleset provider
 < ids no network zone
 < ids provider
+< ids provider eol
 < ids provider settings
 < ids remove rule structures
 < ids reset provider
@@ -1765,6 +1775,7 @@
 < ids subscription code required
 < ids the choosen provider is already in use
 < ids unable to download the ruleset
+< ids unsupported provider
 < ids visit provider website
 < ids working
 < imei
@@ -2754,6 +2765,7 @@
 < ids no enabled ruleset provider
 < ids no network zone
 < ids provider
+< ids provider eol
 < ids provider settings
 < ids remove rule structures
 < ids reset provider
@@ -2764,6 +2776,7 @@
 < ids subscription code required
 < ids the choosen provider is already in use
 < ids unable to download the ruleset
+< ids unsupported provider
 < ids visit provider website
 < ids working
 < imei
@@ -3345,6 +3358,7 @@
 < ids no enabled ruleset provider
 < ids no network zone
 < ids provider
+< ids provider eol
 < ids provider settings
 < ids remove rule structures
 < ids reset provider
@@ -3355,6 +3369,7 @@
 < ids subscription code required
 < ids the choosen provider is already in use
 < ids unable to download the ruleset
+< ids unsupported provider
 < ids visit provider website
 < ids working
 < inodes
diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index edab971953..8ace30b02a 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -1173,8 +1173,8 @@ END
 
 				# Handle providers which are not longer supported.
 				unless ($IDS::Ruleset::Providers{$provider}{'dl_url'}) {
-					# Mark this provider as unsupported.
-					$unsupported = "<img src='/blob.gif' alt='*'>";
+					$col = "bgcolor='$Header::colouryellow'";
+					$unsupported = $Lang::tr{'ids provider eol'};
 				}
 
 				# Choose icons for the checkboxes.
@@ -1203,7 +1203,7 @@ END
 
 print <<END;
 				<tr>
-					<td width='33%' class='base' $col>$provider_name$unsupported</td>
+					<td width='33%' class='base' $col>$provider_name $unsupported</td>
 					<td width='30%' class='base' $col>$rulesetdate</td>
 
 					<td align='center' $col>
@@ -1254,32 +1254,24 @@ END
 	print "</table>\n";
 
 	# Section to add new elements or edit existing ones.
-print <<END;
+	print <<END;
 	<br>
 	<hr>
 	<br>
 
-	<table width='100%'>
-		<form method='post' action='$ENV{'SCRIPT_NAME'}'>
-			<tr>
-				<td>
-END
-					print "<img src='/blob.gif' alt='*'> $Lang::tr{'ids unsupported provider'}\n";
-print <<END;
-				</td>
-				<td><div align='right'>
+	<form method='post' action='$ENV{'SCRIPT_NAME'}'>
+		<div align='right'>
 END
 
-					# Only show this button if a ruleset provider is configured.
-					if (%used_providers) {
-						print "<input type='submit' name='RULESET' value='$Lang::tr{'ids customize ruleset'}'>\n";
-					}
+	# Only show this button if a ruleset provider is configured.
+	if (%used_providers) {
+		print "<input type='submit' name='RULESET' value='$Lang::tr{'ids customize ruleset'}'>\n";
+	}
+
 print <<END;
-					<input type='submit' name='PROVIDERS' value='$Lang::tr{'ids add provider'}'>
-					</div></td>
-			</tr>
-		</form>
-	</table>
+			<input type='submit' name='PROVIDERS' value='$Lang::tr{'ids add provider'}'>
+		</div>
+	</form>
 END
 
 	&Header::closebox();
diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index 8e50aba767..878c8baaa3 100644
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -1456,6 +1456,7 @@
 'ids no enabled ruleset provider' => 'No enabled ruleset is available. Please activate or add one first.',
 'ids no network zone' => 'Please select at least one network zone to be monitored',
 'ids provider' => 'Provider',
+'ids provider eol' => '(EOL)',
 'ids provider settings' => 'Provider settings',
 'ids remove rule structures' => 'Remove old rule structures...',
 'ids reset provider' => 'Reset provider',
-- 
2.39.2