]> git.ipfire.org Git - location/libloc.git/commit
location-importer: Set "is_drop" to "True" even in case of conflicts
authorPeter Müller <peter.mueller@ipfire.org>
Sat, 11 Dec 2021 18:01:54 +0000 (19:01 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Mon, 13 Dec 2021 17:46:15 +0000 (17:46 +0000)
commit148f68bf7ea1af3b6951bd75f1316c1686deaff2
tree65f0eb8cf0ebe10a0fd66ed8e92938318c2690c4
parent1714f6ee859d7abbafb277f42f7ae75c5b990973
location-importer: Set "is_drop" to "True" even in case of conflicts

Previously, any present override for a given network or ASN would have
caused the SQL statement not to conduct anything at all. Since "is_drop"
is the only flag being actually set here, it makes sense to do so in
case of already present overrides as well.

The effect of this is limited: Our own override files are always
considered at last, so in case of conflicts they will be the ultima
ratio. This is an intended behaviour, but slipped my mind when I filed
bug #12728, so this patch can only be seen as a partial solution - the
rest is not a bug, but a feature. :-)

Partially fixes: #12728

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/python/location-importer.in