]>
Commit | Line | Data |
---|---|---|
740549d8 PM |
1 | From 11e134e54d15e67a64c39a623f492a28df922517 Mon Sep 17 00:00:00 2001 |
2 | From: Jean Delvare <jdelvare@suse.de> | |
3 | Date: Tue, 19 Jan 2021 16:26:01 +0100 | |
4 | Subject: dmidecode: Fix crash with -u option | |
5 | ||
6 | A segmentation fault was reported with option -u. Turns out to be a | |
7 | stupid thinko where the buffer offset was reset at the wrong loop | |
8 | depth. | |
9 | ||
10 | Reported-by: Jerry Hoemann <jerry.hoemann@hpe.com> | |
11 | Fixes: da06888d08b9 ("dmidecode: Use the print helpers in dump mode too") | |
12 | Signed-off-by: Jean Delvare <jdelvare@suse.de> | |
13 | --- | |
14 | dmidecode.c | 2 +- | |
15 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
16 | ||
17 | diff --git a/dmidecode.c b/dmidecode.c | |
18 | index 572cb1a..69ea0e8 100644 | |
19 | --- a/dmidecode.c | |
20 | +++ b/dmidecode.c | |
21 | @@ -248,9 +248,9 @@ static void dmi_dump(const struct dmi_header *h) | |
22 | { | |
23 | int j, l = strlen(s) + 1; | |
24 | ||
25 | - off = 0; | |
26 | for (row = 0; row < ((l - 1) >> 4) + 1; row++) | |
27 | { | |
28 | + off = 0; | |
29 | for (j = 0; j < 16 && j < l - (row << 4); j++) | |
30 | off += sprintf(raw_data + off, | |
31 | j ? " %02X" : "%02X", | |
32 | -- | |
33 | cgit v1.2.1 | |
34 |