]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/commit - doc/language_missings
dhcp.cgi: Fix bug#10629 - Highlight fixed IP's in dynamic range in red
authorAdolf Belka <adolf.belka@ipfire.org>
Thu, 2 Mar 2023 14:11:23 +0000 (15:11 +0100)
committerPeter Müller <peter.mueller@ipfire.org>
Sat, 4 Mar 2023 13:41:21 +0000 (13:41 +0000)
commitb52a84ddc77f9db7e4ad7b129f21fbf528c6f990
tree664bb11867f8b3bbd25fc2b6801c0763ec987b84
parentde4dea96aa9a45785e7bb64aadf14f97cfc1a359
dhcp.cgi: Fix bug#10629 - Highlight fixed IP's in dynamic range in red

- This v2 patch has moved the extraHead variable into header.pl
- This patch marks all IP's that are in the Fixed list but are also in the dynamic range
   that has been defined, in red.
- Additional function created to check if an ip address is in a defined range.
- Added an additional key item under the Fixed Leases table for Fixed IP in dynamic range
- Added line to English Language file for this key item.
- ./make lang run before commit.
- Tested in vm testbed and confirmed that any ip address in the Fixed Leases table that
   is in the defined dynamic range is highlighted in red
- This uses the css background-color appoach from the first patch in this set.
- This patch only highlights those IP's that overlap in red but does nothing more. So a
   user can still create new ones if they want but they will all show up in red.
- This patch flags up if people are doing things that they shouldn't be doing but allows
   them to continue doing so without changing anything if they don't want to and so will
   not break existing setups.

Fixes: Bug#10629
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch@ipfire.org>
14 files changed:
config/cfgroot/header.pl
config/cfgroot/network-functions.pl
doc/language_issues.de
doc/language_issues.en
doc/language_issues.es
doc/language_issues.fr
doc/language_issues.it
doc/language_issues.nl
doc/language_issues.pl
doc/language_issues.ru
doc/language_issues.tr
doc/language_missings
html/cgi-bin/dhcp.cgi
langs/en/cgi-bin/en.pl