]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/ChangeLog
nat/amd64-linux-siginfo.c: Move align attribute from typedef to struct
authorPedro Alves <pedro@palves.net>
Fri, 4 Jun 2021 20:44:36 +0000 (21:44 +0100)
committerPedro Alves <pedro@palves.net>
Mon, 7 Jun 2021 22:22:07 +0000 (23:22 +0100)
commitd8ca8e9facb184d67ce1aca9196ed8446e7e2a09
tree70da82003101080ff658a50b45fdd91c41bc1803
parentcfc75767cc276fb9e10c8239bb23c800a7f07e47
nat/amd64-linux-siginfo.c: Move align attribute from typedef to struct

Compiling GDB with current git Clang (future 13) fails with (among
other problems), this issue:

 $ make nat/amd64-linux-siginfo.o
   CXX    nat/amd64-linux-siginfo.o
 src/gdb/nat/amd64-linux-siginfo.c:590:35: warning: passing 4-byte aligned argument to 8-byte aligned parameter 1 of 'compat_x32_siginfo_from_siginfo' may result in an unaligned pointer access [-Walign-mismatch]
 compat_x32_siginfo_from_siginfo ((struct compat_x32_siginfo *) inf,
  ^
 1 warning generated.

The problem is that:

  - The flagged code is casting to "struct compat_x32_siginfo" pointer
    directly instead of to a pointer to the compat_x32_siginfo_t
    typedef.  The called function is declared with a
    compat_x32_siginfo_t typedef pointer parameter.

  - Only the typedef has the __aligned__ attribute.

Fix this by moving the attribute to the struct, so both struct and
typedef have the same alignment.

The next patch removes the typedefs.

gdb/ChangeLog:
yyyy-mm-dd  Pedro Alves  <pedro@palves.net>

* nat/amd64-linux-siginfo.c (compat_x32_siginfo_t): Move
__attribute__ __aligned__ from the typedef to the struct.
gdb/ChangeLog
gdb/nat/amd64-linux-siginfo.c