]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/Makefile.in
Move readline to the readline/readline subdirectory
authorTom Tromey <tom@tromey.com>
Sat, 5 Oct 2019 22:39:44 +0000 (16:39 -0600)
committerTom Tromey <tom@tromey.com>
Wed, 23 Oct 2019 21:16:48 +0000 (15:16 -0600)
commit6999161a2a3b3cbd918570e094199184331d4f81
tree4c20bbd8c1c19e2e7ebcc55d821957e22c4ab9e8
parent12e7c35ec3c09793ed9613cdf696b9f0f4dd86ec
Move readline to the readline/readline subdirectory

readline turns out to be a bit of a stumbling block for the project to
move gdbsupport (and then gdbserver) to the top-level.

The issue is that readline headers are intended to be included with
names like "readline/readline.h".  To support this, gdb effectively
adds a -I option pointing to the top-level source directory -- but,
importantly, this option is not used when the system readline is used.

For gdbsupport, a -I option like this would always be needed, but that
in turn would break the system readline case.  This was PR build/17077,
fixed in commit a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.

Previously, we had discussed this on the gdb-patches list in terms of
removing readline from the tree

    https://sourceware.org/ml/gdb-patches/2019-09/msg00317.html

However, Eli expressed some concerns, and Joel did as well (off-list).

Given those concerns, and the fact that a patch-free local readline is
relatively new in gdb (it was locally patched for years), I changed my
mind and decided to handle this situation by moving the readline
sources down a level.

That is, upstream readline is now in readline/readline, and the
top-level readline directory just contains the minimal configury
needed to build that.

This fixes the problem because, when gdb unconditionally adds a
-I$(top_srcdir), this will not find readline headers.  A separate -I
will be needed instead, which is exactly what's needed for
--with-system-readline.

gdb/ChangeLog
2019-10-23  Tom Tromey  <tom@tromey.com>

* Makefile.in (READLINE_DIR): Update.

gdb/doc/ChangeLog
2019-10-23  Tom Tromey  <tom@tromey.com>

* Makefile.in (READLINE_DIR): Update.

readline/ChangeLog
2019-10-23  Tom Tromey  <tom@tromey.com>

Move old contents to readline/ subdirectory.
* aclocal.m4, configure, configure.ac, .gitignore, Makefile.am,
Makefile.in, README: New files.

Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
152 files changed:
gdb/ChangeLog
gdb/Makefile.in
gdb/doc/ChangeLog
gdb/doc/Makefile.in
readline/.gitignore
readline/ChangeLog [new file with mode: 0644]
readline/Makefile.am [new file with mode: 0644]
readline/Makefile.in
readline/README
readline/aclocal.m4
readline/configure
readline/configure.ac
readline/readline/.gitignore [new file with mode: 0644]
readline/readline/CHANGELOG [moved from readline/CHANGELOG with 100% similarity]
readline/readline/CHANGES [moved from readline/CHANGES with 100% similarity]
readline/readline/COPYING [moved from readline/COPYING with 100% similarity]
readline/readline/ChangeLog.gdb [moved from readline/ChangeLog.gdb with 99% similarity]
readline/readline/INSTALL [moved from readline/INSTALL with 100% similarity]
readline/readline/MANIFEST [moved from readline/MANIFEST with 100% similarity]
readline/readline/Makefile.in [new file with mode: 0644]
readline/readline/NEWS [moved from readline/NEWS with 100% similarity]
readline/readline/README [new file with mode: 0644]
readline/readline/USAGE [moved from readline/USAGE with 100% similarity]
readline/readline/aclocal.m4 [new file with mode: 0644]
readline/readline/ansi_stdlib.h [moved from readline/ansi_stdlib.h with 100% similarity]
readline/readline/bind.c [moved from readline/bind.c with 100% similarity]
readline/readline/callback.c [moved from readline/callback.c with 100% similarity]
readline/readline/chardefs.h [moved from readline/chardefs.h with 100% similarity]
readline/readline/colors.c [moved from readline/colors.c with 100% similarity]
readline/readline/colors.h [moved from readline/colors.h with 100% similarity]
readline/readline/compat.c [moved from readline/compat.c with 100% similarity]
readline/readline/complete.c [moved from readline/complete.c with 100% similarity]
readline/readline/config.h.in [moved from readline/config.h.in with 100% similarity]
readline/readline/configure [new file with mode: 0755]
readline/readline/configure.ac [new file with mode: 0644]
readline/readline/cross-build/cygwin.cache [moved from readline/cross-build/cygwin.cache with 100% similarity]
readline/readline/display.c [moved from readline/display.c with 100% similarity]
readline/readline/doc/ChangeLog.gdb [moved from readline/doc/ChangeLog.gdb with 98% similarity]
readline/readline/doc/Makefile.in [moved from readline/doc/Makefile.in with 100% similarity]
readline/readline/doc/fdl.texi [moved from readline/doc/fdl.texi with 100% similarity]
readline/readline/doc/history.3 [moved from readline/doc/history.3 with 100% similarity]
readline/readline/doc/history.texi [moved from readline/doc/history.texi with 100% similarity]
readline/readline/doc/hstech.texi [moved from readline/doc/hstech.texi with 100% similarity]
readline/readline/doc/hsuser.texi [moved from readline/doc/hsuser.texi with 100% similarity]
readline/readline/doc/readline.3 [moved from readline/doc/readline.3 with 100% similarity]
readline/readline/doc/rlman.texi [moved from readline/doc/rlman.texi with 100% similarity]
readline/readline/doc/rltech.texi [moved from readline/doc/rltech.texi with 100% similarity]
readline/readline/doc/rluser.texi [moved from readline/doc/rluser.texi with 100% similarity]
readline/readline/doc/rluserman.texi [moved from readline/doc/rluserman.texi with 100% similarity]
readline/readline/doc/texi2dvi [moved from readline/doc/texi2dvi with 100% similarity]
readline/readline/doc/texi2html [moved from readline/doc/texi2html with 100% similarity]
readline/readline/doc/version.texi [moved from readline/doc/version.texi with 100% similarity]
readline/readline/emacs_keymap.c [moved from readline/emacs_keymap.c with 100% similarity]
readline/readline/examples/ChangeLog.gdb [moved from readline/examples/ChangeLog.gdb with 87% similarity]
readline/readline/examples/Inputrc [moved from readline/examples/Inputrc with 100% similarity]
readline/readline/examples/Makefile.in [moved from readline/examples/Makefile.in with 100% similarity]
readline/readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP [moved from readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP with 100% similarity]
readline/readline/examples/autoconf/RL_LIB_READLINE_VERSION [moved from readline/examples/autoconf/RL_LIB_READLINE_VERSION with 100% similarity]
readline/readline/examples/autoconf/wi_LIB_READLINE [moved from readline/examples/autoconf/wi_LIB_READLINE with 100% similarity]
readline/readline/examples/excallback.c [moved from readline/examples/excallback.c with 100% similarity]
readline/readline/examples/fileman.c [moved from readline/examples/fileman.c with 100% similarity]
readline/readline/examples/hist_erasedups.c [moved from readline/examples/hist_erasedups.c with 100% similarity]
readline/readline/examples/hist_purgecmd.c [moved from readline/examples/hist_purgecmd.c with 100% similarity]
readline/readline/examples/histexamp.c [moved from readline/examples/histexamp.c with 100% similarity]
readline/readline/examples/manexamp.c [moved from readline/examples/manexamp.c with 100% similarity]
readline/readline/examples/readlinebuf.h [moved from readline/examples/readlinebuf.h with 100% similarity]
readline/readline/examples/rl-callbacktest.c [moved from readline/examples/rl-callbacktest.c with 100% similarity]
readline/readline/examples/rl-fgets.c [moved from readline/examples/rl-fgets.c with 100% similarity]
readline/readline/examples/rl.c [moved from readline/examples/rl.c with 100% similarity]
readline/readline/examples/rlbasic.c [moved from readline/examples/rlbasic.c with 100% similarity]
readline/readline/examples/rlcat.c [moved from readline/examples/rlcat.c with 100% similarity]
readline/readline/examples/rlevent.c [moved from readline/examples/rlevent.c with 100% similarity]
readline/readline/examples/rlfe/ChangeLog [moved from readline/examples/rlfe/ChangeLog with 96% similarity]
readline/readline/examples/rlfe/ChangeLog.gdb [moved from readline/examples/rlfe/ChangeLog.gdb with 85% similarity]
readline/readline/examples/rlfe/Makefile.in [moved from readline/examples/rlfe/Makefile.in with 100% similarity]
readline/readline/examples/rlfe/README [moved from readline/examples/rlfe/README with 100% similarity]
readline/readline/examples/rlfe/config.h.in [moved from readline/examples/rlfe/config.h.in with 100% similarity]
readline/readline/examples/rlfe/configure [moved from readline/examples/rlfe/configure with 100% similarity]
readline/readline/examples/rlfe/configure.in [moved from readline/examples/rlfe/configure.in with 100% similarity]
readline/readline/examples/rlfe/extern.h [moved from readline/examples/rlfe/extern.h with 100% similarity]
readline/readline/examples/rlfe/os.h [moved from readline/examples/rlfe/os.h with 100% similarity]
readline/readline/examples/rlfe/pty.c [moved from readline/examples/rlfe/pty.c with 100% similarity]
readline/readline/examples/rlfe/rlfe.c [moved from readline/examples/rlfe/rlfe.c with 100% similarity]
readline/readline/examples/rlfe/screen.h [moved from readline/examples/rlfe/screen.h with 100% similarity]
readline/readline/examples/rlkeymaps.c [moved from readline/examples/rlkeymaps.c with 100% similarity]
readline/readline/examples/rlptytest.c [moved from readline/examples/rlptytest.c with 100% similarity]
readline/readline/examples/rltest.c [moved from readline/examples/rltest.c with 100% similarity]
readline/readline/examples/rlversion.c [moved from readline/examples/rlversion.c with 100% similarity]
readline/readline/funmap.c [moved from readline/funmap.c with 100% similarity]
readline/readline/histexpand.c [moved from readline/histexpand.c with 100% similarity]
readline/readline/histfile.c [moved from readline/histfile.c with 100% similarity]
readline/readline/histlib.h [moved from readline/histlib.h with 100% similarity]
readline/readline/history.c [moved from readline/history.c with 100% similarity]
readline/readline/history.h [moved from readline/history.h with 100% similarity]
readline/readline/histsearch.c [moved from readline/histsearch.c with 100% similarity]
readline/readline/input.c [moved from readline/input.c with 100% similarity]
readline/readline/isearch.c [moved from readline/isearch.c with 100% similarity]
readline/readline/keymaps.c [moved from readline/keymaps.c with 100% similarity]
readline/readline/keymaps.h [moved from readline/keymaps.h with 100% similarity]
readline/readline/kill.c [moved from readline/kill.c with 100% similarity]
readline/readline/macro.c [moved from readline/macro.c with 100% similarity]
readline/readline/mbutil.c [moved from readline/mbutil.c with 100% similarity]
readline/readline/misc.c [moved from readline/misc.c with 100% similarity]
readline/readline/nls.c [moved from readline/nls.c with 100% similarity]
readline/readline/parens.c [moved from readline/parens.c with 100% similarity]
readline/readline/parse-colors.c [moved from readline/parse-colors.c with 100% similarity]
readline/readline/parse-colors.h [moved from readline/parse-colors.h with 100% similarity]
readline/readline/patchlevel [moved from readline/patchlevel with 100% similarity]
readline/readline/posixdir.h [moved from readline/posixdir.h with 100% similarity]
readline/readline/posixjmp.h [moved from readline/posixjmp.h with 100% similarity]
readline/readline/posixselect.h [moved from readline/posixselect.h with 100% similarity]
readline/readline/posixstat.h [moved from readline/posixstat.h with 100% similarity]
readline/readline/readline.c [moved from readline/readline.c with 100% similarity]
readline/readline/readline.h [moved from readline/readline.h with 100% similarity]
readline/readline/readline.pc.in [moved from readline/readline.pc.in with 100% similarity]
readline/readline/rlconf.h [moved from readline/rlconf.h with 100% similarity]
readline/readline/rldefs.h [moved from readline/rldefs.h with 100% similarity]
readline/readline/rlmbutil.h [moved from readline/rlmbutil.h with 100% similarity]
readline/readline/rlprivate.h [moved from readline/rlprivate.h with 100% similarity]
readline/readline/rlshell.h [moved from readline/rlshell.h with 100% similarity]
readline/readline/rlstdc.h [moved from readline/rlstdc.h with 100% similarity]
readline/readline/rltty.c [moved from readline/rltty.c with 100% similarity]
readline/readline/rltty.h [moved from readline/rltty.h with 100% similarity]
readline/readline/rltypedefs.h [moved from readline/rltypedefs.h with 100% similarity]
readline/readline/rlwinsize.h [moved from readline/rlwinsize.h with 100% similarity]
readline/readline/savestring.c [moved from readline/savestring.c with 100% similarity]
readline/readline/search.c [moved from readline/search.c with 100% similarity]
readline/readline/shell.c [moved from readline/shell.c with 100% similarity]
readline/readline/shlib/Makefile.in [moved from readline/shlib/Makefile.in with 100% similarity]
readline/readline/signals.c [moved from readline/signals.c with 100% similarity]
readline/readline/support/config.guess [moved from readline/support/config.guess with 100% similarity]
readline/readline/support/config.rpath [moved from readline/support/config.rpath with 100% similarity]
readline/readline/support/config.sub [moved from readline/support/config.sub with 100% similarity]
readline/readline/support/install.sh [moved from readline/support/install.sh with 100% similarity]
readline/readline/support/mkdirs [moved from readline/support/mkdirs with 100% similarity]
readline/readline/support/mkdist [moved from readline/support/mkdist with 100% similarity]
readline/readline/support/mkinstalldirs [moved from readline/support/mkinstalldirs with 100% similarity]
readline/readline/support/shlib-install [moved from readline/support/shlib-install with 100% similarity]
readline/readline/support/shobj-conf [moved from readline/support/shobj-conf with 100% similarity]
readline/readline/support/wcwidth.c [moved from readline/support/wcwidth.c with 100% similarity]
readline/readline/tcap.h [moved from readline/tcap.h with 100% similarity]
readline/readline/terminal.c [moved from readline/terminal.c with 100% similarity]
readline/readline/text.c [moved from readline/text.c with 100% similarity]
readline/readline/tilde.c [moved from readline/tilde.c with 100% similarity]
readline/readline/tilde.h [moved from readline/tilde.h with 100% similarity]
readline/readline/undo.c [moved from readline/undo.c with 100% similarity]
readline/readline/util.c [moved from readline/util.c with 100% similarity]
readline/readline/vi_keymap.c [moved from readline/vi_keymap.c with 100% similarity]
readline/readline/vi_mode.c [moved from readline/vi_mode.c with 100% similarity]
readline/readline/xfree.c [moved from readline/xfree.c with 100% similarity]
readline/readline/xmalloc.c [moved from readline/xmalloc.c with 100% similarity]
readline/readline/xmalloc.h [moved from readline/xmalloc.h with 100% similarity]