]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/Makefile.in
gdb/Makefile.in: remove testsuite from SUBDIRS
authorSimon Marchi <simon.marchi@polymtl.ca>
Wed, 7 Jul 2021 13:09:32 +0000 (09:09 -0400)
committerSimon Marchi <simon.marchi@polymtl.ca>
Thu, 8 Jul 2021 13:56:49 +0000 (09:56 -0400)
commite4cbcea361dd5609a2a4cdf5c63ac15837666c50
tree32eadd461efbea53a55a6b6dbf4f3b31c98035f3
parentf1cee837665a932d3d747597d8512cd0d3650478
gdb/Makefile.in: remove testsuite from SUBDIRS

When distclean-ing a configured / built gdb directory, like so:

    $ ./configure && make all-gdb && make distclean

The distclean operation fails with:

    Missing testsuite/Makefile

If we look at the SUBDIRS variable in the generated gdb/Makefile,
testsuite is there twice:

    SUBDIRS = doc  testsuite data-directory testsuite

So we try distclean-ing the testsuite directory twice.  The second time,
gdb/testsuite/Makefile doesn't exist, so it fails.

The first "testsuite" comes from the @subdirs@ replacement, because of
the `AC_CONFIG_SUBDIRS` macro in gdb/configure.ac.  The second one is
hard-coded in gdb/Makefile.in:

    SUBDIRS = doc @subdirs@ data-directory testsuite

The hard-coded was added by:

    bdbbcd577460 ("Always build 'all' in gdb/testsuite")

which came after `testsuite` was removed from @subdirs@ by:

    f99d1d37496f ("Remove gdb/testsuite/configure")

My commit a100a94530eb ("gdb/testsuite: restore configure script")
should have removed the hard-coded `testsuite`, since it added it back
as a "subdir", but I missed it because I only looked f99d1d37496f to
write my patch.

Fix this by removing the hard-coded one.

This patch should be pushed to both master and gdb-11-branch, hence the
ChangeLog entry:

gdb/ChangeLog:

* Makefile.in (SUBDIRS): Remove testsuite.

Change-Id: I63e5590b1a08673c646510b3ecc74600eae9f92d
gdb/Makefile.in