]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/testsuite/ChangeLog
Tighten regexp of lib/completion-support.exp:test_gdb_complete_tab_multiple
authorPedro Alves <palves@redhat.com>
Wed, 13 Dec 2017 16:38:50 +0000 (16:38 +0000)
committerPedro Alves <palves@redhat.com>
Wed, 13 Dec 2017 16:40:00 +0000 (16:40 +0000)
commit6892d2e4df57160f7103fef0340ae3f55ac8b2b3
tree8b723f209d8c639f6372f8e7dc381759fa9ac7f3
parenta22ecf70263eff75ca2c5878fe7e8d0311d6737f
Tighten regexp of lib/completion-support.exp:test_gdb_complete_tab_multiple

While writing the tests included in the previous commit, I noticed
that test_gdb_complete_tab_multiple would not FAIL if GDB happens to
show more completions than expected before the expected list.

E.g., with something like this, expecting "p foo" to complete to
"foo2" and "foo3":

 test_gdb_complete_tab_multiple "p foo" "" {
"foo2"
"foo3"
 }

and then if foo actually completes to:

 (gdb) p foo[TAB]
 foo1   foo2  foo3
 ^^^^

we'd still PASS.  (Note the spurious "foo1" above.)

This tightens the regexp with a beginning anchor thus making the
completions above cause a FAIL.  Other similar functions in
completion-support.exp already do something like this; I had just
missed this one originally.  Thankfully, this did not expose any
problems in the gdb.linespec/ tests.  Phew.

gdb/testsuite/ChangeLog:
2017-12-13  Pedro Alves  <palves@redhat.com>

* lib/completion-support.exp (test_gdb_complete_tab_multiple):
Tighten regexp by matching with an anchor.
gdb/testsuite/ChangeLog
gdb/testsuite/lib/completion-support.exp