]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - sim/cr16/ChangeLog
sim: cr16: fix build warnings
authorMike Frysinger <vapier@gentoo.org>
Mon, 19 Apr 2021 01:01:00 +0000 (21:01 -0400)
committerMike Frysinger <vapier@gentoo.org>
Mon, 19 Apr 2021 01:07:25 +0000 (21:07 -0400)
commit3912a8db685f5e19a883d02d66900cdf10a200f0
tree07104f4906862d7e7c2e121b728ab16658dd1d98
parent9eab4c18bd39c0dc5b3f41892d80c130b0852e35
sim: cr16: fix build warnings

The printf fix is obvious enough, but the hash one is a real bug:
cr16/interp.c: In function 'sim_open':
cr16/interp.c:560:17: error: 'h' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  560 |               h = h->next;
      |               ~~^~~~~~~~~

It happens to not cause a problem currently because the first entry in
the generated table that this loop operates matches a codepath where h
is initialized.  Then when later entries don't match, the previous value
is pointing at the end of a valid hash table already, and the rest of
the code does nothing.

With this tidied up, we can delete the SIM_AC_OPTION_WARNINGS(no) call
to get the default common behavior where -Werror is enabled.
sim/cr16/ChangeLog
sim/cr16/configure
sim/cr16/configure.ac
sim/cr16/interp.c