]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
ada-tasks.c::read_atcb: start from a cleared ada_task_info result
authorJoel Brobecker <brobecker@adacore.com>
Wed, 7 Nov 2018 21:03:38 +0000 (16:03 -0500)
committerJoel Brobecker <brobecker@adacore.com>
Wed, 7 Nov 2018 21:28:07 +0000 (16:28 -0500)
commit07deea26b5c3dfefe50dff74925e903b826acf22
tree342e6e6267237f6030286d5ce035ff0a3706c8aa
parentd3def5d73eb9d8295ca7b11d130b17a815151951
ada-tasks.c::read_atcb: start from a cleared ada_task_info result

The purpose of this patch is not to fix a bug per se, but rather
to robustify this function to make sure it never returns a struct
ada_task_info where some of the fields are left uninitialized.
Reading the current implementation, it attempts to methodically
set them all one by one: but it's not excluded that a future
change might miss something. A memset is cheap and make sure that
this function returns repeatable results.

This in turns allows us to remove some assignments which have become
redundant.

gdb/ChangeLog:

        * ada-tasks.c (read_atcb): Clear task_info before computing
        the value of each of its fields.
gdb/ChangeLog
gdb/ada-tasks.c