]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
btrace: fix tests for 32-bit
authorMarkus Metzger <markus.t.metzger@intel.com>
Tue, 3 Feb 2015 15:42:41 +0000 (16:42 +0100)
committerMarkus Metzger <markus.t.metzger@intel.com>
Wed, 25 Mar 2015 13:18:02 +0000 (14:18 +0100)
commit66849923d2f6505b691f24dcb15797f2e0d969ec
tree18ddb3cf85fa7a0192830fbb375ff56636e82661
parent11cc1b74538286b8bc775057fe1300707b3e3520
btrace: fix tests for 32-bit

The x86-record_goto.S assembly source file does not build on 32-bit.
This breaks many tests that use this file.

Split it into x86_64-record_goto.S and i686-record_goto.S.  Luckily, we
can use either one with the same test .exp file.

It further turned out that most tests do not really need a fixed binary;
they should work pretty well with a newly-compiled C program.  The
one thing that breaks this is the heavy use of "record goto" to navigate
inside the recorded execution.

Combine step.exp, next,exp, and finish.exp into a single test step.exp
and use normal stepping and reverse-stepping commands for navigation.

testsuite/
* gdb.btrace/next.exp: Merged into step.exp.
* gdb.btrace/finish.exp: Merged into step.exp.
* gdb.btrace/nexti.exp: Merged into stepi.exp.
* gdb.btrace/step.exp: Use record_goto.c as test file.  Avoid using
"record goto" and checking the exact replay position.
* gdb.btrace/stepi.exp: Choose test file based on target.  Do not
check for "Recording format" in "info record" output.
* gdb.btrace/record_goto.exp: Choose test file based on target.
* gdb.btrace/x86-record_goto.S: Renamed into ...
* gdb.btrace/x86_64-record_goto.S: ... this.
* gdb.btrace/i686-record_goto.S: New.
* gdb.btrace/x86-tailcall.S: Renamed into ...
* gdb.btrace/x86_64-tailcall.S: ... this.
* gdb.btrace/i686-tailcall.S: New.
* gdb.btrace/x86-tailcall.c: Renamed into ...
* gdb.btrace/tailcall.c: ... this.  Split "return ++answer" into two
separate statements.  Update test.
* gdb.btrace/delta.exp: Use record_goto.c as test file.
* gdb.btrace/gcore.exp: Use record_goto.c as test file.
* gdb.btrace/nohist.exp: Use record_goto.c as test file.
* gdb.btrace/tailcall.exp: Choose test file based on target.
* gdb.btrace/Makefile.in: Remove next, finish, and nexti.
17 files changed:
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.btrace/Makefile.in
gdb/testsuite/gdb.btrace/delta.exp
gdb/testsuite/gdb.btrace/finish.exp [deleted file]
gdb/testsuite/gdb.btrace/gcore.exp
gdb/testsuite/gdb.btrace/i686-record_goto.S [new file with mode: 0644]
gdb/testsuite/gdb.btrace/i686-tailcall.S [new file with mode: 0644]
gdb/testsuite/gdb.btrace/next.exp [deleted file]
gdb/testsuite/gdb.btrace/nexti.exp [deleted file]
gdb/testsuite/gdb.btrace/nohist.exp
gdb/testsuite/gdb.btrace/record_goto.exp
gdb/testsuite/gdb.btrace/step.exp
gdb/testsuite/gdb.btrace/stepi.exp
gdb/testsuite/gdb.btrace/tailcall.c [moved from gdb/testsuite/gdb.btrace/x86-tailcall.c with 96% similarity]
gdb/testsuite/gdb.btrace/tailcall.exp
gdb/testsuite/gdb.btrace/x86_64-record_goto.S [moved from gdb/testsuite/gdb.btrace/x86-record_goto.S with 99% similarity]
gdb/testsuite/gdb.btrace/x86_64-tailcall.S [moved from gdb/testsuite/gdb.btrace/x86-tailcall.S with 50% similarity]