]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Fix uninitialised variable errors
authorAlan Modra <amodra@gmail.com>
Thu, 4 Apr 2024 00:53:32 +0000 (11:23 +1030)
committerAlan Modra <amodra@gmail.com>
Thu, 4 Apr 2024 01:03:13 +0000 (11:33 +1030)
commit9fd82d9142d742c9e3efb16466019bd5fe86aef9
tree3e0d0a034010c1092b6b02d7fea5a8d9f2690d07
parentb86d3af60ffc5a821aa54404f57ffe9476919135
Fix uninitialised variable errors

Commit c6291d749aec introduced a number of errors, found by clang.

elf.c:456:7: error: variable 'alloc_ext_size' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
  if (_bfd_mul_overflow (symcount, extsym_size, &amt))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
elf.c:464:7: error: variable 'alloc_extshndx_size' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
  if (bfd_seek (ibfd, pos, SEEK_SET) != 0
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
elflink.c:2837:11: error: variable 'alloc1_size' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
      if (internal_relocs == NULL)
          ^~~~~~~~~~~~~~~~~~~~~~~
elflink.c:12595:16: error: variable 'ext_size' set but not used [-Werror,-Wunused-but-set-variable]
                      size_t ext_size = 0;

* elf.c (bfd_elf_get_elf_syms): Fix use of uninitialised variables.
* elflink.c (_bfd_elf_link_info_read_relocs): Likewise.
(bfd_elf_final_link): Fix set but not used warning.
bfd/elf.c
bfd/elflink.c