From 0a6a8b596b285d5c3cdf086ca85be59ff0a97071 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Sat, 28 Mar 2020 14:31:02 +1030 Subject: [PATCH] Re: Adjust objcopy_test Last patch didn't manage to xfail spu due to clear_xfail *-*-*elf*. Clearing *-*-*elf* dates back to a time when we had rather a lot more setup_xfail patterns, so limiting it to hppa*-*-*elf*. Also, mips-*-irix ought to have been mips-*-irix* and I'm having second thoughts about xfailing mips and hiding what looks like a problem: If the mips target is supposed to emit names for local section symbols and does so for objcopy, why isn't it doing the same for ld? Also, lots more mips targets would be subject to this test failing. So I'm backing out those xfails and leaving it to someone more knowledgeable about mips. * testsuite/binutils-all/objcopy.exp (objcopy_test): Only clear_xfail hppa*-*-*elf*. Revert mips xfails. --- binutils/ChangeLog | 5 +++++ binutils/testsuite/binutils-all/objcopy.exp | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index cb8836c697e..c7c2d73fb72 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2020-03-28 Alan Modra + + * testsuite/binutils-all/objcopy.exp (objcopy_test): Only + clear_xfail hppa*-*-*elf*. Revert mips xfails. + 2020-03-28 Alan Modra * testsuite/binutils-all/objcopy.exp (objcopy_test): Move xfails diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp index 0eafcdbede1..e4eb53cf84a 100644 --- a/binutils/testsuite/binutils-all/objcopy.exp +++ b/binutils/testsuite/binutils-all/objcopy.exp @@ -117,7 +117,7 @@ setup_xfail "hppa*-*-*" setup_xfail "sh-*-coff*" setup_xfail "tic54x-*-*" clear_xfail "hppa*64*-*-hpux*" "hppa*-*-linux*" "hppa*-*-lites*" -clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "*-*-*elf*" +clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "hppa*-*-*elf*" objcopy_test "simple copy" bintest.s object "" "" # Test verilog data width @@ -1112,7 +1112,7 @@ if [is_elf_format] { setup_xfail "sh-*-coff*" setup_xfail "tic54x-*-*" clear_xfail "hppa*64*-*-hpux*" "hppa*-*-linux*" "hppa*-*-lites*" - clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "*-*-*elf*" + clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "hppa*-*-*elf*" objcopy_test "ELF unknown section type" unknown.s object "" "" objcopy_test_readelf "ELF group 1" group.s @@ -1345,7 +1345,7 @@ run_dump_test "set-section-alignment" setup_xfail "hppa*-*-*" setup_xfail "sh-*-coff*" -setup_xfail "mips-*-irix" "mipstx39-*-*" "spu-*-*" +setup_xfail "spu-*-*" clear_xfail "hppa*64*-*-hpux*" "hppa*-*-linux*" "hppa*-*-lites*" -clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "*-*-*elf*" +clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "hppa*-*-*elf*" objcopy_test "pr25662" pr25662.s executable "" "-T$srcdir/$subdir/pr25662.ld" -- 2.39.2