]> git.ipfire.org Git - thirdparty/git.git/blame - builtin/add.c
apply --allow-overlap: fix a corner case
[thirdparty/git.git] / builtin / add.c
CommitLineData
0d781539
LT
1/*
2 * "git add" builtin command
3 *
4 * Copyright (C) 2006 Linus Torvalds
5 */
f8adbec9 6#define USE_THE_INDEX_COMPATIBILITY_MACROS
0d781539 7#include "cache.h"
b2141fc1 8#include "config.h"
0d781539 9#include "builtin.h"
697cc8ef 10#include "lockfile.h"
0d781539 11#include "dir.h"
6f525e71 12#include "pathspec.h"
d807c4a0 13#include "exec-cmd.h"
93872e07 14#include "cache-tree.h"
58680165 15#include "run-command.h"
5c46f754 16#include "parse-options.h"
c59cb03a 17#include "diff.h"
fb7d3f32 18#include "diffcore.h"
c59cb03a 19#include "revision.h"
568508e7 20#include "bulk-checkin.h"
c45a18e8 21#include "argv-array.h"
bdab9721 22#include "submodule.h"
f83dff60 23#include "add-interactive.h"
0d781539 24
5c46f754 25static const char * const builtin_add_usage[] = {
9c9b4f2f 26 N_("git add [<options>] [--] <pathspec>..."),
5c46f754
KH
27 NULL
28};
c59cb03a 29static int patch_interactive, add_interactive, edit_interactive;
93c44d49 30static int take_worktree_changes;
9472935d 31static int add_renormalize;
896bdfa2 32
9cba13ca 33struct update_callback_data {
610d55af 34 int flags;
fb7d3f32
LT
35 int add_errors;
36};
37
1e22a991 38static void chmod_pathspec(struct pathspec *pathspec, char flip)
610d55af
TG
39{
40 int i;
41
42 for (i = 0; i < active_nr; i++) {
43 struct cache_entry *ce = active_cache[i];
44
6d2df284 45 if (pathspec && !ce_path_match(&the_index, ce, pathspec, NULL))
610d55af
TG
46 continue;
47
1e22a991
RJ
48 if (chmod_cache_entry(ce, flip) < 0)
49 fprintf(stderr, "cannot chmod %cx '%s'\n", flip, ce->name);
610d55af
TG
50 }
51}
52
75973b2c
JH
53static int fix_unmerged_status(struct diff_filepair *p,
54 struct update_callback_data *data)
55{
56 if (p->status != DIFF_STATUS_UNMERGED)
57 return p->status;
58 if (!(data->flags & ADD_CACHE_IGNORE_REMOVAL) && !p->two->mode)
59 /*
60 * This is not an explicit add request, and the
61 * path is missing from the working tree (deleted)
62 */
63 return DIFF_STATUS_DELETED;
64 else
65 /*
66 * Either an explicit add request, or path exists
67 * in the working tree. An attempt to explicitly
68 * add a path that does not exist in the working tree
69 * will be caught as an error by the caller immediately.
70 */
71 return DIFF_STATUS_MODIFIED;
72}
73
fb7d3f32
LT
74static void update_callback(struct diff_queue_struct *q,
75 struct diff_options *opt, void *cbdata)
76{
77 int i;
78 struct update_callback_data *data = cbdata;
79
80 for (i = 0; i < q->nr; i++) {
81 struct diff_filepair *p = q->queue[i];
82 const char *path = p->one->path;
75973b2c 83 switch (fix_unmerged_status(p, data)) {
fb7d3f32 84 default:
990ac4be 85 die(_("unexpected diff status %c"), p->status);
fb7d3f32
LT
86 case DIFF_STATUS_MODIFIED:
87 case DIFF_STATUS_TYPE_CHANGED:
610d55af 88 if (add_file_to_index(&the_index, path, data->flags)) {
fb7d3f32 89 if (!(data->flags & ADD_CACHE_IGNORE_ERRORS))
990ac4be 90 die(_("updating files failed"));
fb7d3f32
LT
91 data->add_errors++;
92 }
93 break;
94 case DIFF_STATUS_DELETED:
95 if (data->flags & ADD_CACHE_IGNORE_REMOVAL)
96 break;
97 if (!(data->flags & ADD_CACHE_PRETEND))
98 remove_file_from_index(&the_index, path);
99 if (data->flags & (ADD_CACHE_PRETEND|ADD_CACHE_VERBOSE))
475c73eb 100 printf(_("remove '%s'\n"), path);
fb7d3f32
LT
101 break;
102 }
103 }
104}
105
610d55af
TG
106int add_files_to_cache(const char *prefix,
107 const struct pathspec *pathspec, int flags)
fb7d3f32 108{
160c4b18 109 struct update_callback_data data;
fb7d3f32 110 struct rev_info rev;
71c7b053 111
160c4b18
JH
112 memset(&data, 0, sizeof(data));
113 data.flags = flags;
114
2abf3503 115 repo_init_revisions(the_repository, &rev, prefix);
fb7d3f32 116 setup_revisions(0, NULL, &rev, NULL);
3efe8e43
NTND
117 if (pathspec)
118 copy_pathspec(&rev.prune_data, pathspec);
fb7d3f32
LT
119 rev.diffopt.output_format = DIFF_FORMAT_CALLBACK;
120 rev.diffopt.format_callback = update_callback;
160c4b18 121 rev.diffopt.format_callback_data = &data;
0d1e0e78 122 rev.diffopt.flags.override_submodule_config = 1;
75973b2c 123 rev.max_count = 0; /* do not compare unmerged paths with stage #2 */
fb7d3f32 124 run_diff_files(&rev, DIFF_RACY_IS_MODIFIED);
fe6a01af 125 clear_pathspec(&rev.prune_data);
fb7d3f32
LT
126 return !!data.add_errors;
127}
128
9472935d
TB
129static int renormalize_tracked_files(const struct pathspec *pathspec, int flags)
130{
131 int i, retval = 0;
132
133 for (i = 0; i < active_nr; i++) {
134 struct cache_entry *ce = active_cache[i];
135
136 if (ce_stage(ce))
137 continue; /* do not touch unmerged paths */
138 if (!S_ISREG(ce->ce_mode) && !S_ISLNK(ce->ce_mode))
139 continue; /* do not touch non blobs */
6d2df284 140 if (pathspec && !ce_path_match(&the_index, ce, pathspec, NULL))
9472935d 141 continue;
9e5da3d0 142 retval |= add_file_to_cache(ce->name, flags | ADD_CACHE_RENORMALIZE);
9472935d
TB
143 }
144
145 return retval;
146}
147
053a6b18 148static char *prune_directory(struct dir_struct *dir, struct pathspec *pathspec, int prefix)
0d781539 149{
f2593398 150 char *seen;
84b8b5d1 151 int i;
0d781539
LT
152 struct dir_entry **src, **dst;
153
84b8b5d1 154 seen = xcalloc(pathspec->nr, 1);
f2593398 155
0d781539
LT
156 src = dst = dir->entries;
157 i = dir->nr;
158 while (--i >= 0) {
159 struct dir_entry *entry = *src++;
6d2df284 160 if (dir_path_match(&the_index, entry, pathspec, prefix, seen))
4d06f8ac 161 *dst++ = entry;
0d781539
LT
162 }
163 dir->nr = dst - dir->entries;
08de9151 164 add_pathspec_matches_against_index(pathspec, &the_index, seen);
81f45e7d 165 return seen;
0d781539
LT
166}
167
9b2d6149 168static void refresh(int verbose, const struct pathspec *pathspec)
d616813d
AJ
169{
170 char *seen;
9b2d6149 171 int i;
d616813d 172
9b2d6149 173 seen = xcalloc(pathspec->nr, 1);
43673fdd 174 refresh_index(&the_index, verbose ? REFRESH_IN_PORCELAIN : REFRESH_QUIET,
ed2a808d 175 pathspec, seen, _("Unstaged changes after refreshing the index:"));
9b2d6149 176 for (i = 0; i < pathspec->nr; i++) {
d616813d 177 if (!seen[i])
9b2d6149
NTND
178 die(_("pathspec '%s' did not match any files"),
179 pathspec->items[i].match);
d616813d 180 }
ec36c42a 181 free(seen);
d616813d
AJ
182}
183
46b5139c 184int run_add_interactive(const char *revision, const char *patch_mode,
480ca644 185 const struct pathspec *pathspec)
58680165 186{
c45a18e8
FR
187 int status, i;
188 struct argv_array argv = ARGV_ARRAY_INIT;
f83dff60
JS
189 int use_builtin_add_i =
190 git_env_bool("GIT_TEST_ADD_I_USE_BUILTIN", -1);
191
192 if (!patch_mode) {
193 if (use_builtin_add_i < 0)
194 git_config_get_bool("add.interactive.usebuiltin",
195 &use_builtin_add_i);
196 if (use_builtin_add_i == 1)
197 return !!run_add_i(the_repository, pathspec);
198 }
3f061887 199
c45a18e8 200 argv_array_push(&argv, "add--interactive");
46b5139c 201 if (patch_mode)
c45a18e8 202 argv_array_push(&argv, patch_mode);
46b5139c 203 if (revision)
c45a18e8
FR
204 argv_array_push(&argv, revision);
205 argv_array_push(&argv, "--");
480ca644
NTND
206 for (i = 0; i < pathspec->nr; i++)
207 /* pass original pathspec, to be re-parsed */
c45a18e8 208 argv_array_push(&argv, pathspec->items[i].original);
7c0ab445 209
c45a18e8
FR
210 status = run_command_v_opt(argv.argv, RUN_GIT_CMD);
211 argv_array_clear(&argv);
7c0ab445 212 return status;
58680165
KH
213}
214
b4bd4668 215int interactive_add(int argc, const char **argv, const char *prefix, int patch)
46b5139c 216{
5a76aff1 217 struct pathspec pathspec;
46b5139c 218
625c3304 219 parse_pathspec(&pathspec, 0,
5a76aff1 220 PATHSPEC_PREFER_FULL |
480ca644
NTND
221 PATHSPEC_SYMLINK_LEADING_PATH |
222 PATHSPEC_PREFIX_ORIGIN,
5a76aff1 223 prefix, argv);
46b5139c
TR
224
225 return run_add_interactive(NULL,
b4bd4668 226 patch ? "--patch" : NULL,
480ca644 227 &pathspec);
46b5139c
TR
228}
229
2af202be 230static int edit_patch(int argc, const char **argv, const char *prefix)
c59cb03a 231{
d292bfaf 232 char *file = git_pathdup("ADD_EDIT.patch");
c59cb03a 233 const char *apply_argv[] = { "apply", "--recount", "--cached",
66dbfd55 234 NULL, NULL };
d3180279 235 struct child_process child = CHILD_PROCESS_INIT;
c59cb03a
JS
236 struct rev_info rev;
237 int out;
238 struct stat st;
239
66dbfd55
GV
240 apply_argv[3] = file;
241
c59cb03a
JS
242 git_config(git_diff_basic_config, NULL); /* no "diff" UI options */
243
244 if (read_cache() < 0)
d521abf8 245 die(_("Could not read the index"));
c59cb03a 246
2abf3503 247 repo_init_revisions(the_repository, &rev, prefix);
c59cb03a
JS
248 rev.diffopt.context = 7;
249
250 argc = setup_revisions(argc, argv, &rev, NULL);
251 rev.diffopt.output_format = DIFF_FORMAT_PATCH;
7f3b8c62 252 rev.diffopt.use_color = 0;
0d1e0e78 253 rev.diffopt.flags.ignore_dirty_submodules = 1;
fa6f225e 254 out = open(file, O_CREAT | O_WRONLY | O_TRUNC, 0666);
c59cb03a 255 if (out < 0)
d521abf8 256 die(_("Could not open '%s' for writing."), file);
41698375 257 rev.diffopt.file = xfdopen(out, "w");
c59cb03a
JS
258 rev.diffopt.close_file = 1;
259 if (run_diff_files(&rev, 0))
d521abf8 260 die(_("Could not write patch"));
c59cb03a 261
cb64800d
JK
262 if (launch_editor(file, NULL, NULL))
263 die(_("editing patch failed"));
c59cb03a
JS
264
265 if (stat(file, &st))
990ac4be 266 die_errno(_("Could not stat '%s'"), file);
c59cb03a 267 if (!st.st_size)
990ac4be 268 die(_("Empty patch. Aborted."));
c59cb03a 269
c59cb03a
JS
270 child.git_cmd = 1;
271 child.argv = apply_argv;
272 if (run_command(&child))
d521abf8 273 die(_("Could not apply '%s'"), file);
c59cb03a
JS
274
275 unlink(file);
d292bfaf 276 free(file);
c59cb03a
JS
277 return 0;
278}
279
b39c53e6 280static const char ignore_error[] =
439fb829 281N_("The following paths are ignored by one of your .gitignore files:\n");
6a1ad325 282
300c0a22 283static int verbose, show_only, ignored_too, refresh_only;
45c45e30 284static int ignore_add_errors, intent_to_add, ignore_missing;
53213994 285static int warn_on_embedded_repo = 1;
45c45e30 286
fdc97abd 287#define ADDREMOVE_DEFAULT 1
45c45e30
JH
288static int addremove = ADDREMOVE_DEFAULT;
289static int addremove_explicit = -1; /* unspecified */
5c46f754 290
4e55ed32
ET
291static char *chmod_arg;
292
9f60f49b
JH
293static int ignore_removal_cb(const struct option *opt, const char *arg, int unset)
294{
295 /* if we are told to ignore, we are not adding removals */
296 *(int *)opt->value = !unset ? 0 : 1;
297 return 0;
298}
299
5c46f754 300static struct option builtin_add_options[] = {
1b56024c
NTND
301 OPT__DRY_RUN(&show_only, N_("dry run")),
302 OPT__VERBOSE(&verbose, N_("be verbose")),
5c46f754 303 OPT_GROUP(""),
300c0a22
JH
304 OPT_BOOL('i', "interactive", &add_interactive, N_("interactive picking")),
305 OPT_BOOL('p', "patch", &patch_interactive, N_("select hunks interactively")),
306 OPT_BOOL('e', "edit", &edit_interactive, N_("edit current diff and apply")),
1224781d 307 OPT__FORCE(&ignored_too, N_("allow adding otherwise ignored files"), 0),
300c0a22 308 OPT_BOOL('u', "update", &take_worktree_changes, N_("update tracked files")),
9472935d 309 OPT_BOOL(0, "renormalize", &add_renormalize, N_("renormalize EOL of tracked files (implies -u)")),
300c0a22 310 OPT_BOOL('N', "intent-to-add", &intent_to_add, N_("record only the fact that the path will be added later")),
45c45e30 311 OPT_BOOL('A', "all", &addremove_explicit, N_("add changes from all tracked and untracked files")),
9f60f49b
JH
312 { OPTION_CALLBACK, 0, "ignore-removal", &addremove_explicit,
313 NULL /* takes no arguments */,
314 N_("ignore paths removed in the working tree (same as --no-all)"),
315 PARSE_OPT_NOARG, ignore_removal_cb },
300c0a22
JH
316 OPT_BOOL( 0 , "refresh", &refresh_only, N_("don't add, only refresh the index")),
317 OPT_BOOL( 0 , "ignore-errors", &ignore_add_errors, N_("just skip files which cannot be added because of errors")),
318 OPT_BOOL( 0 , "ignore-missing", &ignore_missing, N_("check if - even missing - files are ignored in dry run")),
5f0df44c
RS
319 OPT_STRING(0, "chmod", &chmod_arg, "(+|-)x",
320 N_("override the executable bit of the listed files")),
53213994
JK
321 OPT_HIDDEN_BOOL(0, "warn-embedded-repo", &warn_on_embedded_repo,
322 N_("warn when adding an embedded repository")),
5c46f754
KH
323 OPT_END(),
324};
325
9bd81e42 326static int add_config(const char *var, const char *value, void *cb)
dad25e4a 327{
8c2be75f
JN
328 if (!strcmp(var, "add.ignoreerrors") ||
329 !strcmp(var, "add.ignore-errors")) {
dad25e4a
AR
330 ignore_add_errors = git_config_bool(var, value);
331 return 0;
332 }
f83dff60 333
9bd81e42 334 return git_default_config(var, value, cb);
dad25e4a
AR
335}
336
53213994
JK
337static const char embedded_advice[] = N_(
338"You've added another git repository inside your current repository.\n"
339"Clones of the outer repository will not contain the contents of\n"
340"the embedded repository and will not know how to obtain it.\n"
341"If you meant to add a submodule, use:\n"
342"\n"
343" git submodule add <url> %s\n"
344"\n"
345"If you added this path by mistake, you can remove it from the\n"
346"index with:\n"
347"\n"
348" git rm --cached %s\n"
349"\n"
350"See \"git help submodule\" for more information."
351);
352
353static void check_embedded_repo(const char *path)
354{
355 struct strbuf name = STRBUF_INIT;
356
357 if (!warn_on_embedded_repo)
358 return;
359 if (!ends_with(path, "/"))
360 return;
361
362 /* Drop trailing slash for aesthetics */
363 strbuf_addstr(&name, path);
364 strbuf_strip_suffix(&name, "/");
365
366 warning(_("adding embedded git repository: %s"), name.buf);
367 if (advice_add_embedded_repo) {
368 advise(embedded_advice, name.buf, name.buf);
369 /* there may be multiple entries; advise only once */
370 advice_add_embedded_repo = 0;
371 }
372
373 strbuf_release(&name);
374}
375
610d55af 376static int add_files(struct dir_struct *dir, int flags)
c972ec04
JH
377{
378 int i, exit_status = 0;
379
380 if (dir->ignored_nr) {
439fb829 381 fprintf(stderr, _(ignore_error));
c972ec04
JH
382 for (i = 0; i < dir->ignored_nr; i++)
383 fprintf(stderr, "%s\n", dir->ignored[i]->name);
439fb829 384 fprintf(stderr, _("Use -f if you really want to add them.\n"));
1d31e5a2 385 exit_status = 1;
c972ec04
JH
386 }
387
53213994 388 for (i = 0; i < dir->nr; i++) {
610d55af 389 if (add_file_to_index(&the_index, dir->entries[i]->name, flags)) {
c972ec04 390 if (!ignore_add_errors)
990ac4be 391 die(_("adding files failed"));
c972ec04 392 exit_status = 1;
f937bc2f
KM
393 } else {
394 check_embedded_repo(dir->entries[i]->name);
c972ec04 395 }
53213994 396 }
c972ec04
JH
397 return exit_status;
398}
399
a633fca0 400int cmd_add(int argc, const char **argv, const char *prefix)
0d781539 401{
7ae02a30 402 int exit_status = 0;
5a76aff1 403 struct pathspec pathspec;
0d781539 404 struct dir_struct dir;
610d55af 405 int flags;
c972ec04
JH
406 int add_new_files;
407 int require_pathspec;
81f45e7d 408 char *seen = NULL;
0fa5a2ed 409 struct lock_file lock_file = LOCK_INIT;
5cde71d6 410
ed342fde
SB
411 git_config(add_config, NULL);
412
37782920 413 argc = parse_options(argc, argv, prefix, builtin_add_options,
c59cb03a 414 builtin_add_usage, PARSE_OPT_KEEP_ARGV0);
b63e9950
WC
415 if (patch_interactive)
416 add_interactive = 1;
7c0ab445 417 if (add_interactive)
b4bd4668 418 exit(interactive_add(argc - 1, argv + 1, prefix, patch_interactive));
0d781539 419
c59cb03a
JS
420 if (edit_interactive)
421 return(edit_patch(argc, argv, prefix));
422 argc--;
423 argv++;
424
45c45e30
JH
425 if (0 <= addremove_explicit)
426 addremove = addremove_explicit;
427 else if (take_worktree_changes && ADDREMOVE_DEFAULT)
428 addremove = 0; /* "-u" was given but not "-A" */
429
3ba1f114 430 if (addremove && take_worktree_changes)
990ac4be 431 die(_("-A and -u are mutually incompatible"));
45c45e30 432
45c45e30 433 if (!take_worktree_changes && addremove_explicit < 0 && argc)
fdc97abd
JH
434 /* Turn "git add pathspec..." to "git add -A pathspec..." */
435 addremove = 1;
45c45e30 436
108da0db 437 if (!show_only && ignore_missing)
990ac4be 438 die(_("Option --ignore-missing can only be used together with --dry-run"));
808d3d71 439
610d55af
TG
440 if (chmod_arg && ((chmod_arg[0] != '-' && chmod_arg[0] != '+') ||
441 chmod_arg[1] != 'x' || chmod_arg[2]))
4e55ed32
ET
442 die(_("--chmod param '%s' must be either -x or +x"), chmod_arg);
443
9472935d 444 add_new_files = !take_worktree_changes && !refresh_only && !add_renormalize;
29abb339 445 require_pathspec = !(take_worktree_changes || (0 < addremove_explicit));
c972ec04 446
b3e83cc7 447 hold_locked_index(&lock_file, LOCK_DIE_ON_ERROR);
0d781539 448
205ffa94 449 flags = ((verbose ? ADD_CACHE_VERBOSE : 0) |
01665924 450 (show_only ? ADD_CACHE_PRETEND : 0) |
39425819 451 (intent_to_add ? ADD_CACHE_INTENT : 0) |
1e5f764c
JH
452 (ignore_add_errors ? ADD_CACHE_IGNORE_ERRORS : 0) |
453 (!(addremove || take_worktree_changes)
808d3d71 454 ? ADD_CACHE_IGNORE_REMOVAL : 0));
205ffa94 455
c972ec04 456 if (require_pathspec && argc == 0) {
990ac4be
ÆAB
457 fprintf(stderr, _("Nothing specified, nothing added.\n"));
458 fprintf(stderr, _("Maybe you wanted to say 'git add .'?\n"));
93b0d86a
JH
459 return 0;
460 }
0d781539 461
5a76aff1
NTND
462 /*
463 * Check the "pathspec '%s' did not match any files" block
464 * below before enabling new magic.
465 */
84d938b7 466 parse_pathspec(&pathspec, PATHSPEC_ATTR,
5a76aff1 467 PATHSPEC_PREFER_FULL |
c08397e3 468 PATHSPEC_SYMLINK_LEADING_PATH,
5a76aff1 469 prefix, argv);
366bfcb6 470
d1664e73
BP
471 if (read_cache_preload(&pathspec) < 0)
472 die(_("index file corrupt"));
473
474 die_in_unpopulated_submodule(&the_index, prefix);
c08397e3
BW
475 die_path_inside_submodule(&the_index, &pathspec);
476
1d8842d9
LT
477 if (add_new_files) {
478 int baselen;
479
480 /* Set up the default git porcelain excludes */
481 memset(&dir, 0, sizeof(dir));
482 if (!ignored_too) {
483 dir.flags |= DIR_COLLECT_IGNORED;
484 setup_standard_excludes(&dir);
485 }
486
1e5f764c 487 /* This picks up the paths that are not tracked */
0d32c183 488 baselen = fill_directory(&dir, &the_index, &pathspec);
5a76aff1 489 if (pathspec.nr)
053a6b18 490 seen = prune_directory(&dir, &pathspec, baselen);
1d8842d9 491 }
1e5f764c 492
c972ec04 493 if (refresh_only) {
9b2d6149 494 refresh(verbose, &pathspec);
c972ec04 495 goto finish;
6a1ad325
JH
496 }
497
5a76aff1 498 if (pathspec.nr) {
81f45e7d 499 int i;
eb69934b 500
81f45e7d 501 if (!seen)
08de9151 502 seen = find_pathspecs_matching_against_index(&pathspec, &the_index);
5a76aff1
NTND
503
504 /*
505 * file_exists() assumes exact match
506 */
bd30c2e4
NTND
507 GUARD_PATHSPEC(&pathspec,
508 PATHSPEC_FROMTOP |
509 PATHSPEC_LITERAL |
93d93537 510 PATHSPEC_GLOB |
ef79b1f8
NTND
511 PATHSPEC_ICASE |
512 PATHSPEC_EXCLUDE);
5a76aff1 513
84b8b5d1
NTND
514 for (i = 0; i < pathspec.nr; i++) {
515 const char *path = pathspec.items[i].match;
ef79b1f8
NTND
516 if (pathspec.items[i].magic & PATHSPEC_EXCLUDE)
517 continue;
64ed07ce 518 if (!seen[i] && path[0] &&
93d93537
NTND
519 ((pathspec.items[i].magic &
520 (PATHSPEC_GLOB | PATHSPEC_ICASE)) ||
bd30c2e4 521 !file_exists(path))) {
108da0db 522 if (ignore_missing) {
0188f6b3 523 int dtype = DT_UNKNOWN;
a0bba65b 524 if (is_excluded(&dir, &the_index, path, &dtype))
9e58beca
BW
525 dir_add_ignored(&dir, &the_index,
526 path, pathspec.items[i].len);
108da0db 527 } else
48168851 528 die(_("pathspec '%s' did not match any files"),
84b8b5d1 529 pathspec.items[i].original);
108da0db 530 }
81f45e7d
JH
531 }
532 free(seen);
533 }
534
568508e7
JH
535 plug_bulk_checkin();
536
9472935d
TB
537 if (add_renormalize)
538 exit_status |= renormalize_tracked_files(&pathspec, flags);
539 else
540 exit_status |= add_files_to_cache(prefix, &pathspec, flags);
c972ec04
JH
541
542 if (add_new_files)
610d55af 543 exit_status |= add_files(&dir, flags);
0d781539 544
610d55af
TG
545 if (chmod_arg && pathspec.nr)
546 chmod_pathspec(&pathspec, chmod_arg[0]);
568508e7
JH
547 unplug_bulk_checkin();
548
d521abf8 549finish:
61000814
550 if (write_locked_index(&the_index, &lock_file,
551 COMMIT_LOCK | SKIP_IF_UNCHANGED))
552 die(_("Unable to write new index file"));
0d781539 553
0e5bba53
JK
554 UNLEAK(pathspec);
555 UNLEAK(dir);
7ae02a30 556 return exit_status;
0d781539 557}