http: support CURLOPT_PROTOCOLS_STR

[thirdparty/git.git] / http.c

diff --git a/http.c b/http.c
index ca0fe80ddb86b365c09275e2009cfdf460e010d1..c4b6ddef287b90f6492706cdaa483c1832d8b06c 100644 (file)
--- a/http.c
+++ b/http.c
@@ -764,20 +764,37 @@ void setup_curl_trace(CURL *handle)
        curl_easy_setopt(handle, CURLOPT_DEBUGDATA, NULL);
 }
 
-static long get_curl_allowed_protocols(int from_user)
+static void proto_list_append(struct strbuf *list, const char *proto)
 {
-       long allowed_protocols = 0;
+       if (!list)
+               return;
+       if (list->len)
+               strbuf_addch(list, ',');
+       strbuf_addstr(list, proto);
+}
 
-       if (is_transport_allowed("http", from_user))
-               allowed_protocols |= CURLPROTO_HTTP;
-       if (is_transport_allowed("https", from_user))
-               allowed_protocols |= CURLPROTO_HTTPS;
-       if (is_transport_allowed("ftp", from_user))
-               allowed_protocols |= CURLPROTO_FTP;
-       if (is_transport_allowed("ftps", from_user))
-               allowed_protocols |= CURLPROTO_FTPS;
+static long get_curl_allowed_protocols(int from_user, struct strbuf *list)
+{
+       long bits = 0;
 
-       return allowed_protocols;
+       if (is_transport_allowed("http", from_user)) {
+               bits |= CURLPROTO_HTTP;
+               proto_list_append(list, "http");
+       }
+       if (is_transport_allowed("https", from_user)) {
+               bits |= CURLPROTO_HTTPS;
+               proto_list_append(list, "https");
+       }
+       if (is_transport_allowed("ftp", from_user)) {
+               bits |= CURLPROTO_FTP;
+               proto_list_append(list, "ftp");
+       }
+       if (is_transport_allowed("ftps", from_user)) {
+               bits |= CURLPROTO_FTPS;
+               proto_list_append(list, "ftps");
+       }
+
+       return bits;
 }
 
 #ifdef GIT_CURL_HAVE_CURL_HTTP_VERSION_2
@@ -921,10 +938,26 @@ static CURL *get_curl_handle(void)
 
        curl_easy_setopt(result, CURLOPT_MAXREDIRS, 20);
        curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL);
+
+#ifdef GIT_CURL_HAVE_CURLOPT_PROTOCOLS_STR
+       {
+               struct strbuf buf = STRBUF_INIT;
+
+               get_curl_allowed_protocols(0, &buf);
+               curl_easy_setopt(result, CURLOPT_REDIR_PROTOCOLS_STR, buf.buf);
+               strbuf_reset(&buf);
+
+               get_curl_allowed_protocols(-1, &buf);
+               curl_easy_setopt(result, CURLOPT_PROTOCOLS_STR, buf.buf);
+               strbuf_release(&buf);
+       }
+#else
        curl_easy_setopt(result, CURLOPT_REDIR_PROTOCOLS,
-                        get_curl_allowed_protocols(0));
+                        get_curl_allowed_protocols(0, NULL));
        curl_easy_setopt(result, CURLOPT_PROTOCOLS,
-                        get_curl_allowed_protocols(-1));
+                        get_curl_allowed_protocols(-1, NULL));
+#endif
+
        if (getenv("GIT_CURL_VERBOSE"))
                http_trace_curl_no_data();
        setup_curl_trace(result);