]> git.ipfire.org Git - thirdparty/git.git/commit - archive-tar.c
archive-tar: report filter start error only once
authorRené Scharfe <l.s.r@web.de>
Sat, 29 Oct 2022 10:06:06 +0000 (12:06 +0200)
committerTaylor Blau <me@ttaylorr.com>
Sun, 30 Oct 2022 23:50:43 +0000 (19:50 -0400)
commit1e4ea950f7a83240e15f5e77369cf700b94e8759
tree16f59142c91397e585f27ede92bd600512d6ee83
parent63bba4fdd86d80ef061c449daa97a981a9be0792
archive-tar: report filter start error only once

A missing tar filter is reported by start_command() using error(), but
also by its caller, write_tar_filter_archive(), using die():

   $ git -c tar.invalid.command=foo archive --format=invalid HEAD
   error: cannot run foo: No such file or directory
   fatal: unable to start 'foo' filter: No such file or directory

The second message contains all relevant information and even says that
the failed command was intended to be used as a filter.  Silence the
first one because it's redundant.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
archive-tar.c
t/t5000-tar-tree.sh