]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/blame.c
blame: drop strdup of string literal
authorEric Sunshine <sunshine@sunshineco.com>
Tue, 2 Aug 2016 10:52:53 +0000 (06:52 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 3 Aug 2016 15:52:46 +0000 (08:52 -0700)
commitaa59e14b23b3c075e7f50eae73d9c6812ed96959
treef3266b13aa025f6431c916924330f2be7de78264
parent64093fc06a871f71316211a2aea6bb46c49b20ab
blame: drop strdup of string literal

This strdup was added as part of 58dbfa2 (blame: accept
multiple -L ranges, 2013-08-06) to be consistent with
parse_opt_string_list(), which appends to the same list.

But as of 7a7a517 (parse_opt_string_list: stop allocating
new strings, 2016-06-13), we should stop using strdup (to
match parse_opt_string_list, and for all the reasons
described in that commit; namely that it does nothing useful
and causes us to leak the memory).

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/blame.c