]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/clone.c
clone --dissociate: avoid locking pack files
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Tue, 6 Oct 2015 13:18:47 +0000 (15:18 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 7 Oct 2015 17:47:50 +0000 (10:47 -0700)
commit786b150c8d0960cb7c36fb1cbbf70dbd76b586de
tree2667718cc3d6b6a1fc6a1c1fb06bb3e8daf7ef34
parent38849a8116e690071c02eba0a8ef60a031a58080
clone --dissociate: avoid locking pack files

When `git clone` is asked to dissociate the repository from the
reference repository whose objects were used, it is quite possible that
the pack files need to be repacked. In that case, the pack files need to
be deleted that were originally hard-links to the reference repository's
pack files.

On platforms where a file cannot be deleted if another process still
holds a handle on it, we therefore need to take pains to release all
pack files and indexes before dissociating.

This fixes https://github.com/git-for-windows/git/issues/446

The test case to demonstrate the breakage technically does not need to
be run on Linux or MacOSX. It won't hurt, either, though.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/clone.c
t/t5700-clone-reference.sh