]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/notes.c
builtin/notes: add --allow-empty, to allow storing empty notes
authorJohan Herland <johan@herland.net>
Wed, 12 Nov 2014 00:40:14 +0000 (01:40 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 12 Nov 2014 19:00:11 +0000 (11:00 -0800)
commitd73a5b933db1e722faa54d6709e89e2450d7c1e3
tree758422932df86d91545398515278e7192749937d
parent52694cdabbf68f19c8289416e7bb3bbef41d8d27
builtin/notes: add --allow-empty, to allow storing empty notes

Although the "git notes" man page advertises that we support binary-safe
notes addition (using the -C option), we currently do not support adding
the empty note (i.e. using the empty blob to annotate an object). Instead,
an empty note is always treated as an intent to remove the note
altogether.

Introduce the --allow-empty option to the add/append/edit subcommands,
to explicitly allow an empty note to be stored into the notes tree.

Also update the documentation, and add test cases for the new option.

Reported-by: James H. Fisher <jhf@trifork.com>
Improved-by: Kyle J. McKay <mackyle@gmail.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/git-notes.txt
builtin/notes.c
t/t3301-notes.sh