]> git.ipfire.org Git - thirdparty/git.git/commit - fetch-pack.c
fetch_pack(): drop unused parameters
authorJeff King <peff@peff.net>
Wed, 20 Mar 2019 08:16:14 +0000 (04:16 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 20 Mar 2019 09:34:09 +0000 (18:34 +0900)
commit0f804b0bac39fb696ea74b8dd59549935ec9ca00
tree394d187c972446e54d13da8f85873e9fbe9a3f81
parentc5c33504c906f6bf09fe00a1a32c6c4bdb76ed0f
fetch_pack(): drop unused parameters

We don't need the caller of fetch_pack() to pass in "dest", which is the
remote URL. Since ba227857d2 (Reduce the number of connects when
fetching, 2008-02-04), the caller is responsible for calling
git_connect() itself, and our "dest" parameter is unused.

That commit also started passing us the resulting "conn" child_process
from git_connect(). But likewise, we do not need do anything with it.
The descriptors in "fd" are enough for us, and the caller is responsible
for cleaning up "conn".

We can just drop both parameters.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fetch-pack.c
fetch-pack.c
fetch-pack.h
transport.c