]> git.ipfire.org Git - thirdparty/git.git/commit
Revert "fast-export: use local array to store anonymized oid"
authorJeff King <peff@peff.net>
Thu, 24 Sep 2020 19:22:29 +0000 (15:22 -0400)
committerJunio C Hamano <gitster@pobox.com>
Thu, 24 Sep 2020 19:30:11 +0000 (12:30 -0700)
commit176380fd113a97b09c99a5f7273725527823fa1b
tree0a004dc5a516372b75a3fca87b160b974a82990a
parentc578e29ba0791041ad7fabf1166dd6f7e7f26d1f
Revert "fast-export: use local array to store anonymized oid"

This reverts commit f39ad38410da554af54966bf74fa0402355852ac.

That commit was trying to silence a type-punning warning on older
versions of gcc. However, its analysis was all wrong. I didn't notice
that we _were_ in fact type-punning because there are two versions of
put_be32(): one that uses casts and unaligned loads, and another that
uses bitshifts. I looked at the latter, but on my platform we were
defaulting to the former.

However, as of the previous commit, we'll always use the bitshift
version. So we can drop this hackery to avoid the warning, making the
code slightly cleaner.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fast-export.c