]> git.ipfire.org Git - thirdparty/hostap.git/commit - src/ap/drv_callbacks.c
Clarify AP mode Action frame handling
authorJouni Malinen <j@w1.fi>
Sat, 9 Mar 2019 10:51:34 +0000 (12:51 +0200)
committerJouni Malinen <j@w1.fi>
Sat, 9 Mar 2019 10:51:34 +0000 (12:51 +0200)
commit4d379be4a99d09abe43be9f5a233424bfc5cc43a
treea1a26c322d66fe7d8a097e314fe7420b84311092
parentcc833a236ce254471d3c0237749f28f9a98ae0d8
Clarify AP mode Action frame handling

Include only one of hostapd_mgmt_rx() and hostapd_action_rx() functions
in the build. Previously, NEED_AP_MLME builds (i.e., cases where hostapd
AP MLME implementation is included) included both of these functions and
both were tried in sequence. In addition to being difficult to
understand, that could result in unexpected behavior if
hostapd_mgmt_rx() rejected a frame and return 0 to allow
hostapd_action_rx() to attempt to process the frame.

All the operations included in hostapd_action_rx() are supposed to be
available through the hostapd_mgmt_rx() call in handle_action() and
those should result in the exact same Category/Action-based handler
function to be called in the end. As such, this should not result in
different behavior. And if there is a difference, that would be pointing
at a hidden bug that would need to be fixed anyway. Furthermore, builds
without NEED_AP_MLME would not have any difference in behavior or
contents of the binary either.

Signed-off-by: Jouni Malinen <j@w1.fi>
src/ap/drv_callbacks.c