]>
Commit | Line | Data |
---|---|---|
4f9c6fcc GKH |
1 | From 6061806a863e8b65b109eb06a280041cc7525442 Mon Sep 17 00:00:00 2001 |
2 | From: Christoph Niedermaier <cniedermaier@dh-electronics.com> | |
3 | Date: Tue, 1 Feb 2022 12:36:43 +0100 | |
4 | Subject: drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() | |
5 | ||
6 | From: Christoph Niedermaier <cniedermaier@dh-electronics.com> | |
7 | ||
8 | commit 6061806a863e8b65b109eb06a280041cc7525442 upstream. | |
9 | ||
10 | If display timings were read from the devicetree using | |
11 | of_get_display_timing() and pixelclk-active is defined | |
12 | there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is | |
13 | automatically generated. Through the function | |
14 | drm_bus_flags_from_videomode() e.g. called in the | |
15 | panel-simple driver this flag got into the bus flags, | |
16 | but then in imx_pd_bridge_atomic_check() the bus flag | |
17 | check failed and will not initialize the display. The | |
18 | original commit fe141cedc433 does not explain why this | |
19 | check was introduced. So remove the bus flags check, | |
20 | because it stops the initialization of the display with | |
21 | valid bus flags. | |
22 | ||
23 | Fixes: fe141cedc433 ("drm/imx: pd: Use bus format/flags provided by the bridge when available") | |
24 | Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> | |
25 | Cc: Marek Vasut <marex@denx.de> | |
26 | Cc: Boris Brezillon <boris.brezillon@collabora.com> | |
27 | Cc: Philipp Zabel <p.zabel@pengutronix.de> | |
28 | Cc: David Airlie <airlied@linux.ie> | |
29 | Cc: Daniel Vetter <daniel@ffwll.ch> | |
30 | Cc: Shawn Guo <shawnguo@kernel.org> | |
31 | Cc: Sascha Hauer <s.hauer@pengutronix.de> | |
32 | Cc: Pengutronix Kernel Team <kernel@pengutronix.de> | |
33 | Cc: Fabio Estevam <festevam@gmail.com> | |
34 | Cc: NXP Linux Team <linux-imx@nxp.com> | |
35 | Cc: linux-arm-kernel@lists.infradead.org | |
36 | To: dri-devel@lists.freedesktop.org | |
37 | Tested-by: Max Krummenacher <max.krummenacher@toradex.com> | |
38 | Acked-by: Boris Brezillon <boris.brezillon@collabora.com> | |
39 | Signed-off-by: Marek Vasut <marex@denx.de> | |
40 | Link: https://patchwork.freedesktop.org/patch/msgid/20220201113643.4638-1-cniedermaier@dh-electronics.com | |
41 | Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> | |
42 | Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
43 | --- | |
44 | drivers/gpu/drm/imx/parallel-display.c | 8 -------- | |
45 | 1 file changed, 8 deletions(-) | |
46 | ||
47 | --- a/drivers/gpu/drm/imx/parallel-display.c | |
48 | +++ b/drivers/gpu/drm/imx/parallel-display.c | |
49 | @@ -235,14 +235,6 @@ static int imx_pd_bridge_atomic_check(st | |
50 | if (!imx_pd_format_supported(bus_fmt)) | |
51 | return -EINVAL; | |
52 | ||
53 | - if (bus_flags & | |
54 | - ~(DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_DE_HIGH | | |
55 | - DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | | |
56 | - DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)) { | |
57 | - dev_warn(imxpd->dev, "invalid bus_flags (%x)\n", bus_flags); | |
58 | - return -EINVAL; | |
59 | - } | |
60 | - | |
61 | bridge_state->output_bus_cfg.flags = bus_flags; | |
62 | bridge_state->input_bus_cfg.flags = bus_flags; | |
63 | imx_crtc_state->bus_flags = bus_flags; |